These are chat archives for reactioncommerce/reaction

23rd
Jun 2016
Valery Orloff
@valorloff
Jun 23 2016 06:20
@jshimko docker run -d on hosting server or local maschine?
how to transfer files from local dev folder? by ftp hand?
Owen Hoskins
@owenhoskins
Jun 23 2016 10:33
@aaronjudd Hey, just wanted to check on the module branch merge: is there an expected date? Thxs!
James Scaggs
@jamesscaggs
Jun 23 2016 13:16
Hello, can someone point me to the page to join for the $45/month? I can't find an actual page to subscribe to the platform
eric jonas
@ericmachine88_twitter
Jun 23 2016 13:33
is the market place feature available now?
Aaron Judd
@aaronjudd
Jun 23 2016 14:21
@owenhoskins we’ll be merging module-structure-rebase into development today. There are still pieces that in are in progress, the minimal goal we wanted before merging into development was to have
a) the module import process be pretty solid, and all existing core working
b) some tests passing (because they are all being rewritten for modules, and using mocha
c) at least a working payment package converted to modules
d) docs…. for modules in development
we’re almost there.. but because this is a HUGE update…. just wanted it to be pretty stable even before it made it to development
@jamesscaggs that pricing page needs to be removed and updated from our site. It’s outdated. The sign-up is still just the form on the home page while we give gated access to the hosted platform. We’re not going to fully open that up until we have a 1.0 candidate (right now we’re expecting that to be v0.15.0).
Aaron Judd
@aaronjudd
Jun 23 2016 14:29
@ericmachine88_twitter architecturally it’s supporting multiple shops now, but the switching between shop as an admin in the UI hasn’t been completed. there are several shops that made their own updates to run the marketplace, but it’s not completed yet in an “out of the box” install.
@valorloff which files are referring to? when you do a docker build it will bundle all the local files into the build..
Owen Hoskins
@owenhoskins
Jun 23 2016 14:33
@aaronjudd Thanks for the update. Looking forward to that. Love the module structure.
@aaronjudd: I noticed you are working on the Tax package. I have a VAT feature I need to implement asap. Would you give me a little update on how far along that is?
Aaron Judd
@aaronjudd
Jun 23 2016 14:40
@owenhoskins yes, this got delayed by the module stuff, but as soon as this is merged into development and the existing payment packages are “modularized" (that’s on me). I’ll be back on the tax module - going to pull my existing work into development - it’s the UI, and package registry etc.. will start with a tax rate table where you can manually apply taxes. I’d say another week from now that should be working in development and in a stage where you could add a custom tax module. Planning on including a couple of external tax services as well, have Avalara and TaxJar placeholder in the package now, Avalara supports Vat
if you have specifics stuff you’re looking to implement, go ahead and add your requirements to reactioncommerce/reaction#972 - I’m particularly needing some good EU tax services.. if you know of any such providers.
Owen Hoskins
@owenhoskins
Jun 23 2016 14:42
Funny I was just typing them out here, my VAT needs are pretty simple:
  1. Where a client/business is in the UK – Charge 20% VAT
  2. Where a client/business is outside the scope of VAT (Client/business outside UK and EU)– NO VAT
  3. Where a client/business is based in the EU and NOT REGISTRED for local VAT in their country – Charge 20% VAT
  4. Where a client/business is based in the EU and REGISTRED for local VAT in their country – Charge Zero rate VAT BUT you must have your customers VAT number in the local country before you Zero rate the invoice.
Is that the kind of thing you mean for the github issue?
I don't know of any such providers ATM, but I may very well soon..
Aaron Judd
@aaronjudd
Jun 23 2016 14:44
yeah, just that’s really helpful, if you add that to #972 I’ll pay attention to those rules
that could almost work as a flat rate
Owen Hoskins
@owenhoskins
Jun 23 2016 14:45
I thought so to -- the VAT Number would need an API I believe -- haven't found one in Node though
Aaron Judd
@aaronjudd
Jun 23 2016 14:45
we’d need to add a VAT to the customer profiles as well then.. but that should be easy
Owen Hoskins
@owenhoskins
Jun 23 2016 14:45
If I was to monkey patch those rules into the checkout process, where would you recommend doing it (Hooks, methods?
Aaron Judd
@aaronjudd
Jun 23 2016 14:46
do you normally just collect that during registration? or is there service to look up that info?
Owen Hoskins
@owenhoskins
Jun 23 2016 14:46
Collect it based on the address entered.
Jeremy Shimko
@jshimko
Jun 23 2016 14:49
@valorloff see the Docker deployment docs. The commands I mentioned are supposed to be run on the machine your app is deployed on. But if you’re using Docker Machine (as outlined in the docs) you don’t need to ssh into the remote server because it happens for you automatically under the hood.
https://docs.reactioncommerce.com/reaction-docs/master/deploying-reaction-using-docker
And FTP should be considered a retired technology. ;)
Aaron Judd
@aaronjudd
Jun 23 2016 14:49
@owenhoskins for a hack, I’d add a hook into cartTaxes in the cartTransform to get, or just modify directly the taxes, pending an update..(we can add some hooks in dev as well. )
looking back.. FTP seems so nice and friendly ;-)
Jeremy Shimko
@jshimko
Jun 23 2016 14:52
the good ol’ days
Owen Hoskins
@owenhoskins
Jun 23 2016 14:52
Hehe.
Jeremy Shimko
@jshimko
Jun 23 2016 14:53
Passwords in the clear sent across the internet! Simpler times.
Aaron Judd
@aaronjudd
Jun 23 2016 14:53
I dream of HTML Tables and FTP :worried:
Jeremy Shimko
@jshimko
Jun 23 2016 14:54
There’s still a frightening amount of people using both.
Aaron Judd
@aaronjudd
Jun 23 2016 14:55
yes, but there’s a certain undeniable appeal. but yes.. we’ve moved on..
Jeremy Shimko
@jshimko
Jun 23 2016 14:55
They technically still work, so I guess if it ain’t broke...
(it’s broke)
Aaron Judd
@aaronjudd
Jun 23 2016 14:55
lol
Owen Hoskins
@owenhoskins
Jun 23 2016 14:56
@aaronjudd Thanks for the pointers. Is there a pattern similar (not saying hacky) like that in the codebase I can reference?
Aaron Judd
@aaronjudd
Jun 23 2016 15:03
well, it’s not really hacky - I’m thinking we should add some sanctioned and documented hooks to each of the cart transform steps. You could probably also do it using collection or method hooks, but the taxes,etc are not actually stored until the order is completed https://docs.reactioncommerce.com/reaction-docs/master/method-hooks would let you insert them before the order is saved, but in this case, you’d want the transforms to also show calculated taxes in the cart checkout/review
hrath2015
@hrath2015
Jun 23 2016 15:05
@aaronjudd I find debugging very difficult with module structure. Earlier v.13 was pretty easy on browser and using meteor shell on server. ReactionCore was available everywhere. Now If I type Reaction all is undefined. Any suggestion or pointer to read for debugging.
Valery Orloff
@valorloff
Jun 23 2016 15:05
easier for me as beginner in deploying - turned out to be mupx:
click click - app is deployed)
hrath2015
@hrath2015
Jun 23 2016 15:06
@valorloff it also uses docker under the hood
Valery Orloff
@valorloff
Jun 23 2016 15:07
yes yes, but don't need ftp and other manipulations
hrath2015
@hrath2015
Jun 23 2016 15:07
yes
Jeremy Shimko
@jshimko
Jun 23 2016 15:08

@hrath2015 You could do this on client and server for dev debugging with a global…

import { Reaction } from "/client/api";
// or
import { Reaction } from "/server/api";

R = Reaction;
// or whatever global name you want

Now R would be a global copy of Reaction that you could use like you used to.

hrath2015
@hrath2015
Jun 23 2016 15:10
thanks a lot
Jeremy Shimko
@jshimko
Jun 23 2016 15:10
sure
Owen Hoskins
@owenhoskins
Jun 23 2016 15:10
@aaronjudd Mind offering an example of the general syntax for a hook like you are describing? (really just finding my way around this stuff your comments have been super helpful)
Aaron Judd
@aaronjudd
Jun 23 2016 15:11
we’re actually exporting ReactionCore as well right now, but not sure if we want to keep that or not.. it’s a helper for backwards compatibility and it might be better to just enforce that everyone needs to update to imports/exports..
hrath2015
@hrath2015
Jun 23 2016 15:11
I noticed that is how we are providing backward compatibility to ReactionCore and ReactionRouter
Aaron Judd
@aaronjudd
Jun 23 2016 15:11
yeah ;-)
hrath2015
@hrath2015
Jun 23 2016 15:11
thanks
Jeremy Shimko
@jshimko
Jun 23 2016 15:12
Yeah, I hesitated to mention the ReactionCore global because I don’t want anyone to keep using it. But yeah, Aaron’s right. That’s there too (and is implemented exactly like the above example)
Aaron Judd
@aaronjudd
Jun 23 2016 15:14
@owenhoskins if you give me 48 hours.. let’s get the merge into development done, then I’ll bring in the current tax work and add some hooks and update #972 with some ideas for you. if I haven’t given you what you need in 48 - hit me up again.
Owen Hoskins
@owenhoskins
Jun 23 2016 15:14
much much appreciated.
Aaron Judd
@aaronjudd
Jun 23 2016 15:15
it’ll be really helpful to have your feedback while I am working on it, so :thumbsup:
Valery Orloff
@valorloff
Jun 23 2016 15:22
as soon as I change DEFAULT_LAYOUT to myCustomLayout, console say
layout.js:64 Uncaught TypeError: Cannot read property 'structure' of undefined
why?
Aaron Judd
@aaronjudd
Jun 23 2016 15:30
the layout needs to be defined in the DB as well…?
Valery Orloff
@valorloff
Jun 23 2016 15:38
i see him in DB, in myCustom package entry
should be somewhere else?
Valery Orloff
@valorloff
Jun 23 2016 15:52
from register.js layout with structure adds to DB, where else would determine layout?
where the point in the doc? )
Aaron Judd
@aaronjudd
Jun 23 2016 15:59
https://docs.reactioncommerce.com/reaction-docs/master/layout Layouts are meant to be created using the Package Registry, once they are defined in the Registry.. so that should be it.. are you seeing it in Shops.layout if you look at the db?
Valery Orloff
@valorloff
Jun 23 2016 16:01
yes, it there in shops with
priority:1
position:1
Valery Orloff
@valorloff
Jun 23 2016 16:15
This message was deleted
Valery Orloff
@valorloff
Jun 23 2016 16:23
Aaron Judd
@aaronjudd
Jun 23 2016 20:33
@valorloff sorry was out, didn't see the error. did you get it?
James Scaggs
@jamesscaggs
Jun 23 2016 21:16
I'm getting a white screen on my localhost when I install the latest version