These are chat archives for reactioncommerce/reaction

30th
Jun 2016
Valery Orloff
@valorloff
Jun 30 2016 05:46 UTC
@spencern you use the coreCartWorkflow? or custom?
Spencer Norman
@spencern
Jun 30 2016 05:46 UTC
We use coreCartWorkflow with some custom additions
Valery Orloff
@valorloff
Jun 30 2016 05:48 UTC
in general, somewhere are you using customWorkflow?
Spencer Norman
@spencern
Jun 30 2016 05:48 UTC
We have a few custom workflows, mostly on the admin side for some of our packages
we also have a highly customized product page/template/workflow
Valery Orloff
@valorloff
Jun 30 2016 05:51 UTC
based on coreCartWorkflow?
sorry, coreProductWorkflow?
Spencer Norman
@spencern
Jun 30 2016 05:52 UTC
yes, we didn’t really change the workflow so much as we changed all of the templates associated with the workflow
looking back, I’m not sure this is how I would do it now, but we started back in the RC 0.6 days I think
Have a big refactor on our plate now as we get ready to migrate to the module pattern
and will probably be looking at trying to figure out how to change some of our forked core code into more sustainable additions (modules or plugins of some sort)
Valery Orloff
@valorloff
Jun 30 2016 05:56 UTC
it means, you've made a lot of changes in the core?
Spencer Norman
@spencern
Jun 30 2016 05:58 UTC
More than we’d like - mostly in the product-variant package and in extending some schemas (collections, schemas), but a few other places as well such as reaction-layout, cart, checkout, etc. Mostly minor changes and additions, but any time a minor change diverges from the direction that the RC core is going it causes pain when we try to upgrade
We’ve also written 10 - 12 additional packages to support our app and our internal teams that use it (Customer Service, Fulfillment / Ops, Sales, Marketing)
Valery Orloff
@valorloff
Jun 30 2016 06:03 UTC
Why you did not your custom product-variant?
so as not to touch the core?
Spencer Norman
@spencern
Jun 30 2016 06:07 UTC
We had initially, but there was a change in the product structure around the 0.11 release that added some serious complications to that process and we had a deadline to hit. The product schema has a selector that you have to pass in to make any updates which made it a lot tougher to extend the existing products schema and use existing product methods because so much is hard-coded to the existing product type.
We ended up essentially extending the core product, but added a field we called functionalProductType to the core that we could use to create new product types that would inherit all of the functionality that come with using the core product types simple and variant
so we ended up with type: simple, functionalProductType: rental among other additional product types that we created, which doesn’t seem ideal, but was much less work at the time than doing it the ‘right’ way
Valery Orloff
@valorloff
Jun 30 2016 06:16 UTC
these extensions will need to refactor in the light of the coming update?
a lot of work though
Spencer Norman
@spencern
Jun 30 2016 06:18 UTC
Yeah, it’s quite a bit of work. Definitely better to build the right way the first time if you can. We’ve always known that one of the risks of working with pre-release software is that it’s always changing and we budgeted time for it from the beginning. Still less work than migrating a store over from Magento or Spree :)
Valery Orloff
@valorloff
Jun 30 2016 06:22 UTC
yea
if use a dynamic DB modification on app loading by load.js, it will save the destruction of the factory code?
Spencer Norman
@spencern
Jun 30 2016 06:25 UTC
Like a schema addition?
Valery Orloff
@valorloff
Jun 30 2016 06:26 UTC
schema, db structure
Spencer Norman
@spencern
Jun 30 2016 06:27 UTC
you should be able to do that - we have some packages where we do that, it just wasn’t feasible for all of our circumstances
Brent Hoover
@zenweasel
Jun 30 2016 06:27 UTC
there are certainly some limitations to what you can override in a package
Valery Orloff
@valorloff
Jun 30 2016 06:27 UTC
It could have been full avoided factory code changes?
Spencer Norman
@spencern
Jun 30 2016 06:33 UTC
At the time we were building some of our features, I don’t think we could avoid it entirely, but I think developers starting now should be much more hopeful that extensions to core can be made without a hard fork
Valery Orloff
@valorloff
Jun 30 2016 06:42 UTC
@spencern very interesting, big thanks )
Spencer Norman
@spencern
Jun 30 2016 06:42 UTC
:+1: Good luck
Valery Orloff
@valorloff
Jun 30 2016 06:44 UTC
By the way, how about google Webmaster connect?
Spencer Norman
@spencern
Jun 30 2016 06:45 UTC
Not sure really, I’m in the middle of adding Google Analytics to our shop, but haven’t used Google Webmaster much
Valery Orloff
@valorloff
Jun 30 2016 06:49 UTC
but it's the most important question in e-commerce)
Brent Hoover
@zenweasel
Jun 30 2016 06:50 UTC
You mean the console where you just need to put in your websites name?
Valery Orloff
@valorloff
Jun 30 2016 06:50 UTC
are you already have website crawl indexing?
Spencer Norman
@spencern
Jun 30 2016 06:51 UTC
In our case we have lots of third party sites (news, vendors, etc) that link to our site, so we get crawled fairly frequently anyway
Brent Hoover
@zenweasel
Jun 30 2016 06:51 UTC
not sure what you mean, you sign up in the Webmaster control panel and Google starts indexing your site
You can also not sign up, and Google starts indexing your site
Spencer Norman
@spencern
Jun 30 2016 06:52 UTC
:point_up_2: that’s what I remember in my very infrequent use of Google Webmaster Tools too
Brent Hoover
@zenweasel
Jun 30 2016 06:52 UTC
Anybody who has ever put up a new site that you get about 48 hours before all the spiders come
somtimes bringing down your site in the process (although that’s probably the old days)
Spencer Norman
@spencern
Jun 30 2016 06:53 UTC
apparently people are having trouble with that now if they have the old version of spiderable installed
spins up a phantomJS instance for every bot/page :joy:
Valery Orloff
@valorloff
Jun 30 2016 06:53 UTC
this is true, if there is a html pages
Brent Hoover
@zenweasel
Jun 30 2016 06:54 UTC
Yeah, we discussed that this morning. MDG needs to address those issues. But I think we may start switching to prerender.io which apparently is what Galaxy users get
Spencer Norman
@spencern
Jun 30 2016 06:54 UTC
yeah, we are moving to that as well
Brent Hoover
@zenweasel
Jun 30 2016 06:54 UTC
spiderable should provide you with HTML pages. Not sure if it’s working right now but normally it should work
oh really? interesting
but none of that requires Webmaster Connect
Valery Orloff
@valorloff
Jun 30 2016 06:56 UTC
is spiderable generate static html cache?
Brent Hoover
@zenweasel
Jun 30 2016 06:56 UTC
not a cache, in real time for spiders
legitimate spiders (like Google) provide a URL variable that tell spiderable to render a static HTML rather than dynamic JS
xinmit
@xinmit
Jun 30 2016 07:20 UTC
hey, how to use beesknees?
by simpling adding {
"name": "beesknees",
"enabled": true
}
to reaction.json does not work
anything else need to add to the files?
Brent Hoover
@zenweasel
Jun 30 2016 07:32 UTC
You have to add it to your package file
xinmit
@xinmit
Jun 30 2016 07:32 UTC
./meteor/package?
Brent Hoover
@zenweasel
Jun 30 2016 07:32 UTC
Yes. You have it cloned locally?
xinmit
@xinmit
Jun 30 2016 07:33 UTC
yes, i cloned it down to local
any extra steps to pick it up?
Brent Hoover
@zenweasel
Jun 30 2016 07:34 UTC

Yeah just add

beeknees:beesknees

to your packages file

Are you using master?
xinmit
@xinmit
Jun 30 2016 07:35 UTC
yes, i am using master, where is the packages file?
Brent Hoover
@zenweasel
Jun 30 2016 07:35 UTC
Just like you said ./meteor/packages
xinmit
@xinmit
Jun 30 2016 07:36 UTC
oh, i see. do i need to copy the entire dir to ./meteor/packages?
Brent Hoover
@zenweasel
Jun 30 2016 07:36 UTC
No, it needs to be in the packages directory
xinmit
@xinmit
Jun 30 2016 07:36 UTC
yeah, i have already copied it to packages dir
Brent Hoover
@zenweasel
Jun 30 2016 07:36 UTC
./meteor/packages is just a text file
xinmit
@xinmit
Jun 30 2016 07:36 UTC
got it, thanks
Brent Hoover
@zenweasel
Jun 30 2016 07:37 UTC
:+1:
xinmit
@xinmit
Jun 30 2016 07:38 UTC
this system is awesome, as well as all the documents.
Brent Hoover
@zenweasel
Jun 30 2016 08:13 UTC
:smile:
Himanshu Aggarwal
@haggarwal90
Jun 30 2016 11:41 UTC
Hi Brent
after creating the custom theme, Admin dashboard icons label(like Account Setting icon) are not visible
but it is working fine.
Brent Hoover
@zenweasel
Jun 30 2016 11:42 UTC
What happens when you remove your theme?
Himanshu Aggarwal
@haggarwal90
Jun 30 2016 11:43 UTC
i didnt try that. my project almost at the end so i dont want to remove theme now :)
Brent Hoover
@zenweasel
Jun 30 2016 11:43 UTC
Did you create a custom package?
Himanshu Aggarwal
@haggarwal90
Jun 30 2016 11:43 UTC
yes
Brent Hoover
@zenweasel
Jun 30 2016 11:43 UTC
Then you can just comment it out temporarily in ./meteor/packages
Himanshu Aggarwal
@haggarwal90
Jun 30 2016 11:44 UTC
ok..let me try
Brent Hoover
@zenweasel
Jun 30 2016 11:44 UTC
My suspicion would be that you have a style that has a selector that is colliding with something in the dashboard
Himanshu Aggarwal
@haggarwal90
Jun 30 2016 11:45 UTC
ok . i m checking
and i m suspecting that i have to add icon.less to my custom theme package
i tried that as well but then i was getting version not found error so i reverted back
Brent Hoover
@zenweasel
Jun 30 2016 11:48 UTC
Is it possible you don’t have Font Awesome installed/working?
Himanshu Aggarwal
@haggarwal90
Jun 30 2016 11:50 UTC
in browser or reaction project?
Brent Hoover
@zenweasel
Jun 30 2016 11:50 UTC
in Reaction
pretty sure all those icons are FontAwesome
do you still have the default theme enabled?
Himanshu Aggarwal
@haggarwal90
Jun 30 2016 11:51 UTC
i switched to default theme
and i can see the icons now
any advise? where the error could be?
Brent Hoover
@zenweasel
Jun 30 2016 11:52 UTC
Did you disable it? If you disable it you need to readd those style or leave it enabled and just override the styles you want to change
Himanshu Aggarwal
@haggarwal90
Jun 30 2016 11:52 UTC
ok
yes i disabled it
Brent Hoover
@zenweasel
Jun 30 2016 11:53 UTC
You could just copy all the relevant style info into your custom theme as well
if it’s easier to leave the default theme disabled
Himanshu Aggarwal
@haggarwal90
Jun 30 2016 12:45 UTC
done. thanks. u were right
fonatawsme was missing
Brent Hoover
@zenweasel
Jun 30 2016 12:46 UTC
Ah, great
Aaron Judd
@aaronjudd
Jun 30 2016 14:39 UTC
@spencern you might want to consider prerender.io instead of spiderable. That’s what Galaxy is doing, and we were discussing baking that into launchdock/ our hosted versions as well, considering the overhead and unreliability of spiderable.
Valery Orloff
@valorloff
Jun 30 2016 16:05 UTC
hey, in the docs mentioned /imports/plugins/core/, Session.set("
in the development branch should it work?
Aaron Judd
@aaronjudd
Jun 30 2016 23:45 UTC
@valorloff sorry, not sure what the question is? if Session.set should work? (yes, it should)