These are chat archives for reactioncommerce/reaction

4th
Jul 2016
Brent Hoover
@zenweasel
Jul 04 2016 00:00
@rwatts3 If you can document anything we missed in the docs we can definitely get that updated. We struggle with trying to support all the different ways people want to deploy RC so we try to standardize on Docker
I’m personally not supporting a site, so I run through the instructions and then forget everything since I’m not doing it all the time
Ryan Watts
@rwatts3
Jul 04 2016 01:07
Sure thing. I understand the position you guys are in with RC. Ill see where I can assist with the docs. Partly ill have to actually go through a deployment process to understand where things are missing and could be clarified. Ill keep you posted.
Ballal
@Ballal00
Jul 04 2016 06:10

Hi, I was following this guide
https://hackmd.io/CYUxA4CNgVgNgLQE4DsBjATAgLAZgAyJJwpIIBmAhrnDPgIzhyT7ZA==#

I copied the beesknees folder into reaction/packages. Then I ran ./reaction in terminal, but i get error saying:

"while loading plugin 'analyticsConfigurator' from package 'reaction commerce:reaction-analystics':
error: cant load npm module 'meteor-deque' from packages/meteor.js. check your npm depends.()

Could someone help me out? I'm trying to see how the beesknees packages will change localhost:3000

@zenweasel could u help me out?
Valery Orloff
@valorloff
Jul 04 2016 07:01
@Ballal00 ./reaction reset with No option, then ./reaction
and move main.js to root folder of reaction
Brent Hoover
@zenweasel
Jul 04 2016 07:29
@Ballal00 Not that it’s much different but you probably want to follow the guide here: https://docs.reactioncommerce.com/reaction-docs/master/tutorial
That previous link was when it was still a WIP
Did you run meteor npm install?
Michael Jenny
@prinzdezibel
Jul 04 2016 07:43
@zenweasel Hi Brent. With v0.13.0: Where would functions go that should be available on server AND client? There's no common directory any more.
Brent Hoover
@zenweasel
Jul 04 2016 09:11
@prinzdezibel With 13 or with 14?
I don’t think the directory structure changed much in 14
For 14 the answer would be /lib
Himanshu Aggarwal
@haggarwal90
Jul 04 2016 10:51
How to add third party javascript (js)to reaction commerce
Brent Hoover
@zenweasel
Jul 04 2016 10:52
You can add Meteor or NPM packages.
Himanshu Aggarwal
@haggarwal90
Jul 04 2016 10:53
css (less) can be added in package.js of my-custom-theme
api.addFiles("styles/creditcardjs-v0.10.13.min.less", "client", {isImport: true});
Brent Hoover
@zenweasel
Jul 04 2016 10:53
You can depend on third-party packages in your own package
Himanshu Aggarwal
@haggarwal90
Jul 04 2016 10:54
how??
Brent Hoover
@zenweasel
Jul 04 2016 10:54
api.use(“package-name”);
Himanshu Aggarwal
@haggarwal90
Jul 04 2016 10:55
so do i need to create new package?
third party doesn't have any npm , neither any meteor package
third party just have css and js file
Brent Hoover
@zenweasel
Jul 04 2016 10:56
Oh, then you can just add the files and add them to your package.js
Himanshu Aggarwal
@haggarwal90
Jul 04 2016 10:57

api.addFiles("styles/creditcardjs-v0.10.13.min.less", "client", {isImport: true});
api.addFiles("js/creditcardjs-v0.10.13.min.js", "client");

Brent Hoover
@zenweasel
Jul 04 2016 10:57
Just use the api.addFiles just like you have there
Himanshu Aggarwal
@haggarwal90
Jul 04 2016 10:57
above two are correct? can i add like this to my packae.js
Brent Hoover
@zenweasel
Jul 04 2016 10:57
Yep. That should work.
Michael Jenny
@prinzdezibel
Jul 04 2016 12:27
@zenweasel thx. Is ReactionRegistry deprecated?
Jeremy Shimko
@jshimko
Jul 04 2016 14:23
@rwatts3 Setting INSTALL_MONGO to true is a legacy setting that should be avoided (and definitely not needed) to run Reaction in a Docker container. It was just so you could run the whole app inside a single container. That’s definitely not the recommended approach anymore (with Reaction or Docker). The instructions in the deployment docs can definitely always use more detail, but there’s definitely nothing missing there to get up and running. I use that exact method for every deployment that I do.
Can you elaborate on any other issues you’re seeing?
Michael Jenny
@prinzdezibel
Jul 04 2016 18:11
Somehow the paypal-integration has changed recently. After submitPayment the page is refreshed and the whole Session gets wiped out. Is this intended? (I think this is not good, e.g. the chosen language is lost)
Also for cancelPayment
Jeremy Shimko
@jshimko
Jul 04 2016 18:11
development branch?
Michael Jenny
@prinzdezibel
Jul 04 2016 18:11
yes
I just learned that reloading the page does cause the current session to be wiped out..
Jeremy Shimko
@jshimko
Jul 04 2016 18:14
That’s not good. Would you mind filing an issue with the basic details? I’ll be able to take a closer look a little later.
Michael Jenny
@prinzdezibel
Jul 04 2016 18:15
@jshimko yes, of course.
Jeremy Shimko
@jshimko
Jul 04 2016 18:15
Thanks!
Michael Jenny
@prinzdezibel
Jul 04 2016 18:16
I mean "of course I can file an issue" :)
Jeremy Shimko
@jshimko
Jul 04 2016 18:16
That’s the way I read that. :)