These are chat archives for reactioncommerce/reaction

18th
Jul 2016
Eric Jonas
@ericmachine88
Jul 18 2016 00:46
@aaronjudd oh so this version can have multiple shops on the UI to configure?
shy shy, what’s PR? public release?
Brent Hoover
@zenweasel
Jul 18 2016 00:46
PR = Pull Request
Eric Jonas
@ericmachine88
Jul 18 2016 00:52
oic
thanks @zenweasel
Yagnatech
@Yagnatech
Jul 18 2016 05:17
@zenweasel can you tell me new release has an interface for the multi shops?
Brent Hoover
@zenweasel
Jul 18 2016 05:18
No, it does not. The main point of this release is conversion to ES2015 modules
Yagnatech
@Yagnatech
Jul 18 2016 05:19
Thanks @zenweasel
Brent Hoover
@zenweasel
Jul 18 2016 05:20
The next release will be pretty much what you see on the development branch. There may be a couple of more bug fixes and a plugin loader but that is all
Yagnatech
@Yagnatech
Jul 18 2016 05:20
ok
Brent Hoover
@zenweasel
Jul 18 2016 05:20
I think you can expect more user-facing features in the next (15) release
I don’t expect as long of a gap between releases as this one. There’s not a good way to incrementally refactor for modules
ampali
@ampali
Jul 18 2016 05:29
I am trying to customize my home page using INDEX_OPTIONS. I created a new custom template (with just "Hello World" typed in it) and made an entry of this template file in package.js, but I don't see "Hello World" on my browser. Do I need to make an entry for templates somewhere else also?
Brent Hoover
@zenweasel
Jul 18 2016 05:30
What did you set your INDEX_OPTIONS to?
ampali
@ampali
Jul 18 2016 05:30

Entry in package.js api.addFiles("client/templates/layouts/homePage/custom.html", "client");
content of template file

<template name="customHomePageTemplate">
Hello World
</template>

template: "customHomePageTemplate",
layoutHeader: "layoutHeader",
layoutFooter: "layoutFooter",
notFound: "notFound",
dashboardControls: "dashboardControls",
adminControlsFooter: "adminControlsFooter"
I can see the layoutHeader, but not the contents of my custom temaplate which is just "Hello World"
Brent Hoover
@zenweasel
Jul 18 2016 05:33
which branch are you working on?
ampali
@ampali
Jul 18 2016 05:33
master
Brent Hoover
@zenweasel
Jul 18 2016 05:34
where are you setting INDEX_OPTIONS?
ampali
@ampali
Jul 18 2016 05:34
common/config.js
Brent Hoover
@zenweasel
Jul 18 2016 05:35
in the common directory at the root of the project?
ampali
@ampali
Jul 18 2016 05:35
yes
Brent Hoover
@zenweasel
Jul 18 2016 05:35
Hmmm, that seems like it should work
Do you have your code somewhere I can see it?
ampali
@ampali
Jul 18 2016 05:36
it's all on my local. Let me upload it to github and will share the link.
Brent Hoover
@zenweasel
Jul 18 2016 05:36
kk
ampali
@ampali
Jul 18 2016 06:02
seems like I messed up my git repo. Will fix it and then send u the link :)
Michał Wujas
@wujashek
Jul 18 2016 15:43
Hi, do you know of any sites publicly available based on reaction ? The only one I've found so far is getoutfitted.com
Spencer Norman
@spencern
Jul 18 2016 21:50
Are there any WIP docs on best practices for theming Reaction as of 0.14?
Brent Hoover
@zenweasel
Jul 18 2016 21:51
I think @mikemurray is working on updating his themeing tutorial for 14. Is that what you mean? What sort of things were you looking to see covered?
Spencer Norman
@spencern
Jul 18 2016 21:52
Everything really. We’re migrating getoutfitted from 0.13 -> 0.14
Brent Hoover
@zenweasel
Jul 18 2016 21:52
Well covering everything is a fairly large scope.
Spencer Norman
@spencern
Jul 18 2016 21:52
haha, yeah understandable
Brent Hoover
@zenweasel
Jul 18 2016 21:53
I don’t think the basic ideas have changed much re: theming
Spencer Norman
@spencern
Jul 18 2016 21:53
Where should we put our app level .less files
still essentially forking packages to change html/structure?
Brent Hoover
@zenweasel
Jul 18 2016 21:54
/custom?
Spencer Norman
@spencern
Jul 18 2016 21:54
do they get compiled by default or do we need to import them somewhere?
Brent Hoover
@zenweasel
Jul 18 2016 21:54
No, you can add plugins and then override the templates. That is all covered in the customization guide.
Spencer Norman
@spencern
Jul 18 2016 21:55
override via Template.replaces?
that’s always been more work than it’s been worth in our experience
and caused more trouble down the road than just a hard fork
Brent Hoover
@zenweasel
Jul 18 2016 21:55
No, I mean changing layouts/routes to use your custom templates
Spencer Norman
@spencern
Jul 18 2016 21:56
ah, cool
Brent Hoover
@zenweasel
Jul 18 2016 21:56
I agree. I don’t recommend Template.replaces for anything but a super trivial change
Brent Hoover
@zenweasel
Jul 18 2016 21:57
If you find shortcomings in the approach, we may need to deal with them. I think you will be the first to find them
Yeah, when I say “I”, I guess I am referring to the customization guide
Spencer Norman
@spencern
Jul 18 2016 21:58
is that different than the docs?
Spencer Norman
@spencern
Jul 18 2016 21:59
ah, probably worth changing the theming / templating docs to point there as they still suggest Template.replaces
Brent Hoover
@zenweasel
Jul 18 2016 21:59
Yeah, I guess what is “best practice” is an evolving thing
Spencer Norman
@spencern
Jul 18 2016 22:00
yay Meteor
Brent Hoover
@zenweasel
Jul 18 2016 22:00
well, in this case I don’t know if we can blame it on Meteor
const blame = Javascript || Meteor || Me;
Spencer Norman
@spencern
Jul 18 2016 22:01
yeah, you can always blame Meteor
const blame = Javascript || Meteor || ¯\_(ツ)_/¯
Brent Hoover
@zenweasel
Jul 18 2016 22:01
lol
As you already know, you guys will be our guinea pigs for converting, so any hole in the documentation I will do my best to fill. Sometimes you guys will probably know more than I do though
Spencer Norman
@spencern
Jul 18 2016 22:03
:+1: I’ll do my best to work through it during our migration
Brent Hoover
@zenweasel
Jul 18 2016 22:04
Yeah, even if you tell me “I tried to make heads or tails of X and no luck” I will see what I can do
Spencer Norman
@spencern
Jul 18 2016 22:08
is BeesKnees deployed anywhere publicly?
Brent Hoover
@zenweasel
Jul 18 2016 22:08
No, why?
Spencer Norman
@spencern
Jul 18 2016 22:09
Just curious
Brent Hoover
@zenweasel
Jul 18 2016 22:10
Unfortunately, my front-end skills are super limited so if you looked at it, it would look a lot like stock RC
I am hoping that we can eventually make it more of a showcase for how much you can change
Spencer Norman
@spencern
Jul 18 2016 22:10
yeah, I was mostly looking to see at a glance what all was changed
Brent Hoover
@zenweasel
Jul 18 2016 22:11
Like have a one-page checkout with a completely different design
Spencer Norman
@spencern
Jul 18 2016 22:22
Is there a way to add images /public to plugins right now or should images just go into the main app /public
Our old getoutfitted-theme package had a public directory, but that might be a package specific feature
Brent Hoover
@zenweasel
Jul 18 2016 22:23
Yeah, there are a couple of things that we have lost when we abandoned packages. One of them is having local public and private directories
Spencer Norman
@spencern
Jul 18 2016 22:26
so just push images from all plugins to core /public?
Brent Hoover
@zenweasel
Jul 18 2016 22:27
I think so. Maybe a /public/custom folder