These are chat archives for reactioncommerce/reaction

22nd
Jul 2016
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 00:26

So, I reinstall Meteor and I tried to create their todo app, everything worked.
I'm still having a problem when I run npm install
the postinstall command isn't working (npm ERR! reaction@0.14.0 postinstall: .reaction/scripts/postinstall.sh)
I also did npm install fibers getting the following output:
win32-x64-v8-5.0 exists; testing
Binary is fine; exiting
reaction@0.14.0 D:\Javascript\nuriya
-- fibers@1.0.13 when I running the app using reaction command I'm getting the following errors: W20160722-03:22:58.229(3)? (STDERR) D:\Javascript\nuriya\node_modules\fibers\fibers.js:16 W20160722-03:22:58.229(3)? (STDERR) throw new Error(''+ modPath+ '.nodeis missing. Try reinstallingnode-fibe
W20160722-03:22:58.229(3)? (STDERR) ^
W20160722-03:22:58.229(3)? (STDERR) Error: D:\Javascript\nuriya\node_modules\fibers\bin\win32-ia32-v8-3.14\fibers.node is missing. Try reinstalling node-fibers?
W20160722-03:22:58.229(3)? (STDERR) at Object.<anonymous> (D:\Javascript\nuriya\node_modules\fibers\fibers.js:16:8)
W20160722-03:22:58.229(3)? (STDERR) at Module._compile (module.js:456:26)
W20160722-03:22:58.230(3)? (STDERR) at Object.Modu...

I'm pretty lost at this point

Brent Hoover
@zenweasel
Jul 22 2016 00:29
You are doing meteor npm install?
Aaron Judd
@aaronjudd
Jul 22 2016 01:19
what version of windows? we tested on a machine here and everything went smoothly… @hrath2015 did you have any issues?
hrath2015
@hrath2015
Jul 22 2016 03:24
@TzelonMachluf_twitter I think the library issue still exists. To debug and nail it down please delete the line in package.json https://github.com/reactioncommerce/reaction/blob/master/package.json#L38 and run again. see what happens.
@aaronjudd I am on windows 7
Aaron Judd
@aaronjudd
Jul 22 2016 03:28
I’m not exactly sure why we have that version of fibers in the dependencies, I’ll do some testing to see if it’s really necessary, because I think meteor is now installing it’s own version.
we tested on windows 10, so as usual YMMV.
hrath2015
@hrath2015
Jul 22 2016 03:30
I will work with @TzelonMachluf_twitter to sort this out
Aaron Judd
@aaronjudd
Jul 22 2016 03:32
:+1: thanks. we have one Lenovo Yoga in the office we test on, but really doesn’t cover the all the things that can go wrong. as always, let us know what happens and we’ll push it out quickly. now that 0.14 is out of the way, we’ll push updates quickly (promise!)
import Future from "fibers/future";
Owen Hoskins
@owenhoskins
Jul 22 2016 07:10
Hello all, jumping into the development branch and finding my way around the es6 module structure.. and I am going to drop some questions here as I go: firstly, since things like the UI module is no longer isolated in a meteor style package, it's dependency on juliancwirko:postcss conflicts with fourseven:scss if I included them both in the ./meteor/packages file. How would one approach this type of problem with the new structure?
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 07:32
@hrath2015 Sorry I was away, it was 4 am here
hrath2015
@hrath2015
Jul 22 2016 07:43
NP let me know when u wanna try again
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 07:46
We can do it now
hrath2015
@hrath2015
Jul 22 2016 07:47
u are on which version of windows
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 07:47
windows 10
hrath2015
@hrath2015
Jul 22 2016 07:49
remove the line in package.json for "fibers": "^1.0.13", and do a reaction run
save the file of course
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 07:50
Can we start from the beginning ?
Should I clone reaction git repo or I can use reaction init
hrath2015
@hrath2015
Jul 22 2016 07:52
not needed. u can remove and save.
the file
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 07:52
done
hrath2015
@hrath2015
Jul 22 2016 07:53
reaction run?
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 07:53
=> Started MongoDB.
I waiting
getting the same error on fiber
hrath2015
@hrath2015
Jul 22 2016 07:57
OK
let us do this over again then.
I will also do this in parallel on my machine which windows 7
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 07:58
OK
hrath2015
@hrath2015
Jul 22 2016 07:58
let us get u started first then u can use reaction-cli utility
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 07:59
You want to me to start by installing reaction-cli ?
hrath2015
@hrath2015
Jul 22 2016 07:59
I will post the steps here. PLease follow
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 07:59
OK
sorry
run this command
in a fresh directory
git clone https://github.com/reactioncommerce/reaction.git
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:02
Done
hrath2015
@hrath2015
Jul 22 2016 08:02
cd reaction
git branch
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:03
master
hrath2015
@hrath2015
Jul 22 2016 08:03
ok
remove line "fibers": "^1.0.13", from package.json
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:05
done
hrath2015
@hrath2015
Jul 22 2016 08:05
one confirmation. U are able to run vanilla meteor app on your machine right?
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:06
yep, I run their todo app
ran*
hrath2015
@hrath2015
Jul 22 2016 08:07
meteor npm install
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:08
installing
hrath2015
@hrath2015
Jul 22 2016 08:08
yup for me as well it will take some time
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:10
OK, done.
But I still getting error on the postinstall script:
'.reaction' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! Windows_NT 10.0.10586
npm ERR! argv "C:\Users\Tzelon\AppData\Local\.meteor\packages\meteor-tool\1.3.5_1\mt-os.windows.x86_32\dev_bundle\bin\\node.exe" "C:\Users\Tzelon\AppData\Local\.meteor\packages\meteor-tool\1.3.5_1\mt-os.windows.x86_32\dev_bundle\lib\node_modules\npm\bin\npm-cli.js" "install"
npm ERR! node v0.10.46
npm ERR! npm v3.10.5
npm ERR! code ELIFECYCLE
npm ERR! reaction@0.14.0 postinstall: .reaction/scripts/postinstall.sh
npm ERR! Exit status 1
hrath2015
@hrath2015
Jul 22 2016 08:11
wait mine is really slow.
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:11
ok
@hrath2015 Thank you for helping
hrath2015
@hrath2015
Jul 22 2016 08:15
I also got the error which is fine. It does only copy fonts
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:16
ok
hrath2015
@hrath2015
Jul 22 2016 08:17
meteor
let us see what happens
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:18
Ok, looking good.
processing files ...
hrath2015
@hrath2015
Jul 22 2016 08:19
not so fast. there is loads of stuff..
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:19

getting this warrning
Unable to resolve some modules:

"fibers/future" in /D/Javascript/reaction/server/methods/core/orders.js (os.windows.x86_32)

If you notice problems related to these missing modules, consider running:

meteor npm install --save fibers

But it keep going
hrath2015
@hrath2015
Jul 22 2016 08:20
that is fine
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:20
getting login and password

and this error:
=> Errors prevented startup:

While processing files with ecmascript (for target web.browser):
client/plugins.js:12:31: Bad character escape sequence (12:31)

While processing files with ecmascript (for target os.windows.x86_32):
server/plugins.js:25:31: Bad character escape sequence (25:31)

=> Your application has errors. Waiting for file change.

hrath2015
@hrath2015
Jul 22 2016 08:22
u got login /password printed on console
then this error
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:22
yes
hrath2015
@hrath2015
Jul 22 2016 08:22
mine is slow
please bear with me
still building
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:23
sure, no worries
hrath2015
@hrath2015
Jul 22 2016 08:26
kill process ^c
and press Y
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:27
ok
hrath2015
@hrath2015
Jul 22 2016 08:29
that is something new . I am also having this problem. Surprisingly everything went fine and then it pops up
blob
hrath2015
@hrath2015
Jul 22 2016 08:35
give me sometime need to investigate and will get back. Same set up from old devbranch working fine for me.
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:37
OK. Thanks again for the help
hrath2015
@hrath2015
Jul 22 2016 08:37
Meteor release is new in master METEOR@1.3.5.1. I am on METEOR@1.3.4.4)
one more step
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:38
Im on 1.3.51
1.3.5.1
hrath2015
@hrath2015
Jul 22 2016 08:41
never mind. Let me investigate and get back
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 08:41
OK.
Eric Jonas
@ericmachine88
Jul 22 2016 09:14
does the new release 0.14.0 comes with the multi shop feature? or will that be the next release? look at the release doc, doesn’t seem to have it.
hrath2015
@hrath2015
Jul 22 2016 11:20
@zenweasel I think the issue is with plugin loader. The generated files are causing issue on windows. both on client and server
Brent Hoover
@zenweasel
Jul 22 2016 11:20
How exactly are they causing problems?
It just creates regular JS files
hrath2015
@hrath2015
Jul 22 2016 11:21
client/plugins.js:12:31: Bad character escape sequence (12:31)
some how some character is getting introduced which is not working on windows
Brent Hoover
@zenweasel
Jul 22 2016 11:22
Hmmm
Can you paste the code in here?
hrath2015
@hrath2015
Jul 22 2016 11:23
first diffrence I noticed is import "/imports\plugins\core\checkout\client";
/ and \
this is from generated file
Brent Hoover
@zenweasel
Jul 22 2016 11:24
Oh boy
What happens if you change the direction of the slashes?
hrath2015
@hrath2015
Jul 22 2016 11:25
this file is replacing earlier main.js?
Brent Hoover
@zenweasel
Jul 22 2016 11:25
Yeah
It just creates the imports automatically
hrath2015
@hrath2015
Jul 22 2016 11:26
where is the code if u know for loader?
If not I will have a look at it later. First let me change the slash and test.
Brent Hoover
@zenweasel
Jul 22 2016 11:27
server/startup/plugins.js
hrath2015
@hrath2015
Jul 22 2016 11:27
I think that could be a problem. Let me verify and get back
thanks
Brent Hoover
@zenweasel
Jul 22 2016 11:28
I’m guessing there is some path utility that is trying to be os-compliant, but in this case it shouldn't
Probably here
  const getDirectories = (dir) => {
    return fs.readdirSync(dir).filter((file) => {
      return fs.statSync(path.join(dir, file)).isDirectory();
    });
  };
hrath2015
@hrath2015
Jul 22 2016 11:30
Yep.
It is starting keeping fingers crossed
Brent Hoover
@zenweasel
Jul 22 2016 11:31
lol
hrath2015
@hrath2015
Jul 22 2016 11:38
catch 22 if u restart it will take it back to old stuff. It needs to be changed while server running
Brent Hoover
@zenweasel
Jul 22 2016 11:38
Hmm, yes. There’s no way to disable the plugin loader
hrath2015
@hrath2015
Jul 22 2016 11:39
need a fix here then
Brent Hoover
@zenweasel
Jul 22 2016 11:40
  const getImportPath = (pluginFile) => {
    return "/" + path.relative(appRoot, pluginFile);
  };
I’m thinking you can just reverse the slashes there
hrath2015
@hrath2015
Jul 22 2016 11:46
this is how it should be. forward slash.
Brent Hoover
@zenweasel
Jul 22 2016 11:47
Do you want to try just doing a string replace right at that line and see if it does it?
Ah yes, replacing slashes with regex, what a joy
hrath2015
@hrath2015
Jul 22 2016 11:48
I did already
Brent Hoover
@zenweasel
Jul 22 2016 11:49
And?
hrath2015
@hrath2015
Jul 22 2016 11:49
same issue
Brent Hoover
@zenweasel
Jul 22 2016 11:50
Still the wrong slashes in the file?
hrath2015
@hrath2015
Jul 22 2016 11:50
I have to step out now.
Brent Hoover
@zenweasel
Jul 22 2016 11:50
kk
hrath2015
@hrath2015
Jul 22 2016 11:50
Will resume it later
Jeremy Shimko
@jshimko
Jul 22 2016 15:45
A fix for the Windows import paths is coming soon.
reactioncommerce/reaction#1186
Jeremy Shimko
@jshimko
Jul 22 2016 16:08
PR submitted
reactioncommerce/reaction#1187
hrath2015
@hrath2015
Jul 22 2016 16:58
:thumbsup:
hrath2015
@hrath2015
Jul 22 2016 17:34
@jshimko I tested it. Working OK.
Couple of observation: it is restarting server again. Could be because of file change(new created plugins.js) on server
Jeremy Shimko
@jshimko
Jul 22 2016 17:35
Awesome. Thanks!
hrath2015
@hrath2015
Jul 22 2016 17:36
2nd server re start happens immediately
After I changed the code and built it did not re create the files. Old files remain and not deleted. I had to manually delete and restart.
Tzelon Machluf
@TzelonMachluf_twitter
Jul 22 2016 21:57
Hey, So you found the problem.
saw*
that's great.
What should I do to fix my version ?