These are chat archives for reactioncommerce/reaction

18th
Aug 2016
Brent Hoover
@zenweasel
Aug 18 2016 01:34
@/all v0.1.5.0 has been released. Check out the release notes or the blog for more details. https://github.com/reactioncommerce/reaction/releases/tag/v0.15.0
Daniel Reyes
@deearcodes
Aug 18 2016 03:45
Hey guys, I've done a fress install of reaction v0.15.0 and after installing and running the application I cant access to the routes, catalog, internationalizarion
*internationalization
As if they weren't installed
Do I have to install those plugins?
It also happens with Email, Layout, Inventory.
Jeremy Shimko
@jshimko
Aug 18 2016 03:52
I don’t have any issue with a fresh clone as of just now.
reaction init clones master and everything runs as expected
Daniel Reyes
@deearcodes
Aug 18 2016 03:53
I've double checked
reaction init on local machine
the tried using the docker image
but nothing happens when I click those in the Admin Dashboard
Brent Hoover
@zenweasel
Aug 18 2016 03:58
At least for internationlization you need to click on the gear icon
Daniel Reyes
@deearcodes
Aug 18 2016 03:58
Yes, I noticed that with i18n sorry
But the others aren't working
switched browsers, did a clean install, and now docker image and getting the same behavior
Jeremy Shimko
@jshimko
Aug 18 2016 03:59
Those links all work fine for me.
Is there anything in the browser console?
Daniel Reyes
@deearcodes
Aug 18 2016 04:00
Nope
Jeremy Shimko
@jshimko
Aug 18 2016 04:02
Every browser and every install of Reaction and no errors anywhere?
Brent Hoover
@zenweasel
Aug 18 2016 04:02
@jshimko what do you see when you click on Inventory?
Daniel Reyes
@deearcodes
Aug 18 2016 04:03
could you share the direct url? is it reaction/dashboard/catalog? reaction/dashboard/inventory?
Brent Hoover
@zenweasel
Aug 18 2016 04:03
I also get nothing for Inventory, Routing, and Layout
Antonin Hackenberg
@TondaHack
Aug 18 2016 04:05
Hi, playing with new release and also nothing for Inventory, Routing, and Layout
Jeremy Shimko
@jshimko
Aug 18 2016 04:09
Did they actually have links before? The don’t have anything in the registry.
https://github.com/reactioncommerce/reaction/blob/master/imports/plugins/included/inventory/register.js
Daniel Reyes
@deearcodes
Aug 18 2016 04:10
That should be the issue...
Jeremy Shimko
@jshimko
Aug 18 2016 04:11
So the issue seems to be that it implies there’s a link (hover state), not that there isn’t a link. Correct?
Which I totally agree is an issue if that’s the case.
Brent Hoover
@zenweasel
Aug 18 2016 04:14
well the issue would also be, why does that card exist if there is nothing you can do with it
Daniel Reyes
@deearcodes
Aug 18 2016 04:28
yes it's strange
Brent Hoover
@zenweasel
Aug 18 2016 04:30
I agree that it’s a little confusing
maybe more than a little
ishaq-bhojani
@ishaq-bhojani
Aug 18 2016 07:51
Links also not working at my End @zenweasel @deearcodes @jshimko
ishaq-bhojani
@ishaq-bhojani
Aug 18 2016 08:27
is there any temporary solution for i just need to view the products and inventory page
Brent Hoover
@zenweasel
Aug 18 2016 10:00
therre is no product or inventory page
You can edit products from within the product view if you are logged in as an admin
ishaq-bhojani
@ishaq-bhojani
Aug 18 2016 12:26
products link is not working
I've recreated the project but got same iisue again
Brent Hoover
@zenweasel
Aug 18 2016 12:31
There is no product page to navigate to
you edit products from within normal product view pages
e.g. the home page
Brent Hoover
@zenweasel
Aug 18 2016 12:36
When you edit a product you can make changes to inventory settings, etc
Spencer Norman
@spencern
Aug 18 2016 15:29
@zenweasel - I saw that you’ve closed #1259. In general I agree that much of that discussion is related to the discussion in #1278. Wondering if you can suggest a way forward for the time being until these challenges are resolved. Currently we’re still running the code in #1259
Adth0nB
@AdthonB_twitter
Aug 18 2016 17:16
Hello I need some help. I build Docker images with your reaction.dev .dockerfile in Github but I stuck on downloading Meteor 2-3 hours. No problem with my internet. Can anyone tell me what I should to do ?
Antonin Hackenberg
@TondaHack
Aug 18 2016 17:27
Hi, I was working just with Dockerfile in the root and build on travis takes 11 minutes
But there is not DEV_BUILD variable and different install of Meteor
Do you have some log or error there?
Spencer Norman
@spencern
Aug 18 2016 17:30
Is there any way to extend the stores defined for CollectionFS images without adding directly to the collections.js file? In the past we’ve just added them to this array, but if there’s a way to add them from our module, that’d be better.
Adth0nB
@AdthonB_twitter
Aug 18 2016 17:37
@TondaHack I don't know where logs file store. I use Docker Toolbox.
on Windows.
Antonin Hackenberg
@TondaHack
Aug 18 2016 17:46
I use Linux. Did you try log to the container logs? https://docs.docker.com/engine/reference/commandline/logs/
Adth0nB
@AdthonB_twitter
Aug 18 2016 17:48
@TondaHack Thank u sir but I still stuck on build images from Dockerfile. I try to follow this step: https://github.com/reactioncommerce/reaction/issues/1034#issuecomment-221138737
Antonin Hackenberg
@TondaHack
Aug 18 2016 17:56
Ok.. Good luck.
We have working build on docker.cloud. It is little bit different use-case.
Jeremy Shimko
@jshimko
Aug 18 2016 18:45
@AdthonB_twitter the DEV_BUILD environment variable has no effect on whether Meteor gets installed. When DEV_BUILD === true, the script installs and caches the latest version of Meteor (regardless of what version the app uses). The regular build (without DEV_BUILD set) installs the version of Meteor that’s specified in the app (with no caching). And the production Dockerfile is not supposed to have that variable.
Anyway, nobody else seems to be having any issue with the Docker build right now (including our CI server that uses the exact same Dockerfile), so I’ll need you to provide details of your OS, the output of reaction -v, and the exact steps you’re using to build/run the container.
Adth0nB
@AdthonB_twitter
Aug 18 2016 22:28
@jshimko Thank you for help me. I am new for Docker. I use Docker on Windows from Docker Toolbox. First time I pull images from Docker hub and run it but I got an error about MONGO_URL then I try to run with Docker compose. I put reaction/.reaction/* and Dockerfile (add text from reaction.dev.dockerfile) in root project directory, and run docker build command but my terminal stuck on Downloading Meteor. Can you suggest the correct step for me ?
Brent Hoover
@zenweasel
Aug 18 2016 22:33
@spencern I guess I was hoping that I would get a little more feedback on the two approaches that I suggested there. Let me see if I can at least run those by the team and if everybody thinks that makes sense I can put in some tickets to try and get them done.
Or maybe I should just put in tickets and get some feedback that way
Spencer Norman
@spencern
Aug 18 2016 22:34
I can give a little more feedback on both of those if you like, but for me it’s one of those hard to know if it solves the problem until it’s done type of things unfortunately
I do think that some of the workflow/state machine untangling seems to be much more complicated (hopefully) than being able to override specific route templates
Brent Hoover
@zenweasel
Aug 18 2016 22:35
well, I think some of it is in the semantics
Spencer Norman
@spencern
Aug 18 2016 22:36
perhaps
Brent Hoover
@zenweasel
Aug 18 2016 22:36
I think workflow might be an unfortunate name for “an ordered set of templates"
Spencer Norman
@spencern
Aug 18 2016 22:36
yeah
in the case of cart (maybe dashboard orders too?) it does behave somewhat like a state machine
Brent Hoover
@zenweasel
Aug 18 2016 22:37
but there are real workflows for carts and orders that are currently hardcoded
Spencer Norman
@spencern
Aug 18 2016 22:37
yeah, most other areas it just seems to be a way to categorize
Brent Hoover
@zenweasel
Aug 18 2016 22:37
I guess I was copping out a little and trying to solve your problem incrementally rather than a rethinking of concepts
Spencer Norman
@spencern
Aug 18 2016 22:38
not a cop out
I think we’re trying to figure out the same thing
but the deeper I seemed to go, the more fundamental some of the issues seem
Brent Hoover
@zenweasel
Aug 18 2016 22:39
I think workflow is a whole thing that needs to be looked at for sure, but the issue is that does it need to be solved before anything else can be solved
Spencer Norman
@spencern
Aug 18 2016 22:39
yeah
Brent Hoover
@zenweasel
Aug 18 2016 22:40
Aaron’s been heads-down on taxes so hopefully he will have some time to spend because I don’t feel confident with going forward without his input
Spencer Norman
@spencern
Aug 18 2016 22:40
yeah, totally understandable
Brent Hoover
@zenweasel
Aug 18 2016 22:40
He has a vision for some of this stuff that I don’t always know about/understand
Spencer Norman
@spencern
Aug 18 2016 22:40
and I’ve been pushing him to get Taxes done, so it all comes full circle for sure ;)
Where we’re at is trying to be patient while everything unfolds, but also having to build something today that works Oct 1.
Brent Hoover
@zenweasel
Aug 18 2016 22:42
What happens Oct 1, the Winter season?
Spencer Norman
@spencern
Aug 18 2016 22:42
Yeah, winter season starts Oct 1 for us.
So some of this is trying to find the best solution right now that we know we’ll have to re-write after launch. Trying to figure out how to prioritize
  1. Getting the code migrated quickly
  2. Adding features and changes modularly so we don’t have merge conflicts when pulling in latest RC core
  3. Helping to identify real issues that we could contribute back to core that solve current problems we have
Brent Hoover
@zenweasel
Aug 18 2016 22:45
so really you are looking to be code complete in about a month
Spencer Norman
@spencern
Aug 18 2016 22:49
ideally. We’ve almost finished migrating all of our old packages into the new imports/modules pattern and almost done migrating the theme too
but there are just a few things that we’ve run into where we’re seeing issues
Currently we’re maintaining a slight fork of core (~15-20 files changed I think), but I’m starting to see the downside of that as there are certainly things that we’ve changed that have consequences that we didn’t see until using it for a bit.
For example, the change where we switched the router params around caused the INDEX_OPTIONS settings to stop working
which led us to work around that, and so on
Brent Hoover
@zenweasel
Aug 18 2016 22:51
Right
Spencer Norman
@spencern
Aug 18 2016 22:52
so we definitely realize that the fewer changes to core the better, but also working under a time crunch
Brent Hoover
@zenweasel
Aug 18 2016 22:52
I had a bad feeling about that change
Spencer Norman
@spencern
Aug 18 2016 22:52
yeah
Brent Hoover
@zenweasel
Aug 18 2016 22:52
well, forking templates seems like the easiest way isn’t it?
Spencer Norman
@spencern
Aug 18 2016 22:52
you’re not wrong
but we’ve spent so much time pulling everything out that it feels like a lot of work to put it back. We did have that discussion today though about just scrapping a lot of our theme module and just pushing it all back into the core templates
Brent Hoover
@zenweasel
Aug 18 2016 22:54
I see
well, Aaron’s prepping for a Meteor Meetup talk (or giving it, I forget what time it was). But either later today (unlikely) or on/before Monday I can try to talk to him about how he wants to move forward
Spencer Norman
@spencern
Aug 18 2016 22:56
Thanks :+1: I appreciate the time you’ve spent working with me on these issues
Brent Hoover
@zenweasel
Aug 18 2016 22:56
I’m working on Search, but I have definitely not forgot about your issue(s). Although worrying about them won’t get them fixed
Spencer Norman
@spencern
Aug 18 2016 22:58
it might :smile:
Adth0nB
@AdthonB_twitter
Aug 18 2016 23:34
@jshimko finally, It's work.