These are chat archives for reactioncommerce/reaction

18th
Oct 2016
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 02:25
does reaction cli have a flag that can be passed to delete or not delete npm through an arg?
Brent Hoover
@zenweasel
Oct 18 2016 02:26
reaction reset -n
will reset the db and not the module
Jeremy Shimko
@jshimko
Oct 18 2016 02:26
and -y will delete node_modules and reinstall them
Brent Hoover
@zenweasel
Oct 18 2016 02:27
This message was deleted
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 02:27
great thanks! next question for the evening... with reaction reset being needed to account for changes to the templates locally, is there a solution for pushing the changes to production without needing to reset the db there?
Brent Hoover
@zenweasel
Oct 18 2016 02:31
there is no reason to reset for changes to templates
only to the registry
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 02:32
but I would need to do the reset to account for the registry changes in the plugin?
Brent Hoover
@zenweasel
Oct 18 2016 02:33
that’s correct
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 02:34
wouldn't I loose account and product info?
Brent Hoover
@zenweasel
Oct 18 2016 02:35
yes you would
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 02:36
would the solve for that be to export (if there is a way) the data in the production db and store that locally in private/data?
Brent Hoover
@zenweasel
Oct 18 2016 02:36
you could just delete the record and then it will get rewritten on start
that’s what most people do. Exporting data is covered in the customization guide
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 02:37
ok so that updates the registry but leaves the other collection intact
I like the export data.. seems like a more elegant solution.. but good to know that works as well
Brent Hoover
@zenweasel
Oct 18 2016 02:38
yeah, it’s currently written to not overwrite if the record already exists
so that if you modify the db it doesn’t get lost
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 02:38
makes sense
Jeremy Shimko
@jshimko
Oct 18 2016 02:38
You could also just drop the Packages collection and restart the app. That would rebuild the registry entries.
Brent Hoover
@zenweasel
Oct 18 2016 02:38
something like reaction reset-registry would probably be helpful
yeah, same deal, slightly more nuclear
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 02:39
reaction reset -registry ?
yeah that would be helpful
Jeremy Shimko
@jshimko
Oct 18 2016 02:39
more nuclear than what?
Brent Hoover
@zenweasel
Oct 18 2016 02:39
I am just dreaming up stuff for @jshimko to do. He loves that
more nuclear than just deleting the record for his plugin
Jeremy Shimko
@jshimko
Oct 18 2016 02:40
oh right
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 02:41
I saw a couple items around a reaction hero/carousel. Wasn't clear if this was merged into recent builds?
Brent Hoover
@zenweasel
Oct 18 2016 02:42
No, we don’t currently have any plans to include a carousel. That would definitely something you would want to customize.
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 02:43
ok makes sense just wanted to clarify from this thread reactioncommerce/reaction#20
Brent Hoover
@zenweasel
Oct 18 2016 02:44
Getoutfitted has integrated a carousel into their site and I think @spencern had said he was willing to share
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 02:45
That would be super helpful to take a look at :)
Brent Hoover
@zenweasel
Oct 18 2016 02:45
now that the PDP is React, you could also integrate one of the thousands of React components
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 02:46
yes, that was a question i was meaning to ask. Slick carousel in react has been useful in a few tests for work.. I will take a look there
@zenweasel @jshimko Very helpful, thank you both!
Jeremy Shimko
@jshimko
Oct 18 2016 02:49
:thumbsup:
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 20:36
Anyone explain the thinking around product-variant and product-detail-simple? Is simple were the React work is being done?
Aaron Judd
@aaronjudd
Oct 18 2016 20:49
in development, the “product-detail-simple” is the new react based simple product that implements revisions. You have to enable “revisions control” in the dashboard, and then the products use this new version. If you don’t have revisions enabled, we use the “product-variant” - which really is the “simple” as well, but using the older blaze/non-react/without revisions.
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 20:50
Thanks, seems like this is only in dev branch?
Aaron Judd
@aaronjudd
Oct 18 2016 20:50
I’m packaging up the release for merge to master today actually
but yes, only in dev right now
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 20:50
Excellent, look forward to playing with this thanks!
Donovan Adams - Hydrotik
@hydrotik
Oct 18 2016 23:08
Is there a recommended pattern/strategy for loading external dependancies in a plugin?