These are chat archives for reactioncommerce/reaction

19th
Oct 2016
Brent Hoover
@zenweasel
Oct 19 2016 00:23
@hydrotik do you mean structuring your imports? Or adding npm packages?
3Maestros
@3Maestros
Oct 19 2016 01:37
@zenweasel I need to make some changes to Product schema and also to the Product UI. Can you tell me how do I update the schema without touching reaction file?
Brent Hoover
@zenweasel
Oct 19 2016 02:03
@3Maestros have you read the section in the Customization Guide?
3Maestros
@3Maestros
Oct 19 2016 02:16
I have guess it's time to read it one more ..
Brent Hoover
@zenweasel
Oct 19 2016 02:17
If you want to add a field, just declare a schema wtih the same name and only that field and attach it. Schemas are additive by default.
Brent Hoover
@zenweasel
Oct 19 2016 02:26
To remove a field you need to redeclare the schema minus the fields you wish to remove, then attach them with { replace: yes }
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 02:55
@zenweasel I suppose both, for example i want to npm in react-slick but I would need to do that after loading in the custom plugin into the overall RC project. Image assets would be another question. I created a public folder in the custom plugin but that didn't work and it seems like a similar question related to how you would bundle the plugin?
Brent Hoover
@zenweasel
Oct 19 2016 03:02
For npm packages you just need to add it to package.json and just keep that file up to date by hand
at some point we will allow plugins to have their own package.json but that’s how you need to do it now
re: images
unfortunately Meteor only recognizes the public and private files at the root of the project (it used to recognize them in packages, but packages are no more)
so we recommend putting things in private/custom
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:04
ok that was sort of what I thinking.. or something to point to it in the registry as well as registering/syncing public static assets
ok
I can put in public for now, I wasn't sure if Meteor had something like Express or Hapi with the ability to have multiple static folders assigned
Brent Hoover
@zenweasel
Oct 19 2016 03:05
I am just about to start on this ticket reactioncommerce/reaction#1221 which will probably change the way we handle images
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:06
might be good to include fonts and any other binaries in there?
Brent Hoover
@zenweasel
Oct 19 2016 03:06
sort of different things
fonts would not be attached to a product for example
yeah, I am not sure how you handle fonts
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:08
but if your theme is part of a plugin, wouldn't that be bundled in that static public folder within the plugin? (for arguments sake)
Brent Hoover
@zenweasel
Oct 19 2016 03:08
I don’t know what you mean
in terms of how Meteor work, plugins are not a thing, they are just another directory
that’s a Reaction convention, not a Meteor one
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:09
ah ok
Brent Hoover
@zenweasel
Oct 19 2016 03:10
unfortunately when Meteor dropped packages they dropped a couple of features that npm packages don’t replace
handling local files being one of them
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:12
maybe some bash script in Reaction can copy the files registered in the plugin to some standardized folder structure using the plugin name?
Brent Hoover
@zenweasel
Oct 19 2016 03:13
we are trying to avoid creating more build tools on top of Meteor (which is already a giant build tool)
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:13
fair enough
Brent Hoover
@zenweasel
Oct 19 2016 03:14
we are constantly debating whether to move to another build tool that provides us more flexibility
e.g. webpack
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:14
yeah I have done a bit of work there with that
Brent Hoover
@zenweasel
Oct 19 2016 03:15
either we get too frustrated with Meteor or customers push us in that direction
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:15
did some work for a boilerplate project that uses Hapi, Node, React, Typescript... will eventually help us create a headless/flat file cms
everything has it's level of frustrations, i used Mean.io for a while and gave up on that as well when work moved move to React
Brent Hoover
@zenweasel
Oct 19 2016 03:16
in the long, long term it does seem that the future of Meteor is for Meteor to disappear
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:16
good to know:)
Brent Hoover
@zenweasel
Oct 19 2016 03:16
leaving you with Apollo and DDP
that’s just my opinion
we spend a lot of time aligning ourselves with MDG so when they are there we will be too
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:18
I haven't looked into it yet, but I wonder if Yarn solves some of these issues
Brent Hoover
@zenweasel
Oct 19 2016 03:18
I don’t think so
but I haven’t looked into it in depth either
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:21
Regardless of the stack the plugin/nested module seems to be a common problem that I have come across and seen with projects these days. Will be nice to see that somewhat standardized
Brent Hoover
@zenweasel
Oct 19 2016 03:22
yep. There’s a lot more we would like to do, but we need to get more people on the platform
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:24
makes sense, I could see this nicely complementing that CMS project for side projects. Sort of models what I have been seeing at work
Brent Hoover
@zenweasel
Oct 19 2016 03:24
we have CMS on our near-term roadmap. It’s probably the number 1 requested feature
Donovan Adams - Hydrotik
@hydrotik
Oct 19 2016 03:25
yeah I saw a little bit of that in the repo
samgitre
@samgitre
Oct 19 2016 07:17
Hi everyone
please I have problem with using a customise template in reactioncommerce
I have created the template but the app is not seeing it to use
Please any help is appreciated
Brent Hoover
@zenweasel
Oct 19 2016 08:52
hey @samgitre What have you done so far?
gdumie01
@gdumie01
Oct 19 2016 10:07

Hey!

I had already posted this question but I guess I did not yet see it answered anywhere, so would really appreciate your support.

I understand that I can use tags to do some "categorization" of the product. However, if I want my "categories" to have more than just a name, say for instance an illustrative image and some short description, how can I solve that?

Thanks a lot in advance and keep up the good work.

Brent Hoover
@zenweasel
Oct 19 2016 10:07
You can just extend the tag schema and add those values
gdumie01
@gdumie01
Oct 19 2016 10:14
perfect, thanks
then I just need to work on the templates to enable its edition on the admin panel right?
Brent Hoover
@zenweasel
Oct 19 2016 10:18
correct. We are just about ready to release a new version of the product detail page that is all React. So you would probably want to work with that
gdumie01
@gdumie01
Oct 19 2016 10:38
ok, great to hear
thanks again
Brent Hoover
@zenweasel
Oct 19 2016 10:43
:+1:
Frank Gutierrez
@dearfrankg
Oct 19 2016 23:21
problem when start reaction using dev branch:
=> Started your app.

=> App running at: http://localhost:3000/
/Users/frankg/.meteor/packages/coffeescript/.1.2.4_2.1ooigf3++os+web.browser+web.cordova/plugin.compileCoffeescript.os/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:165
      throw error;
      ^

Error: ENFILE: file table overflow, scandir '/Users/frankg/dev/code/projects/cart-project/reaction/imports/plugins/core/layout/client/templates/layout'
    at Error (native)
Brent Hoover
@zenweasel
Oct 19 2016 23:27
so your meteor installation has created more open files than your system allows
Here is what I have done on my machine (OS X) to fix this:
# increase open file limit because Mete
echo kern.maxfiles=65536 | sudo tee -a /etc/sysctl.conf
echo kern.maxfilesperproc=65536 | sudo tee -a /etc/sysctl.conf
sudo sysctl -w kern.maxfiles=65536
sudo sysctl -w kern.maxfilesperproc=65536
ulimit -n 65536 65536