These are chat archives for reactioncommerce/reaction

20th
Oct 2016
Frank Gutierrez
@dearfrankg
Oct 20 2016 00:12
@zenweasel thanks
James Scaggs
@jamesscaggs
Oct 20 2016 00:28
I had that exact same error
Brent Hoover
@zenweasel
Oct 20 2016 00:41
it’s probably a bit nuclear. You may not need all of it, you will need to experiment. But that fixes it for me
Frank Gutierrez
@dearfrankg
Oct 20 2016 01:50
problem trying to run tests on dev branch
npm run test-local

> reaction@0.17.0 test-local /Users/frankg/dev/code/projects/cart-project/reaction
> wdio tests/runner/local.conf.js

## There is an issue with `node-fibers` ##
...
Brent Hoover
@zenweasel
Oct 20 2016 01:53
those are acceptance tests which are not really meant for public consumption yet
reaction test is that you want
Frank Gutierrez
@dearfrankg
Oct 20 2016 01:53
I was trying to run all tests
Brent Hoover
@zenweasel
Oct 20 2016 01:54
Ok, but setting up your machine to run acceptance tests is not a trivial task
Frank Gutierrez
@dearfrankg
Oct 20 2016 01:54
btw, what's the difference between the two types of tests?
I have selenium installed
Brent Hoover
@zenweasel
Oct 20 2016 01:56
the steps to get everything set up to run acceptance tests are here: https://docs.reactioncommerce.com/reaction-docs/master/acceptance-testing#test-setup
Frank Gutierrez
@dearfrankg
Oct 20 2016 01:56
I'll look them over and give it a go
Brent Hoover
@zenweasel
Oct 20 2016 01:56
Acceptance tests are browser-based tests that test the app from the user perspective
The tests that run under reaction test are integration tests, that primarily test functionality on the server-side
Frank Gutierrez
@dearfrankg
Oct 20 2016 01:57
I only see tests under the tests directory -- are there tests?
Brent Hoover
@zenweasel
Oct 20 2016 01:57
there are currently over 200 integrations tests that run
integration tests are placed next to the code they test
Frank Gutierrez
@dearfrankg
Oct 20 2016 01:59
ok - thanks
I'll look it all over
3Maestros
@3Maestros
Oct 20 2016 03:18
@zenweasel I need to make a minor change as small show and hide attribute in a page without touching reaction codebase, how to do this? Do I have to take a plugin route and override the related template, or are there any creative ways to handle this?
Brent Hoover
@zenweasel
Oct 20 2016 03:19
You could use Template.replaces and put the template in the client directory
I would pretty much always recommend creating a plugin just because I think it makes keeping your code organized easier, but that’s just my opinion
Frank Gutierrez
@dearfrankg
Oct 20 2016 05:53
I have run the integration and acceptance tests - where can I find the test coverage info?
Brent Hoover
@zenweasel
Oct 20 2016 05:53
We don’t currently have test coverage info
Frank Gutierrez
@dearfrankg
Oct 20 2016 05:53
ok
Frank Gutierrez
@dearfrankg
Oct 20 2016 17:04
circle-ci giving me this error:
00:03config
Exit code: 1
docker push reactioncommerce/base:$CIRCLE_BUILD_NUM
The push refers to a repository [docker.io/reactioncommerce/base] (len: 1)

unauthorized: authentication required
Frank Gutierrez
@dearfrankg
Oct 20 2016 20:09
quiet day
Aaron Judd
@aaronjudd
Oct 20 2016 20:15
@dearfrankg are you trying to run that on your own CI account? You’ll need to provide the authentication as env variables in the CircleCI setup
DOCKER_EMAIL, DOCKER_PASS, DOCKER_USER
Frank Gutierrez
@dearfrankg
Oct 20 2016 20:16
I have added my env vars but that won't work for your repo I guess.
I'm wondering how I can use CI docs are not 100% clear
at the moment everything works except the dockerHub authentication
Aaron Judd
@aaronjudd
Oct 20 2016 20:18
well, the CI is configured for our repo, and pushed images to our docker org. if you’re running the CI from your own fork, I’m assuming that providing your own credentials will allow you push to your own org
Frank Gutierrez
@dearfrankg
Oct 20 2016 20:18
so my credentials would not let me push to reactioncommerce/base:$CIRCLE_BUILD_NUM would it?
so I should edit the circle.yml to point to my repo
Aaron Judd
@aaronjudd
Oct 20 2016 20:19
I’m not actually sure if they take the org of the user into account there.. but I think you’re right, you’ll need to edit the yml
Frank Gutierrez
@dearfrankg
Oct 20 2016 20:20
ok, I'll give it a shot
Aaron Judd
@aaronjudd
Oct 20 2016 20:21
if that’s something we need to update often, we could use an env var in the script, so that it could be configured without editing the yml
Frank Gutierrez
@dearfrankg
Oct 20 2016 20:22
good idea
Aesop7
@Aesop7
Oct 20 2016 23:40
Hi everyone, we are still struggling to get the footer working in Reaction
How do you get the footer to render on both the index page and the product listing page of a shop?
Spencer Norman
@spencern
Oct 20 2016 23:44
We had to add the footer to the product’s register.js file
as well as the product list / tags register.js file
Ivanthadev
@ivanthemeh
Oct 20 2016 23:45
Hey guys I finally figured out how to get this working on ec2 with mupx with a custom nginx setup so you can have multiple sites per instance. Im having some issues now setting up the default admin and was wondering how to set the mongo db for using a remote db? Any help?
Spencer Norman
@spencern
Oct 20 2016 23:46
@ivanthemeh we use Compose.io for ours and just add the supplied connection string to the MONGO_URL env variable
reaction should provision the DB on the first run
or you can use something like mongorestore to push up an existing data dump
Ivanthadev
@ivanthemeh
Oct 20 2016 23:50
@spencern any idea why the default admin I'm setting in the settings.settings.json isnt getting made? Is it supposed to be created even if the default one is made on init?
Spencer Norman
@spencern
Oct 20 2016 23:52
that doesn’t apply to deployed instances AFAIK, we use ENV for that too
REACTION_USER=Name
REACTION_AUTH=Password
REACTION_EMAIL=email@address
definitely possible I’m wrong about the settings.json
but we use ENV and it works
also how we set our email url (we use https://postmarkapp.com/ and love it)
Ivanthadev
@ivanthemeh
Oct 20 2016 23:54
  "reaction": {
    "REACTION_USER": "ivanthemeh",
    "REACTION_AUTH": "password",
    "REACTION_EMAIL": "ivan@ivanthemeh.com"
  },
isnt working
Spencer Norman
@spencern
Oct 20 2016 23:54
yeah, try setting those as ENV variables rather than json obj
not sure why it doesn’t work, works for me in dev, but we use the ENV variables in production and staging
I’ve not used mupx so can’t be super helpful on exactly how to do that, but that link looks promising
Ivanthadev
@ivanthemeh
Oct 20 2016 23:56
cant I set it in the console too?
Spencer Norman
@spencern
Oct 20 2016 23:57
should be able to, not really sure how mupx works.
can definitely set it in console for local dev
i’ve got a standard one I set in my shell .rc file
hey, I gotta run, I’ll be back on later though