These are chat archives for reactioncommerce/reaction

24th
Oct 2016
Ivanthadev
@ivanthemeh
Oct 24 2016 00:35
Im using robomongo as well with no issues.
Donovan Adams - Hydrotik
@hydrotik
Oct 24 2016 00:54
Got RoboMongo working. Couldn't start it up when it is inside my Apps folder for some reason (I am due for a hardware upgrade this week!) Deleted the second store and now the about us static template is coming up :) MongoHub doesn't seem to work, but I'm liking RoboMongo
Brent Hoover
@zenweasel
Oct 24 2016 00:54
Yeah, I am really happy in with RoboMongo. The only thing missing is in-place editing
Donovan Adams - Hydrotik
@hydrotik
Oct 24 2016 04:18
If I wanted to start customizing the product detail, would I create a separate plugin? Or can that be done within the same plugin? Looking at the Registry for product detail simple, it seems it would need to be split off?
Also it seems the components in that plugin should be renamed jsx instead of js.
Brent Hoover
@zenweasel
Oct 24 2016 04:19
I asked that same question but was told that they are just Javascript
Donovan Adams - Hydrotik
@hydrotik
Oct 24 2016 04:20
no they are definitely jsx
I see render() methods in there:)
Brent Hoover
@zenweasel
Oct 24 2016 04:21
Right, but it’s still just Javascript. Either way, you’ll have to argue with @mikemurray about it
in terms of creating a plugin, if you want to make something that essentially replaces the product-variant plugin than I could see that making a lot of sense
Donovan Adams - Hydrotik
@hydrotik
Oct 24 2016 04:22
yeah for the sake of verbosity and IDE highlighting, they should be jsx.
Brent Hoover
@zenweasel
Oct 24 2016 04:22
I made the same argument and was shot down
Donovan Adams - Hydrotik
@hydrotik
Oct 24 2016 04:25
what was the reason for not renaming it jsx?
Brent Hoover
@zenweasel
Oct 24 2016 04:25
that it’s just Javascript
mike [2:28 PM]
its all just javascript, and technically react components can created without JSX ¯_(ツ)_/¯"
Donovan Adams - Hydrotik
@hydrotik
Oct 24 2016 04:26
but it's not, there is jsx markup in it. Sorry, just not in agreement with that argument myself haha
Brent Hoover
@zenweasel
Oct 24 2016 04:27
not my call
Donovan Adams - Hydrotik
@hydrotik
Oct 24 2016 04:27
i wonder if eslint would also argue against that.
Brent Hoover
@zenweasel
Oct 24 2016 04:27
it does not
You cannot contribute code to our codebase with ESLINT errors
I had to make a slight adjustment to my IDE and it was happy as well
Donovan Adams - Hydrotik
@hydrotik
Oct 24 2016 04:33
Was just looking at .eslintrc
"react/jsx-filename-extension": [1, { "extensions": [".jsx"] }], would change that haha I guess I am used to seeing it be named jsx just to distinguish it from non jsx code, but it is a subjective thing. First time I've come across this ;) I'm going to take a look at some other project eslintrc files. Part of me thinks that is in there
Brent Hoover
@zenweasel
Oct 24 2016 04:38
honestly I haven’t done enough React to have an informed opinion
Donovan Adams - Hydrotik
@hydrotik
Oct 24 2016 04:42
At work, we use .jsx, .es6 Helps to recognize code content when dealing with legacy code. Also use .tsx when doing React in Typescript. I would feel confident saying that is standard. Anyways, my 2 cents.
Ok off to bed, work tomorrow. Take care Brent!
Brent Hoover
@zenweasel
Oct 24 2016 04:42
:+1:
samgitre
@samgitre
Oct 24 2016 07:30
Hello, Help please, I'm getting confuse with the differences between coreWorkFlow and coreProdutorksFlow in reaction commerce
Brent Hoover
@zenweasel
Oct 24 2016 07:31
there are many workflows defined in Reaction Commerce. The coreWorkflow is just the default workflow (it only has one step). The coreProductsWorksflow is the workflow around products
samgitre
@samgitre
Oct 24 2016 08:33
I see, thanks!
Luís Fernandes
@saguas
Oct 24 2016 08:49
Can any one help me to setup a google login or any other service (twitter, github or facebook)?Please!!!
James Scaggs
@jamesscaggs
Oct 24 2016 11:28
It doesn't look like there is an existing integration for Google Analytics Enhanced Ecommerce tracking feature. Is that correct?
James Scaggs
@jamesscaggs
Oct 24 2016 11:46
or does anyone know if the segment.io integration supports enhanced ecommerce on Reaction?
Donovan Adams - Hydrotik
@hydrotik
Oct 24 2016 15:20
Sorry, I had too :P reactioncommerce/reaction#1520
James Scaggs
@jamesscaggs
Oct 24 2016 16:03
@zenweasel Can you answer some questions about the analytics enhanced ecommerce/segment integration?
Spencer Norman
@spencern
Oct 24 2016 17:53
@jamesscaggs we are using the segment.io integration, but we added our own events for tacking enhanced ecommerce via Google Analytics.
Spencer Norman
@spencern
Oct 24 2016 20:34
@jshimko - nice work on the new circle.yml - builds way faster for non-deployed builds.
Brent Hoover
@zenweasel
Oct 24 2016 22:02
@jamesscaggs To be honest, I haven’t really explored the analytics much. What are your questions?
Donovan Adams - Hydrotik
@hydrotik
Oct 24 2016 23:47
Anyone help explain how to switch to product detail simple?
James Scaggs
@jamesscaggs
Oct 24 2016 23:52
@spencern does the segment integration provide standard eCommerce tracking? I am only seeing event categories such as accounts, grid, etc but nothing related to ecom.
Spencer Norman
@spencern
Oct 24 2016 23:52
not that I’m aware of
we added all funnel tracking on our own
James Scaggs
@jamesscaggs
Oct 24 2016 23:53
So you created custom events for add to Cart, checkout, and standard rev tracking?
Spencer Norman
@spencern
Oct 24 2016 23:54
correct
James Scaggs
@jamesscaggs
Oct 24 2016 23:54
Are you using tag manager or just analytics.js directly?
Spencer Norman
@spencern
Oct 24 2016 23:56
we’re using analytics.js directly
e.g. in the orderCompleted helper in completed.js we’ve got something like this:
analytics.track("Completed Order", getOrderTrackingProps(order));
wasn’t too difficult and we’re tracking FB pixel, AdWords, and GA Enhanced Ecomm all through the segment integration
James Scaggs
@jamesscaggs
Oct 24 2016 23:59
Ok, I'm currently using GTM so I was planning to push to the dataLayer but your method may be simpler for reaction