These are chat archives for reactioncommerce/reaction

7th
Dec 2016
Lorenzo Campanis
@lcampanis
Dec 07 2016 19:09
@aaronjudd Marketplace module updates pushed for today. Won't push anything else until we get some feedback on the review we've started.
Focusing on GoShippo integration which is going well see comments from @prosf , and Cart and Payment flows with Marketplace enabled
Aaron Judd
@aaronjudd
Dec 07 2016 21:03
@lcampanis :thumbsup: I’ll review later today and get feedback.
Brent Hoover
@zenweasel
Dec 07 2016 21:28
@lcampanis I wonder if that PR shouldn’t be made against the release-0.18.0 branch instead of development
Lorenzo Campanis
@lcampanis
Dec 07 2016 21:31
merged release 0.18 today to sort out some conflicts. Happy to change it, as I thought release 18 was based on development, not the case from the look of it. How come release 18 is so different from development?
Brent Hoover
@zenweasel
Dec 07 2016 21:31
release-18 is ahead of development because that’s where we merge in all PR’s with the features that are slated for this release
the idea being that we normally just merge in bug-fixes into development during the when we are working on a release cycle
the idea that if anything is tragically broken, we keep it out of development
Lorenzo Campanis
@lcampanis
Dec 07 2016 21:34
Got it. PR updated for you, and I'll keep that in mind
Brent Hoover
@zenweasel
Dec 07 2016 21:35
man, so glad GH finally added that feature