These are chat archives for reactioncommerce/reaction

13th
Dec 2016
Tran Duc Trong
@trongtd_twitter
Dec 13 2016 06:28
hi guys, any one did success deploy reaction to AWS Eslatic beanstalk ?
Owen Hoskins
@owenhoskins
Dec 13 2016 19:55
@jshimko Hey Jermey, awhile back with docker I added imagmagick via install-deps.sh, but following that same pattern with Reaction v0.17 doesn't seem to work as it did. Has anything changed in how the install-deps script is handled? reactioncommerce/reaction#1301
Jeremy Shimko
@jshimko
Dec 13 2016 20:02
have you tried building with the build script?
.reaction/docker/build.sh
Owen Hoskins
@owenhoskins
Dec 13 2016 20:03
Nope, always docker build
Jeremy Shimko
@jshimko
Dec 13 2016 20:03
There’s a base image now. If you just run docker build it will pull the base image from Docker Hub instead of building a new local one
Owen Hoskins
@owenhoskins
Dec 13 2016 20:03
I see..!!
Owen Hoskins
@owenhoskins
Dec 13 2016 20:11
running .reaction/docker/build.sh now. Does it create a local image?
Owen Hoskins
@owenhoskins
Dec 13 2016 20:33
@jshimko Ok, now I have reactioncommerce/reaction latest 50a96a28ace1 4 seconds ago 1.123 GB when running docker images. Is it as simple as add it to the Docker file like FROM reactioncommerce/reaction?
Owen Hoskins
@owenhoskins
Dec 13 2016 20:38
Yes... it looks to be that simple. @jshimko Thanks!
Spencer Norman
@spencern
Dec 13 2016 22:34

Anyone seen this issue before?

Cannot find module 'react-addons-shallow-compare

getting this trying to load our app on our staging server. Everything worked fine on local before deploy. Seems like it’s stemming from TacoTable - react-taco-table.lib.TacoTable.js

Causing our app to fail to load on client
running npm list on local reveals that it’s installed locally at least
├─┬ react-color@2.5.0
│ ├── material-colors@1.2.0
│ ├── react-addons-shallow-compare@15.4.0
│ ├─┬ reactcss@1.1.0
│ │ └── merge@1.2.0
│ └── tinycolor2@1.4.1
Erik Kieckhafer
@kieckhafer
Dec 13 2016 22:36
Haven’t come across that issue before. TacoTable is only used to display the results in the search modal. did you have our default search modal working before this?
Spencer Norman
@spencern
Dec 13 2016 22:37
we’re not using it, but I think it is installed
Mike Murray
@mikemurray
Dec 13 2016 22:38
maybe something is in devDependencies vs dependencies
Erik Kieckhafer
@kieckhafer
Dec 13 2016 22:39
i’m not even seeing react-addons-shallow-compare in my npm list
what version of taco-table is installed?
Spencer Norman
@spencern
Dec 13 2016 22:39
@mikemurray that’s what I thought at first as well
according to our package.json - "react-taco-table": "^0.4.1",
and it’s in the regular dependencies list
Erik Kieckhafer
@kieckhafer
Dec 13 2016 22:40
can you try making that 0.5.0
that’s what’s running on my install
Spencer Norman
@spencern
Dec 13 2016 22:40
sure
looks like that may be it
Erik Kieckhafer
@kieckhafer
Dec 13 2016 22:42
wondering if they removed it from 0.5.0 since it was causing issues
Spencer Norman
@spencern
Dec 13 2016 22:42
well, let’s see, doesn’t look like taco-table depends on d3 color
which is where the issue was coming from I think
but react-color is still in my list
what version of react-color do you have?
I’m at "react-color": "^2.3.2”,
and it’s also depending on shallow-compare
Erik Kieckhafer
@kieckhafer
Dec 13 2016 22:44
i’m at 2.1.0 for react color
Spencer Norman
@spencern
Dec 13 2016 22:44
hmm
Erik Kieckhafer
@kieckhafer
Dec 13 2016 22:44
├─┬ react-taco-table@0.5.0
│ ├── d3-format@1.0.2
│ ├─┬ d3-scale@1.0.4
│ │ ├── d3-array@1.0.2
│ │ ├── d3-collection@1.0.2
│ │ ├── d3-color@1.0.2
│ │ ├── d3-interpolate@1.1.2
│ │ ├── d3-time@1.0.4
│ │ └── d3-time-format@2.0.3
│ ├── d3-scale-chromatic@1.1.0
│ ├── lodash.curry@4.1.1
│ └── stable@0.1.5
and there is my taco-table tree
Spencer Norman
@spencern
Dec 13 2016 22:46
well, I’ll try this and see if it deploys
Erik Kieckhafer
@kieckhafer
Dec 13 2016 22:46
  "dependencies": {
    "classnames": "^2.2.5",
    "d3-format": "^1.0.0",
    "d3-scale": "^1.0.0",
    "d3-scale-chromatic": "^1.0.0",
    "lodash.curry": "^4.0.1",
    "stable": "^0.1.5"
  },
Spencer Norman
@spencern
Dec 13 2016 22:46
I’m still trying to figure out where the dependency on shallow compare is coming from
because it’s still in my tree, but not required by taco-table
Brent Hoover
@zenweasel
Dec 13 2016 22:47
I feel like that was an old dependency of an earlier version of revisions
Spencer Norman
@spencern
Dec 13 2016 22:47
yeah, looks like it’s no longer used at all
Erik Kieckhafer
@kieckhafer
Dec 13 2016 22:47
i don’t see it at all in my list
Spencer Norman
@spencern
Dec 13 2016 22:47
required by react-color
which isn’t used in the project
Erik Kieckhafer
@kieckhafer
Dec 13 2016 22:48
react-color i think was used in a color picker that we were testing out in the theme editor
i don’t think it’s used anymore so it should be safe to remove
Spencer Norman
@spencern
Dec 13 2016 22:51
:+1: Will do
Spencer Norman
@spencern
Dec 13 2016 23:49
@kieckhafer @mikemurray thanks for the help, removing react-color has brought our site back online
Erik Kieckhafer
@kieckhafer
Dec 13 2016 23:50
np, good to hear!