These are chat archives for reactioncommerce/reaction

6th
Oct 2017
machiko
@machikoyasuda
Oct 06 2017 00:31
Anyone out there using git submodules? How do you commit your submodule changes to the main /reaction/ repository?
Josh Cox
@joshuacox
Oct 06 2017 01:00
@machikoyasuda cd imports/plugins/custom && git submodule add -f -b openbusinessbox https://github.com/OpenBusinessBox/reaction-openbusinessbox-theme.git
is how I usually do it, that will clone that repo on that branch (-b), and add it to your git submodules
then git commit -am 'My Module Added'
Josh Cox
@joshuacox
Oct 06 2017 01:08
you need the -f flag to force it to ignore the .gitignore file
machiko
@machikoyasuda
Oct 06 2017 01:09
@joshuacox awesome. i've been using -f too, here: https://github.com/machikoyasuda/reaction-beesknees-plugin
do you then add a commit to /openbusinessbox/ to track changes in the main repo's .gitmodules and the submodule directory?
Josh Cox
@joshuacox
Oct 06 2017 01:16
at that point as a submodule the reaction repo will track your repo by commit
so the commit of reaction-beesknees-plugin at the time you make a commit on reaction will be committed along with everything else
and, yes, you need to make commits still to reaction-beesknees-plugin, and it should all be committed and tidy before making commits to the 'outer' reaction repo
machiko
@machikoyasuda
Oct 06 2017 01:19
makes sense
thank you so much @joshuacox
!
Josh Cox
@joshuacox
Oct 06 2017 01:19
anytime!
Wemperer
@Wemperer
Oct 06 2017 01:22
I'm having issues with installing
After i get a 'failed to install' npm packages because they already exist
Josh Cox
@joshuacox
Oct 06 2017 01:23
are you calling npm directly or through meteor npm i
Wemperer
@Wemperer
Oct 06 2017 01:23
then it just stalls. poor 3000 is locked while its stalled but going to localhost://3000 doesn't display anything
npm directly
Josh Cox
@joshuacox
Oct 06 2017 01:24
do not use npm directly with reaction
Wemperer
@Wemperer
Oct 06 2017 01:25
That's not specified in the installation guide...
Josh Cox
@joshuacox
Oct 06 2017 01:26
well, you don't need it for the install if you mean npm i -g reaction-cli
and reaction init calls meteor npm i or equivalent on it's own
Wemperer
@Wemperer
Oct 06 2017 01:27
ah well in that case that isn't my problem
I did the initial steps up to reaction run
settings up plugins/styles, starts the proxy
Josh Cox
@joshuacox
Oct 06 2017 01:28
what platform are you on?
Wemperer
@Wemperer
Oct 06 2017 01:28
windows
Josh Cox
@joshuacox
Oct 06 2017 01:28
can you paste a gist or similar to the error?
Wemperer
@Wemperer
Oct 06 2017 01:29
unable to resolve 'env' 'react' 'stage-2' 'lodash' 'module-resolver'
=> Started proxy.
Warning: unable to resolve "env" in presets of /C/Users/Kevin/Documents/Projects/reaction/package.json
Warning: unable to resolve "react" in presets of /C/Users/Kevin/Documents/Projects/reaction/package.json
Warning: unable to resolve "stage-2" in presets of /C/Users/Kevin/Documents/Projects/reaction/package.json
Warning: unable to resolve "lodash" in plugins of /C/Users/Kevin/Documents/Projects/reaction/package.json
Warning: unable to resolve "module-resolver" in plugins of /C/Users/Kevin/Documents/Projects/reaction/package.json
Josh Cox
@joshuacox
Oct 06 2017 01:29
try meteor npm i and paste the results to that
Wemperer
@Wemperer
Oct 06 2017 01:30
bunch of errors
and i don't tink pasting these will help
npm WARN addRemoteGit Error: Command failed: git -c core.longpaths=true config --get remote.origin.url
npm ERR! Command failed: git -c core.longpaths=true clone --template=C:\Users\
Josh Cox
@joshuacox
Oct 06 2017 01:33
most likely you are missing some things in your path that npm and friends are expecting, my suggestion is always install virtualbox and use a VM, but personally I installed npm through cygwin, how did you install npm and what version is it?
Wemperer
@Wemperer
Oct 06 2017 01:33
5.4.2 and i installed it... shoot i don't remember
Josh Cox
@joshuacox
Oct 06 2017 01:33
I'm also not on windows at the moment I try not to boot that OS if at all possible
Wemperer
@Wemperer
Oct 06 2017 01:34
maybe through composer?
or directly from the website with an installer? Dont remember
it is horrible... i have had windows specific issues with everything I try to install for development
Josh Cox
@joshuacox
Oct 06 2017 01:35
so VM, cygwin, or do you want to debug your current npm?
Wemperer
@Wemperer
Oct 06 2017 01:35
I'll try loading an ubuntu vm
Josh Cox
@joshuacox
Oct 06 2017 01:35
that is the best route imho
Wemperer
@Wemperer
Oct 06 2017 01:36
God I hope this platform is better than opencart
Josh Cox
@joshuacox
Oct 06 2017 01:38
well opencart is a different sort of a beast, but I believe this is one of the top e-commerce platforms to watch, it is far younger than opencart and most of its competitors, but it shows astounding promise
Wemperer
@Wemperer
Oct 06 2017 01:39
I hope it is successful with all that beautiful javascript.
Santiago Botta
@sgobotta
Oct 06 2017 14:36
Morning everyone!
Is there a way to bypass the default data load from private/data ? I've been trying to execute my own import module using different kind of event hooks. Looks like the default data is triggered even before the "onCoreInit" hook. This is a problem for me since I don't want to load data from private/data/Shops, I rather want to use data from my own plugin instead of modifying anything in the core code.
Btw, this env variable seems to be deprecated: SKIP_FIXTURES. Am I missing something?
machiko
@machikoyasuda
Oct 06 2017 15:44
@sgobotta Hi Santiago - There is a way to skip loading private data. And SKIP_FIXTURES is the way to do it. You can export the SKIP_FIXTURE variable as false https://github.com/reactioncommerce/reaction-docs/blob/master/developer/configuration.md#overwrite-sample-data
$ export SKIP_FIXTURES=true $ reaction
@sgobotta The SKIP_FIXTURES environmental variable is new and is the latest release release-1.5.0. Checking the previous releases now.
machiko
@machikoyasuda
Oct 06 2017 15:50
@sgobotta Ah - If you're working on Reaction 1.4.0, you won't have the SKIP_FIXTURES variables yet. It's in Reaction starting https://github.com/reactioncommerce/reaction/releases/tag/v1.5.0-rc.0
Santiago Botta
@sgobotta
Oct 06 2017 15:56
Alright, I'm currently in 1.4.2. I'll try it out and come back with feedback
Yeah, you were right. There's no SKIP_FIXTURES conditional in load-data module on v1.4.2. It should do the trick until I move to 1.5.0
Thank you.
machiko
@machikoyasuda
Oct 06 2017 16:02
@sgobotta awesome!
Dan Castellon
@dancastellon
Oct 06 2017 18:22
Hi! I've been working with Reaction for a few months on a client project. Today I've been tasked with updating a few versions to 1.4. The first error I'm seeing is "No such template: tagNav". It looks like a blaze template's been converted to React. What's the upgrade path here?
Dan Castellon
@dancastellon
Oct 06 2017 18:35
I've got about 10 core Blaze templates that I've overridden in a custom plugin. I wonder if this is as easy as finding the matching React compoment?
machiko
@machikoyasuda
Oct 06 2017 21:10
@dancastellon Ideally yes it should be.
There are some components that haven't been converted into Blaze. But we're getting to that.
Our version 1.5 is slated to come out next week too. Going from 1.4 to 1.5 should be too hard!