These are chat archives for reactioncommerce/reaction

12th
Oct 2017
Spencer Norman
@spencern
Oct 12 2017 00:15
We’ve officially released Reaction version 1.5.0!
Check out the release notes here: https://github.com/reactioncommerce/reaction/releases/tag/v1.5.0
Brent Hoover
@zenweasel
Oct 12 2017 00:18
:tada:
Dan Kozlowski
@dankoz51
Oct 12 2017 11:27
@machikoyasuda Thanks, but how do you load it, i tried putting it in the private/data directory but then reaction reset .. but it wont start that way, lots of key errors.
Gabriel L. Maljkovich
@glmaljkovich
Oct 12 2017 18:08
Is there any simpler way route a path to a React Component than the one proposed in https://blog.reactioncommerce.com/an-intro-to-architecture-the-registry/ ?
I just want to map one route to one React component, skipping Blaze at all. The way the registry works seems to only look for Blaze templates, any other file where I can define my routes?
Joey
@JoeyLyman
Oct 12 2017 18:20
@spencern hey I've been trying v1.5.0 and it isn't working well for me, not sure if I'm doing something wrong. A lot of the interactivity doesn't work; I did a little screencast and put it on youtube if you get the chance to check it out I'd really appreciate it. Thanks https://www.youtube.com/watch?v=Mnpim-5M7Go&t=4s
Spencer Norman
@spencern
Oct 12 2017 18:22
Hi @JoeyLyman thanks for recording a screencast, that’s very helpful. Can you give a little more background on the setup to this point?
E.g. single shop vs multiple shops any specific settings, OS?
Joey
@JoeyLyman
Oct 12 2017 18:23
no setup, just a fresh reaction init in a new local directory
Spencer Norman
@spencern
Oct 12 2017 18:23
any client or server errors or warnings?
Spencer Norman
@spencern
Oct 12 2017 18:30
the Mail not configured error shouldn’t cause problems other than not sending email.
The Error: you’ve been logged out by the server is usually caused by starting a new server on the same port or reaction reseting while you’ve got connected clients. Neither of those issues should cause what I’m seeing in your video though
I just got my computer back from repairs and it got wiped, so I’ll be testing a full setup on a completly fresh computer here in just a minute
We tested 1.5.0 fairly extensively and I’ve not seen any issues like what you’re seeing here.
How would you describe the issues? Lack of responsiveness? products not updating reactively? Navigation issues?
Joey
@JoeyLyman
Oct 12 2017 18:36
super, thanks lots and yeah apologies for not responding on a github issue a week ago my computer was gone for repairs for a week as well. and yeah, I would describe it as lack of responsiveness; somethings work when I click on them and some don't, and some will update to my interaction only after i refresh the page. some things wont react at all though. kind of all of the things you mentioned: Lack of responsiveness, products not updating reactively, Navigation issues
Spencer Norman
@spencern
Oct 12 2017 18:36
did you have any settings in either settings/dev.settings.json, settings/settings.json, or private/settings/reaction.json?
Joey
@JoeyLyman
Oct 12 2017 18:38
no settings in settings/dev.settings.json:
{
"ROOT_URL": "",
"MAIL_URL": "",
"reaction": {
"REACTION_USER": "",
"REACTION_AUTH": "",
"REACTION_EMAIL": ""
},
"REACTION_LOG_LEVEL": "info",
"public": {}
}
Spencer Norman
@spencern
Oct 12 2017 18:38
:+1:
Joey
@JoeyLyman
Oct 12 2017 18:38
and dont have either of the other files
i gotta step out for an hour or two but ill be back this afternoon. thanks again
Spencer Norman
@spencern
Oct 12 2017 18:52
ok, just ran through a brand new setup with no config files or anything else and was not able to reproduce what you’re seeing. Possible I’m not understanding the steps to reproduce and also possible that it’s something specific to your setup.
Best way to help me help you would be to get a clean reproduction of something specific (e.g. not navigating to the product page when clicking the “add product” button from the index page) and figure out the exact steps to reproduce it.
Unfortunately it’s super hard to debug something I can’t reproduce on my machine, even if your video provides a good example.
CF
@ChenfengLiu
Oct 12 2017 19:38

Hi reaction, i'm working on a plugin in /imports/plugins/custom/my-plugin and I'm trying to import the CSS and font from 'react-slick' into /my-plugin/styles/layout.less. The example they provided shows

@import "~slick-carousel/slick/slick.css";
@import "~slick-carousel/slick/slick-theme.css";

And I have tried

@import "{}/node_modules/slick-carousel/slick/slick.css";
@import "{}/node_modules/slick-carousel/slick/slick-theme.css";

Both didn't work. I'm wondering what is the right path to import css settings?

rhaix
@rhaix
Oct 12 2017 19:43
@spencern Have you guys tested plugin backwards compatibility with v1.5?
Spencer Norman
@spencern
Oct 12 2017 19:50
we’ve tested with all included and core plugins. We have not tested with any third-party plugins
rhaix
@rhaix
Oct 12 2017 19:52
have you tested with the bees knees example plugin by any chance? I'm trying to figure out why my layout plugins are not working on v1.5 and I based them on that example
Spencer Norman
@spencern
Oct 12 2017 20:00

@machikoyasuda has been testing with our tutorials and we’ve got some new tutorials in the works.

We did update the registry property provides to accept an array of strings. Are you passing a string to provides?

Spencer Norman
@spencern
Oct 12 2017 20:07
reactioncommerce/reaction#2930
machiko
@machikoyasuda
Oct 12 2017 20:51
@ChenfengLiu Have you tried @import "slick-carousels/slick/slick.css"? Try looking at the default-theme plugin as an example
CF
@ChenfengLiu
Oct 12 2017 21:59
@machikoyasuda Thank you! I made a dumb mistake... fixed it by changing "slick.css" to "slick.less"... No sure if this is the right way though.
machiko
@machikoyasuda
Oct 12 2017 23:46
@ChenfengLiu Awesome. Did you try @import "~slick-carousel/slick/slick.less";or @import "{}/node_modules/slick-carousel/slick/slick.less";?