These are chat archives for reactioncommerce/reaction

18th
Oct 2017
Brent Hoover
@zenweasel
Oct 18 2017 05:17
@joshuacox Re: Ubuntu file rights. Yes, I think you are correct. If you sudo apt-get install node you are going to get system permissions and will probably run into issues. I haven’t had time to test this and what the solution is yet.
Maybe the reaction-cli needs to be smarter about where it places the executable
Damien
@damien-ls
Oct 18 2017 05:23
Hi guys, we are looking for a new solution for our e-commerce website and where wondering if reaction integrates customer support with tickets ?
Brent Hoover
@zenweasel
Oct 18 2017 05:24
We don’t have any built in support for it now, but I am sure it wouldn’t be to hard to write an integration
Damien
@damien-ls
Oct 18 2017 05:33
what is the men-hour you would estimate for this ?
machiko
@machikoyasuda
Oct 18 2017 13:57
Hi all - the Reaction Community Call is about to start: http://getrxn.io/reaction-community-call
prosf
@prosf
Oct 18 2017 15:41
Has "Reaction Community Call" already started ,cause I get a "Please wait for the host to start this webinar." on my (linux) Zoom client?
Nick Baldwin
@nbaldwin
Oct 18 2017 16:24
Has anyone had the need to add variant properties that are optional? Running into issues with it because Revisions only store a copy of the new properties, so the unset just removes the property to be merged. It doesn't have the concept of unsetting the field when the revision is published.
For now I added a new key in Revision that contains fieldsToUnset and adds it to the Variant update as part of Revision publish but I want to make sure there's not a cleaner way.
Nick Baldwin
@nbaldwin
Oct 18 2017 16:41
Also: Are there any plans for using getSchemas when importing schemas within core? For example, this line pulls in the stock ProductVariant schema for validating the Variant, where if it used the registered schema could instantly support validating any additional fields you registered without a core mod. https://github.com/reactioncommerce/reaction/blob/master/imports/plugins/included/product-variant/containers/variantFormContainer.js#L24
I guess that one's not as big of a deal since you're probably registering your own container anyway which would override that, just a thought.
machiko
@machikoyasuda
Oct 18 2017 17:47
@josx We talked about your question at the Community call today. https://docs.google.com/document/d/1PwenrammgQJpQfFoUUJZ96i_JJYCM_4glAjB1_ZzgwA/edit In short.. our best recommendation would be to try to find a NPM plugin that achieves the same thing as that Meteor Atmosphere package. Meteor is moving away from Atmosphere and we're doing the same.
@josx I'll let you know as soon as the Community Call archive video is up. You can hear a longer explanation there.
@shahid05688708_twitter Hey there - Are you running the latest version of Reaction 1.5.1? or 1.5? We deprecated the /reaction/ prefix so you shouldn't be seeing that anymore. We discussed this in the Community call today if you want to hear more: https://docs.google.com/document/d/1PwenrammgQJpQfFoUUJZ96i_JJYCM_4glAjB1_ZzgwA/edit
Gowrav L
@gowrav
Oct 18 2017 17:49
How to make Reaction Hyperlocal ?
Sophie He
@sophiehe
Oct 18 2017 18:45

Just a reminder that our Hackabugathon is underway, so if you submit a pull request, you'll receive free swag. Here's a great pull request to check out: github.com/reactioncommerce/reaction/#2769

More on our Hackabugathon here: https://blog.reactioncommerce.com/introducing-the-reaction-hack-a-bug-a-thon/

José Luis Di Biase
@josx
Oct 18 2017 21:06
@machikoyasuda thanks a lot, i will be waiting for that video...
Brent Hoover
@zenweasel
Oct 18 2017 22:09
@nbaldwin I don’t know the exact syntax we will end up using but it is 100% in our plan to provide an API to modify the core schemas from a plugin
We’ve been working towards that when we move to node-simple-schema
Spencer Norman
@spencern
Oct 18 2017 22:12
There’s a branch that I’ve started to move towards node-simple-schema, but there’s still a bit of work to do on it as well. https://github.com/reactioncommerce/reaction/tree/spencer-node-simple-schema-update-schemas
Brent Hoover
@zenweasel
Oct 18 2017 22:12
it always seems like it will be a quick move, but there’s a couple of thorny issues to be worked out
for like 90% of it you can just literally replace meteor-simple-schema with node-simple-schema
Spencer Norman
@spencern
Oct 18 2017 22:30
That branch has actually already replaced all the schemas, but theres a little bit more to it than that
Brent Hoover
@zenweasel
Oct 18 2017 22:31
Yeah, I think somebody just needs to spend a few dedicated days on it and understand the changes
Nick Baldwin
@nbaldwin
Oct 18 2017 22:32
@zenweasel cool, good to hear. any advice about my other question RE: variants with optional inputs?
Brent Hoover
@zenweasel
Oct 18 2017 22:33
@nbaldwin Honestly I didn’t completely understand the question. What do you mean by “optional inputs”?
Nick Baldwin
@nbaldwin
Oct 18 2017 22:34
My variant has some fields that were added that are not required. If none is present, they pull from a template.
There's no way currently to "blank out" a variant field
Because when you make the change, it gets copied over to the Revision as unset field in the Revision data
It doesn't copy over the concept of unsetting the field when the Revision gets applied to the variant
Brent Hoover
@zenweasel
Oct 18 2017 22:35
So you mean you can’t have fields that don’t have a value?
Nick Baldwin
@nbaldwin
Oct 18 2017 22:35
Right, because it gets lost from Revision -> Variant
the unset just does unset on Revision data, so when the Revision is published it just doesn't have that key anymore in the data
so the update command sent to Mongo just leaves the existing key you are trying to remove
Brent Hoover
@zenweasel
Oct 18 2017 22:36
when you say “make the change” you mean manually through the UI?
Nick Baldwin
@nbaldwin
Oct 18 2017 22:37
Making the change via VariantForm in the UI yes
It will appear blank until you hit publish revision, then the old value will reappear, since it didnt unset from the variant
Brent Hoover
@zenweasel
Oct 18 2017 22:39
sorry to be dense but I am not clear on why you are setting it to blank manually in the UI
Nick Baldwin
@nbaldwin
Oct 18 2017 22:40
Like the manufacturer field
Once you set it, you cannot unset it
Brent Hoover
@zenweasel
Oct 18 2017 22:41
Ah I got it
Sounds like a bug
Nick Baldwin
@nbaldwin
Oct 18 2017 22:42
The unset makes it to revision, but the revision swallows it up when it builds the "revision data"
my workaround is currently to keep track of fields that are blanked out, and add them to the $unset in the Product.update call within Revision publish
felt sorta hacky though
Brent Hoover
@zenweasel
Oct 18 2017 22:43
Yeah, I feel like that’s a bug. Would you mind creating an issue for it?
Nick Baldwin
@nbaldwin
Oct 18 2017 22:43
Sure
Brent Hoover
@zenweasel
Oct 18 2017 22:43
Thanks. Then we can have somebody look at it.
Nick Baldwin
@nbaldwin
Oct 18 2017 22:43
I'll link my workaround as it makes it very obvious what's going on and can be used as a starting point for a cleaner fix