These are chat archives for reactioncommerce/reaction

23rd
Dec 2017
Tse
@tse2909
Dec 23 2017 01:51
@zenweasel how to add banner to to homepage ? is there any way to add media to reaction ? or i have to add it manually to public/custom ?
Brent Hoover
@zenweasel
Dec 23 2017 01:54
You can add a banner at top by just overriding the Navbar component
@ghegoiu1 If you want to just change the home page you can do that throough INDEX_OPTIONS
Tse
@tse2909
Dec 23 2017 01:56
how about the image ? how to add media to reaction ?
Brent Hoover
@zenweasel
Dec 23 2017 01:57
Yes, you need to add media to public/custom for now
Tse
@tse2909
Dec 23 2017 02:00
i have problem with the product image display . it seems not to responsive . what is the best way to make it display better @zenweasel
Brent Hoover
@zenweasel
Dec 23 2017 02:01
Can you explain in a little more detail?
Tse
@tse2909
Dec 23 2017 02:02
image.png
the image seems not fit to container
Brent Hoover
@zenweasel
Dec 23 2017 02:03
well, you are using the layout there that is designed specifically for images that are wide
Tse
@tse2909
Dec 23 2017 02:07
image.png
how about this layout. when i uploaded images that have no padding at the edge . it seems to be cropped in when display in the grid
Brent Hoover
@zenweasel
Dec 23 2017 02:09
Yeah, we are doing that I believe to keep the sizes consistent. If you want different behavior you can just override the CSS
/all Note The Reaction offices are closed from 12/23 until 1/2 PST. While we will still be trying to respond to questions as best we can but you may experience some delays. Wishing you and your family Happy Holidays.
Tse
@tse2909
Dec 23 2017 02:20
thanks for your help n happy holidays
Brent Hoover
@zenweasel
Dec 23 2017 02:20
@tse2909 that wasn’t directed at you, just had to post a general announcement
Scott Betzel
@Snaze
Dec 23 2017 05:11
@joshuacox thanks... sorry, i had to step out earlier but that helps
Scott Betzel
@Snaze
Dec 23 2017 05:28
does anyone know how i can run and debug a specific app-test?
Brent Hoover
@zenweasel
Dec 23 2017 05:43
append only to any particular it or describe
e.g. it.only(“should do something excellent” will run only that test
Scott Betzel
@Snaze
Dec 23 2017 05:47
interesting... ok thanks... so i just modify the one test I want to run in the .js file and run reaction test?
i was curious if I could pass in the "app-test.js" filename to the "meteor test" command line?
Brent Hoover
@zenweasel
Dec 23 2017 05:48
yes, just temporarily modify the js file
Scott Betzel
@Snaze
Dec 23 2017 05:48
got it
Brent Hoover
@zenweasel
Dec 23 2017 05:49
I believe it will accept a GREP command as well, but I am not 100% sure that works
Scott Betzel
@Snaze
Dec 23 2017 05:49
ok thank you! i'm just ramping up with reaction and meteor so i feel super noobish
interesting... i feel like I did read that somewhere as well
regarding the grep
Brent Hoover
@zenweasel
Dec 23 2017 05:50
it’s a mocha thing, but not sure it gets passed in by the Meteor wrapper around mocha
I’m guessing no: practicalmeteor/meteor-mocha#64
Scott Betzel
@Snaze
Dec 23 2017 05:50
ok good to know
thank you sir
Brent Hoover
@zenweasel
Dec 23 2017 05:51
:+1:
Janus Reith
@janus-reith
Dec 23 2017 14:07

Still wonder what would be the best way to add static sites with a route atm.
I did it like described in the example, so I have a blaze template with some simple html, and a route in my register.js

However, the loading time is enourmous, e.g. when i place a link to that page in my footer.
The amount of data is minimal, like just some lines of simple html, so the transition to that page should happen immidiately.

Is there an alternative to this approach already?

Michael Jenny
@prinzdezibel
Dec 23 2017 15:36
@janus-reith That sounds like the whole app is reloaded completely. Not sure why that is. I'd expect the routing to be done client side. Can you tell the amount of data transfered in Chrome inspector during page transistion?
Janus Reith
@janus-reith
Dec 23 2017 15:52
Chrome Network inspection tells me that 1,7 MB are transferred, when I start recording as soon as the main page loaded, and iclick the link to one of my static pages
the only new content that is loaded should be ~5,5 kb of HTML
The inspector shows some resources that should be rendundant as they were loaded already, like fontawesome and analytics. the actual document for the page is also transfererd and is shown to take 10kb. But all of those things would still work out ok, if it wasn't for the additional 1.4 MB of meteor js bundle code that is loaded.
Michael Jenny
@prinzdezibel
Dec 23 2017 15:57
@janus-reith Definitely sounds like a page reload. We're entering a full quarter of focusing specifically on performance optimization. I think this should be also part of it and is worth investigations.
Janus Reith
@janus-reith
Dec 23 2017 16:01
yes, I have four static sub pages atm, just to comply with german ecommerce law, and e.g. pages like the legally required statement of the ownership and authorship(impressum/imprint) shouldn't have additional loading time
and yes, definitely a page reload, the loading spinner i implemented on the app entry document also shows up in the meantime
Patrick Newell
@pnewell4_twitter
Dec 23 2017 16:18
Any Marketplace experts here? I am confused about the visibility of products in various shops. I have three shops, the Primary shop and two marketplace shops. I recently logged into a marketplace shop as the shop owner and created a product. I was surprised to see it appear in all three shops, hoping that it would only appear in the MP shop in which it was created.
Follow up comment, I went to Archive a product (I really wanted delete, but Archive is fine). I clicked Archive, confirmed the action, didn't see any errors in the console (which I have seen when logged in as a user that did not have permission), but the product is still displayed. Any idea? Maybe because it was created in an MP shop? idk
bebob1
@bebob1
Dec 23 2017 16:46

import { Meteor} from "meteor/meteor";
import { Reaction } from "/server/api";

Meteor.startup(function () {
Reaction.Import.process(Assets.getText("private/custom/Shipping.json"), ["name"], Reaction.Import.shipping);
Reaction.Import.flush();
});

hi there, I have a question about the import of shipping data on reaction start
as described in the docs I am using Reaction.import method to import custom shipping records
I am using the Shipping.json from the default data with just some changes on the prices
but reaction throws this error on start: "Error: Unknown asset: private/custom/Shipping.json"
does anybody know why this import is not working?
Dhaivat Pandya
@Poincare
Dec 23 2017 21:07

I'm getting an error on trying to set up my reaction instance for the first time:

While processing files with ecmascript (for target web.browser):<anonymous>: Converting circular structure to JSON

Anyone know why this could be happening?