These are chat archives for reactioncommerce/reaction

24th
Jul 2018
rohit-elevar
@rohit-elevar
Jul 24 2018 08:23
Hi, I an new to Reaction commerce, and had a doubt.
Does Reaction Commerce come with Https support out of the box? Or is some additional work required to get that done.
Loan Laux
@loanlaux
Jul 24 2018 08:24
@rohit-elevar This is something you'd generally want to manage at the load-balancer level.
rohit-elevar
@rohit-elevar
Jul 24 2018 08:28
Ok. So It's something I have to setup myself, right?
Loan Laux
@loanlaux
Jul 24 2018 08:28
Correct. Either on your load-balancer or on a reverse proxy.
rohit-elevar
@rohit-elevar
Jul 24 2018 08:29
Ok! Thanks for the quick response!! @loanlaux
Loan Laux
@loanlaux
Jul 24 2018 10:06
Anybody running into this error on the latest 1.14?
Exception while invoking method 'login' Error: insert requires an argument
    at Collection.insert (packages/mongo/collection.js:452:13)
    at Collection.Mongo.Collection.(anonymous function) (packages/aldeed:collection2/collection2.js:213:19)
    at Collection.Mongo.Collection.(anonymous function) [as insert] (packages/dispatch_run-as-user.js:325:19)
    at AccountsServer.Ap.insertUserDoc (packages/accounts-base/accounts_server.js:1340:25)
    at MethodInvocation.Accounts.registerLoginHandler.options (imports/plugins/core/core/server/startup/accounts.js:62:29)
    at packages/accounts-base/accounts_server.js:483:32
    at tryLoginMethod (packages/accounts-base/accounts_server.js:259:14)
    at AccountsServer.Ap._runLoginHandlers (packages/accounts-base/accounts_server.js:480:18)
    at MethodInvocation.methods.login (packages/accounts-base/accounts_server.js:543:27)
    at currentArgumentChecker.withValue (packages/check/match.js:118:15)
    at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1189:12)
    at Object._failIfArgumentsAreNotAllChecked (packages/check/match.js:116:43)
    at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1764:18)
    at DDP._CurrentMethodInvocation.withValue (packages/ddp-server/livedata_server.js:719:19)
    at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1189:12)
    at DDPServer._CurrentWriteFence.withValue (packages/ddp-server/livedata_server.js:717:46)
    at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1189:12)
    at Promise (packages/ddp-server/livedata_server.js:715:46)
    at new Promise (<anonymous>)
    at Session.method (packages/ddp-server/livedata_server.js:689:23)
    at packages/ddp-server/livedata_server.js:559:43
Theo
@shierro
Jul 24 2018 11:00

Hi everyone! I have some unusual things I want to add on an existing RC instance

Unusual workflow

  • Buyer purchases items using standard cart/check-out process
  • At point of purchase, order is sent to a custom user(manager) for approval
  • Manager approves purchase, purchase is completed, CC is charged, order is submitted to all -
    suppliers

I'm kind of new to RC & am keen to know your thoughts on the flow above, are there potential show stoppers you think I will encounter on implementing it?

Loan Laux
@loanlaux
Jul 24 2018 11:30
This seems pretty simple to me using Reaction's hook library and a custom REST endpoint for the external system to notify of an order's approval, @shierro
Theo
@shierro
Jul 24 2018 12:17
@loanlaux thanks for the insight! for the approval part, it will be done inside RC as well(new user group - Manager/Approver) - no external system as much as possible. i'm thinking of mapping the order to the manager once the buyer places in all the items in the cart. would that make more sense? so the approval part is discard cart / proceed to payment
weput
@weput
Jul 24 2018 13:01

@zenweasel ask for panamanian geisha...

let me know how much they charged you.

Loan Laux
@loanlaux
Jul 24 2018 13:11
My bad @shierro, I thought you wanted to have orders linked to a CRM/ERP. That makes a lot of sense, yes. However, note that Reaction already has an order confirmation step built into the backoffice. How would yours differ?
Theo
@shierro
Jul 24 2018 15:16
ok i'll try the order confirmation step mate. on my case, the only diff is that a 2nd person/manager will do the order confirmation. So i think i need to pass the order to the manager & send notif to the person so he/she knows that there's an order that needs to be confirmed. thanks again @loanlaux
Loan Laux
@loanlaux
Jul 24 2018 15:17
If this is it, then it seems pretty easy to do with hooks. Small overhead for sure. Happy to help @shierro.
Patrick Newell
@pnewell4_twitter
Jul 24 2018 15:33
@loanlaux re: your login error, any chance you are on a custom domain? (other than localhost?)
Loan Laux
@loanlaux
Jul 24 2018 15:33
127.0.0.1, if that counts
Patrick Newell
@pnewell4_twitter
Jul 24 2018 15:33
it might
Loan Laux
@loanlaux
Jul 24 2018 15:33
Ah, testing with localhost then
Patrick Newell
@pnewell4_twitter
Jul 24 2018 15:34
try adding 127.0.0.1 to your shop's domains
Loan Laux
@loanlaux
Jul 24 2018 15:34
I have over 300 shops on this project though
Patrick Newell
@pnewell4_twitter
Jul 24 2018 15:34
  1. that's amazing!
Loan Laux
@loanlaux
Jul 24 2018 15:35
I mean it's just a matter of writing the right MongoDB query, so it doesn't really matter
Patrick Newell
@pnewell4_twitter
Jul 24 2018 15:35
  1. ok, we'll figure that out once we verify this is the issue
(that was supposed to be a 2!)
Loan Laux
@loanlaux
Jul 24 2018 15:35
I got that, haha
That was indeed the problem
Patrick Newell
@pnewell4_twitter
Jul 24 2018 16:29
great!
Loan Laux
@loanlaux
Jul 24 2018 16:29
But I'm wondering... Shouldn't the primary shop pop up regardless of the domain that's used?
Patrick Newell
@pnewell4_twitter
Jul 24 2018 16:30
this is probably only a one-time, or development environment issue, but the resolution would be to default to the Primary Shop, which we do not currently do
Loan Laux
@loanlaux
Jul 24 2018 16:30
Should I file an issue for this?
Patrick Newell
@pnewell4_twitter
Jul 24 2018 16:30
in my recent PR, I didn't want to muddy the water any further by adding this feature, but it is a very simple fix:

add

if (!shopId) {
  shopId = this.getPrimaryShopId();
}

on line 386

please do!
Loan Laux
@loanlaux
Jul 24 2018 16:31
Thank you very much, will do!
Patrick Newell
@pnewell4_twitter
Jul 24 2018 16:32
while we're at it, we may want to cache/memoize getPrimaryShop
Loan Laux
@loanlaux
Jul 24 2018 16:33
True that
李华阳Martian
@Martian2Lee
Jul 24 2018 19:06
Hi everyone, glad to join the community. I want to ask, is it possible to build multiple stores(different domains, but share some products) on one database with Reaction?
Patrick Newell
@pnewell4_twitter
Jul 24 2018 19:11
@Martian2Lee yes!
\
- almost
(my asterisks disappeared!)
Shops already support multiple domains, so your Primary Shop can live on two different URLs
however, I have a feeling that you probably want different branding on each
you have two options here,
1) write some custom code to skin the site differently based on the domain
2) use the Marketplace feature of Reaction to create two different stores, but modify the product feed to show all products (it is currently limited to only those products which are tagged to the current shop)
syntaxtrayc
@syntaxtrayc
Jul 24 2018 22:16
hi all-- trying to get my feet wet with RC--attempting to import some product data. Can someone point toward the best place to get this accomplished? I landed on the Reaction.Importer page but still feel lost. Any guidance is appreciated.