These are chat archives for reactioncommerce/reaction

11th
Aug 2018
Patrick Newell
@pnewell4_twitter
Aug 11 2018 01:05
@zenweasel can you get into the weeds a little big on Packages and how they are created?
the reason I ask is that I have a plugin whose registry has changed a few times. Each time it changes, does a new document get added to the Packages collection? I noticed that I had a few with the same name. (none of them were 100% correct either, not sure whether that is related).
I went into the DB and manually cleaned them up, deleting the seemingly out of date documents. is there any risk in this?
Going forward, should I be writing migration scripts or something when they change, or should my registry changes be picked up automatically?
thanks!
Brent Hoover
@zenweasel
Aug 11 2018 01:07
The short answer is that these packages are written one time but they don't overwrite. In order to update you need to delete and rewrite
Brent Hoover
@zenweasel
Aug 11 2018 01:28
Generally if you want to make changes in production, writing a migration is the way to go
Patrick Newell
@pnewell4_twitter
Aug 11 2018 01:29
:thumbsup:
Christopher Matuszak
@TwixtedChaox
Aug 11 2018 01:30
I've been slowly getting back into Reaction Commerce and everything that it comes along with...
Brent Hoover
@zenweasel
Aug 11 2018 01:30
We’ve talked about different way to make this less painful, especially for development, but I would say that the current method of plugin registration will not survive too much longer
Christopher Matuszak
@TwixtedChaox
Aug 11 2018 01:31
So far I have every thing fine except speeding up the actual execution of the pages.. it still takes approx 45-85 seconds to load even the basic front page... any ideas on making my site faster?
Brent Hoover
@zenweasel
Aug 11 2018 01:32
@TwixtedChaox I would say that you have something fundamentally going wrong. A stock reaction renders in 4-5 seconds
Are you talking about in development the time to rebuild maybe?
Christopher Matuszak
@TwixtedChaox
Aug 11 2018 01:32
It's a 100% clean stock and it's taking that long
To render a page
Brent Hoover
@zenweasel
Aug 11 2018 01:33
No idea, have never seen that
Christopher Matuszak
@TwixtedChaox
Aug 11 2018 01:34
I thought maybe it was the server but when I install to my other server it takes just as long
Brent Hoover
@zenweasel
Aug 11 2018 01:34
I can’t even fathom how that would be possible tbh
Christopher Matuszak
@TwixtedChaox
Aug 11 2018 01:34
The admin panel takes a significant time longer to render (in page controls)
How long does it take to render this for you? Maybe it's my laptop??
Brent Hoover
@zenweasel
Aug 11 2018 01:36
Running 1.13 under load it takes 4-5 seconds
That’s with +200k products
Christopher Matuszak
@TwixtedChaox
Aug 11 2018 01:37
Just tested on my phone and it rendered in about .385 seconds.... guess it's my laptop then? But managing a store is best done NOT on mobile. ...
Brent Hoover
@zenweasel
Aug 11 2018 01:37
Is that the development server? Are you trying to run the development server in production?
I am seeing uncompiled/compressed code
Christopher Matuszak
@TwixtedChaox
Aug 11 2018 01:38
When I'm in "edit" mode it still takes a long time to render.. so far 28 seconds on mobile
Brent Hoover
@zenweasel
Aug 11 2018 01:39
also, that pages rendered in about 4 seconds for me as well. And I’m in Asia
Christopher Matuszak
@TwixtedChaox
Aug 11 2018 01:40
What is the ideal system setup for reaction commerce? @zenweasel
Brent Hoover
@zenweasel
Aug 11 2018 01:42
Sorry, I have to run, but generally you need to be running a built version, not the development server. 2GB of RAM
And as fast a processor as you can afford
Abhishek
@thegtagamer
Aug 11 2018 07:06
@zenweasel Hey Brent, while loading the devtools plugin into 1.14, I'm getting a cannot find module /server/api
Error: Cannot find module '/server/api'
at makeMissingError (packages/modules-runtime.js:231:12)
at require (packages/modules-runtime.js:241:19)
at methods.js (imports/plugins/custom/reaction-devtools/server/methods.js:1:1648)
at fileEvaluate (packages/modules-runtime.js:339:7)
at require (packages/modules-runtime.js:238:16)
at index.js (imports/plugins/custom/reaction-devtools/server/index.js:1:14)
at fileEvaluate (packages/modules-runtime.js:339:7)
at require (packages/modules-runtime.js:238:16)
at plugins.js (server/plugins.js:1:2526)
at fileEvaluate (packages/modules-runtime.js:339:7)
Abhishek
@thegtagamer
Aug 11 2018 14:06
Anyone facing any error while trying to add custom plugins to 1.14 ?
Abhishek
@thegtagamer
Aug 11 2018 14:13
nvm found the solution :) ..Its in the changelog
alnikitich
@alnikitich
Aug 11 2018 16:32
Hello i tried test reaction
and after reaction init && reaction (branch master)
i've got Exception while invoking method 'login' Error: insert requires an argument
thank you !
Patrick Newell
@pnewell4_twitter
Aug 11 2018 19:54
@alnikitich are you running on 127.0.0.1 or localhost?