These are chat archives for reactioncommerce/reaction

24th
Aug 2018
Brent Hoover
@zenweasel
Aug 24 2018 00:00
You are comparing the example-plugin tutorial and the swag-shop plugin
S Tunji Turner
@stunjiturner
Aug 24 2018 00:08
Yes
Brent Hoover
@zenweasel
Aug 24 2018 00:08
Why?
S Tunji Turner
@stunjiturner
Aug 24 2018 00:09
I was not sure what were the best practices, just wrapping my head around the customization
Brent Hoover
@zenweasel
Aug 24 2018 00:10
Yeah, that’s a good question. They are both valid approaches, but what the Swag Shop does is probably more applicable to any non-trivial customization
S Tunji Turner
@stunjiturner
Aug 24 2018 00:11
The /import/plugins/custom is under .gitignore, I usually just remove it from the txt file. Is there a better way! I want to deploy to my Heroku instance
Gotcha, that’s what I wanted to know.
Brent Hoover
@zenweasel
Aug 24 2018 00:13
You could also use git submodule
but I have tended to just go with having a fork and removing the .gitignore. But if you want to keep your plugin in a separate repo, submodule is the way to go
rohit-elevar
@rohit-elevar
Aug 24 2018 05:42

2) go into your database and update the Primary Shop's domains attribute, adding 127.0.0.1 to the array

@pnewell4_twitter Thanks!

S Tunji Turner
@stunjiturner
Aug 24 2018 23:02
@loanlaux I am having a problem with images in my plugin based on reaction-swag-shop? I replaced the image content but kept the same name, it’s changed in git, the original loaded image is still there.
Every image is in the public folder, but in the Heroku deployment the original images are stil there.
I did a reaction reset -n
Where a the plugins images stored