reactioncommerce/reaction

Reaction Commerce

Brent Hoover

@zenweasel

@spencern If you upgrade, also recommend removing the .meteor directory. There was a ton of stuff in there that was no longer needed.

The time to redownload is worth it

Spencer Norman

@spencern

woah

Aaron Judd

@aaronjudd

sanjo:jasmine
velocity:console-reporter
velocity:html-reporter

@zenweasel you have all those..

Brent Hoover

@zenweasel

Yep

velocity:console-reporter@0.2.1
velocity:html-reporter@0.10.0
sanjo:jasmine@1.0.0

Aaron Judd

@aaronjudd

:thumbsup: on .meteor, I rm -rf’ed my whole meteor install, and reinstalled.. 17+GB, took about 30 minutes to delete on the SSD

Brent Hoover

@zenweasel

rumroof’d it

Aaron Judd

@aaronjudd

lol - was wondering how to say that

Brent Hoover

@zenweasel

now you know

Aaron Judd

@aaronjudd

somehow I do feel smarter now.

Brent Hoover

@zenweasel

I get this message in the server console:

MochaRunner.runServerTests: Starting server side tests with run id sAXpujiEPtAB7xAcL
MochaRunner.runServerTests: failures: 0

I have a dummy test with the proper naming just for sanity sake

Aaron Judd

@aaronjudd

haven’t got that far yet, nothing is breaking but I have no test results other than that console error. looking at a npm peer dependency issue

Brent Hoover

@zenweasel

react and react-dom for reaction-ui?

Aaron Judd

@aaronjudd

yup

Brent Hoover

@zenweasel

Yeah, saw that too

Apparently anything in a tests directory is ignored. Cuz that makes sense

Aaron Judd

@aaronjudd

well I was assuming we’d just have to move and rename all the files, but, huh?

Brent Hoover

@zenweasel

Sanjo said "Also note that tests that are in a /tests/ folder will not get picked up.” but I had assumed he meant “won’t get picked up unless you rename them"

newsiberian

@newsiberian

Hi, any ideas why I see this:

Uncaught Error: Cannot find module 'util'
reactioncommerce_reaction-collections.js:31 Uncaught TypeError: Cannot read property 'bunyan' of undefined
reactioncommerce_reaction-email-templates.js:10 Uncaught TypeError: Cannot read property 'ReactionSubscriptions' of undefined
reactioncommerce_core.js:35 Uncaught TypeError: Cannot read property 'bunyan' of undefined
reactioncommerce_reaction-catalog.js:24 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
tmeasday_check-npm-versions.js:65 Uncaught Error: Cannot find module 'react/package.json'
reactioncommerce_reaction-ui.js:29 Uncaught TypeError: Cannot read property 'ReactionCore' of undefined
reactioncommerce_reaction-layout.js:32 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-accounts.js:33 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-router.js:22 Uncaught TypeError: Cannot read property 'ReactionSubscriptions' of undefined
meteor.js:913 Error logging in with token: Error: You've been logged out by the server. Please log in again. [403]
reactioncommerce_reaction-i18n.js:29 Uncaught TypeError: Cannot read property 'ReactionSubscriptions' of undefined
reactioncommerce_reaction-product-variant.js:31 Uncaught TypeError: Cannot read property 'ReactionRouter' of undefined
reactioncommerce_reaction-dashboard.js:32 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-orders.js:32 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-analytics.js:28 Uncaught TypeError: Cannot read property 'ReactionRouter' of undefined
reactioncommerce_reaction-inventory.js:27 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-checkout.js:32 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-shipping.js:30 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-social.js:29 Uncaught TypeError: Cannot read property 'currentProduct' of undefined
reactioncommerce_reaction-ui-navbar.js:30 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-ui-tagnav.js:31 Uncaught TypeError: Cannot read property 'TextField' of undefined
reactioncommerce_reaction-paymentmethod.js:31 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-stripe.js:32 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-auth-net.js:31 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-braintree.js:31 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-sample-data.js:8 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
global-imports.js:8 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
app.js:1 Uncaught ReferenceError: meteorInstall is not defined
meteorhacks_fast-render.js:232 Uncaught Error: seems like cookie tossing is happening. visit here: http://git.io/q4IRHQ

Aaron Judd

@aaronjudd

@newsiberian did you do npm install (or use reaction pull I added it there as well) ?

util is installed by meteor-node-stubs from the app package.json

newsiberian

@newsiberian

after npm install I so another error. Maybe this is because I' working in fork and something was merged with errors...

check-npm-versions.js:21 Uncaught Error: Cannot find module 'bunyan-format/package.json'require @ modules-runtime.js?hash=939c79d…:95compatibleVersionIsInstalled @ check-npm-versions.js:10(anonymous function) @ check-npm-versions.js:29_.each._.forEach @ underscore.js?hash=8de51f9…:147checkNpmVersions @ check-npm-versions.js:28meteorInstall.node_modules.meteor.reactioncommerce:reaction-logger.client.main.js @ main.js:3fileEvaluate @ modules-runtime.js?hash=939c79d…:158require @ modules-runtime.js?hash=939c79d…:92(anonymous function) @ reactioncommerce_reaction-logger.js?hash=7010811…:2618(anonymous function) @ reactioncommerce_reaction-logger.js?hash=7010811…:2629
reactioncommerce_reaction-collections.js?hash=12901a7…:31Uncaught TypeError: Cannot read property 'bunyan' of undefined(anonymous function) @ reactioncommerce_reaction-collections.js?hash=12901a7…:31(anonymous function) @ reactioncommerce_reaction-collections.js?hash=12901a7…:549
reactioncommerce_reaction-email-templates.js?hash=cd84da2…:10 Uncaught TypeError: Cannot read property 'ReactionSubscriptions' of undefined(anonymous function) @ reactioncommerce_reaction-email-templates.js?hash=cd84da2…:10(anonymous function) @ reactioncommerce_reaction-email-templates.js?hash=cd84da2…:47
reactioncommerce_core.js?hash=2672883…:35Uncaught TypeError: Cannot read property 'bunyan' of undefined(anonymous function) @ reactioncommerce_core.js?hash=2672883…:35(anonymous function) @ reactioncommerce_core.js?hash=2672883…:1820
reactioncommerce_reaction-catalog.js?hash=6527cf7…:24 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined(anonymous function) @ reactioncommerce_reaction-catalog.js?hash=6527cf7…:24(anonymous function) @ reactioncommerce_reaction-catalog.js?hash=6527cf7…:349
reactioncommerce_reaction-ui.js?hash=35aeb72…:29Uncaught TypeError: Cannot read property 'ReactionCore' of undefined(anonymous function) @ reactioncommerce_reaction-ui.js?hash=35aeb72…:29(anonymous function) @ reactioncommerce_reaction-ui.js?hash=35aeb72…:43353
reactioncommerce_reaction-layout.js?hash=063415e…:32 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined(anonymous function) @ reactioncommerce_reaction-layout.js?hash=063415e…:32(anonymous function) @ reactioncommerce_reaction-layout.js?hash=063415e…:1398
reactioncommerce_reaction-accounts.js?hash=d74aa71…:33Uncaught TypeError: Cannot read property 'ReactionImport' of undefined(anonymous function) @ reactioncommerce_reaction-accounts.js?hash=d74aa71…:33(anonymous function) @ reactioncommerce_reaction-accounts.js?hash=d74aa71…:4371
reactioncommerce_reaction-router.js?hash=65ec805…:22Uncaught TypeError: Cannot read property 'ReactionSubscriptions' of undefined(anonymous function) @ reactioncommerce_reaction-router.js?hash=65ec805…:22(anonymous function) @ reactioncommerce_reaction-router.js?hash=65ec805…:589
reactioncommerce_reaction-i18n.js?hash=8ba3307…:29Uncaught TypeError: Cannot read property 'ReactionSubscriptions' of undefined(anonymous function) @ reactioncommerce_reaction-i18n.js?hash=8ba3307…:29(anonymous function) @ reactioncommerce_reaction-i18n.js?hash=8ba3307…:3865
reactioncommerce_reaction-product-variant.js?hash=83139bc…:31Uncaught TypeError: Cannot read property 'ReactionRouter' of undefined(anonymous function) @ reactioncommerce_reaction-product-variant.js?hash=83139bc…:31(anonymous function) @ reactioncommerce_reaction-product-variant.js?hash=83139bc…:34286
reactioncommerce_reaction-dashboard.js?hash=17f984c…:32Uncaught TypeError: Cannot read property 'ReactionImport' of undefined(anonymous function) @ reactioncommerce_reaction-dashboard.js?hash=17f984c…:32(anonymous function) @ reactioncommerce_reaction-dashboard.js?hash=17f984c…:1598
reactioncommerce_reaction-orders.js?hash=d19fe3d…:32Uncaught TypeError: Cannot read property 'ReactionImport' of undefined(anonymous function) @ reactioncommerce_reaction-orders.js?hash=d19fe3d…:32(anonymous function) @ reactioncomm

Aaron Judd

@aaronjudd

if you have a forked version, the logging directory renamed to packages/reaction-logger instead of packages/reaction-logging. could be a mixup there? if not though, this looks like a build error, maybe run (from project root)

  find . -name bower -exec rm -rf {} \;
  find . -name node_modules -exec rm -rf {} \;

to clear out any existing installed node_modules, and rerun - (one of several tricks I have had to do to reset)

newsiberian

@newsiberian

Thanks, I already remove old reaction-logging folder...

also, I've just download clean reaction and it shows me:

sohaam@debian:~/devel/reaction-src/reaction$ meteor
[[[[[ ~/devel/reaction-src/reaction ]]]]]     

=> Started proxy.                             
=> Errors prevented startup:                  

   While selecting package versions:
   error: Potentially incompatible change required to top-level dependency: reactioncommerce:launchdock-connect 0.2.1, was 0.2.2.
   Constraints on package "reactioncommerce:launchdock-connect":

   Potentially incompatible change required to top-level dependency: reactioncommerce:reaction-paypal 1.3.0, was 1.4.0.
   Constraints on package "reactioncommerce:reaction-paypal":

   To allow potentially incompatible changes to top-level dependencies, you must pass --allow-incompatible-update on the command line.

=> Your application has errors. Waiting for file change.
=> Started MongoDB.

Brent Hoover

@zenweasel

Hmmm, @aaronjudd do I need to publish those packages?

Aaron Judd

@aaronjudd

reaction pull will bring those down into the fresh install, otherwise it’s hitting the older packages in atmosphere

@zenweasel we can, should be safe because they’re requiring Meteor 1.3

newsiberian

@newsiberian

Brent Hoover

@zenweasel

Shouldn’t break anything backwards compatability-wise

Ah, ok

Aaron Judd

@aaronjudd

although we probably should have bumped connect to 0.3.0. sigh but nothing changed but the packages.js

Brent Hoover

@zenweasel

I published those packages, will double-check that a fresh clone still works

Aaron Judd

@aaronjudd

:+1:

Brent Hoover

@zenweasel

I removed the practicalmeteor packages and now I am getting

I20160412-14:03:19.321(8)? jasmine-server: 1 tests passed (1ms)
I20160412-14:03:19.709(8)? jasmine-client: 1 tests passed (3ms)

Aaron Judd

@aaronjudd

nice!

only 150+ more to go, lol.

Brent Hoover

@zenweasel

lol, yep

Aaron Judd

@aaronjudd

@newsiberian did you get it running?

Brent Hoover

@zenweasel

published launchdock-connect and now a fresh clone will work OOTB

newsiberian

@newsiberian

@aaronjudd, sorry, I was afk. I'll try again little bit later

newsiberian

@newsiberian

With clean reaction, second time rmed .meteor and reaction pull && bin/reset && npm install && meteor still so the same list of errors. Pretty strange)

xiaoc li

@brianxcli

Do you mean the dependency version errors?

newsiberian

@newsiberian

I mean this errors

xiaoc li

@brianxcli

Have you checked whether you have bunyan package?

Any explanation of what is workflow in routing?

newsiberian

@newsiberian

all starting to work after I commit some lines:

Npm.depends({
//  "bunyan": "1.8.0",
//  "bunyan-format": "0.2.1",
//  "bunyan-loggly": "0.0.5"
});

I'm looking into that reaction-logger and it scares me. Why so much overhead with deps? why we getting the same packages from meteor internal system Npm.depends then, via package.json, and what happens inside client/main.js?

Where communities thrive

People

Repo info

Activity