Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 24 2022 10:22
    focusaurus removed as member
  • Aug 24 2022 10:22
    rosshadden removed as member
  • Aug 24 2022 10:21
    spencern removed as member
  • Aug 05 2022 02:51
    spencern added as member
  • Aug 05 2022 02:51
    focusaurus added as member
  • Aug 05 2022 02:50
    rosshadden added as member
  • Aug 01 2022 08:28

    vanpho93 on test-new-api-core

    test: new commit from core Sig… (compare)

  • Jul 29 2022 03:07
    zenweasel edited #6437
  • Jul 29 2022 03:06
    zenweasel closed #6434
  • Jul 29 2022 02:49
    zenweasel assigned #6439
  • Jul 29 2022 02:48
    zenweasel labeled #6439
  • Jul 29 2022 02:48
    zenweasel opened #6439
  • Jul 29 2022 02:46
    zenweasel labeled #6438
  • Jul 27 2022 02:06
    zenweasel labeled #6438
  • Jul 27 2022 02:06
    zenweasel opened #6438
  • Jul 27 2022 02:06
    zenweasel assigned #6438
  • Jul 22 2022 03:37
    zenweasel edited #6416
  • Jul 22 2022 03:36
    zenweasel assigned #6416
  • Jul 21 2022 01:49

    vanpho93 on test-new-api-core

    chore: e2e test for apollo upgr… (compare)

  • Jul 20 2022 04:07
    zenweasel edited #6437
Loan Laux
@loan-laux
Hello everyone! Just like with our new devtools, we’ve updated our AWS S3 plugin to be used with Reaction 3.0. To make it consistent with the rest of out:grow’s open-source plugins, it’s now published on NPM with the org prefix @outgrowio/. The setup instructions have changed too, so make sure to read them before doing the update. Hope that’ll help the community. https://github.com/outgrow/reaction-file-collections-sa-s3
HarisSpahijaPon
@HarisSpahijaPon
@mo7sener ws is still WIP afaik, it shouldn't be breaking.
Robear Selwans
@mo7sener
The problem I get is as follows:
1) I sudo make init then sudo make start
2) I create an account and open localhost:4080then the products tab
3) When I click the "Create Product" button, I get the following error (https://cdn.discordapp.com/attachments/324535887788507138/674255378736873492/unknown.png) accompanied by a blank page
4) I, then, restart the "reactionadmin" container using docker restart reactionadmin_reaction-admin_1
5) Clicking the "Create Product" button after that opens the product creation form. But whenever I try to interact with the form (even by clicking on the page), I get a Match failed [400] and the following error in the console: (https://cdn.discordapp.com/attachments/324535887788507138/674256064706772992/unknown.png)
Loan Laux
@loan-laux
@mo7sener Pulled the latest reaction-admin and running into the same bugs. Looks like the product editor is a WIP while @mikemurray is working on porting it to 100% GQL. The PR is right here, and it looks like it’ll be ready soon. reactioncommerce/reaction-admin#188 Hang tight!
That’s part of the whole beta-testing experience. :smile: But more seriously, if you absolutely need to use reaction-admin right now, I would suggest to git checkout an earlier tag/commit. Going back one week would probably do the trick.
Robear Selwans
@mo7sener
Oh, ok nice. I'm not in much of a hurry, but how long do you think will it take for that PR to be finished?
Loan Laux
@loan-laux
No idea but reading the commit log, I’d say it’s likely a matter of days… @mikemurray will have to confirm though, as he’s the one working on it.
But I’m not sure he’s often on here. Maybe @aldeed can comment instead.
Bart Janssen
@bjanssen-pon
Question, is it possible to add a Select component to a ConfirmDialog? (package @reactioncommerce/catalyst/ConfirmDialog)
Loan Laux
@loan-laux
@bjanssen-pon Unfortunately, unlike on the example storefront, there isn’t any component context in reaction-admin. So the solution would be to create a new component somewhere in your codebase, which would be a class extending ConfirmDialog, and then to replace any import of @reactioncommerce/catalyst/ConfirmDialog with your custom local component.
It would really be good to have a global component context for doing clean overrides in reaction-admin. Definitely something we need, and not much work. I’ll try and work on that at some point.
Bart Janssen
@bjanssen-pon
@loan-laux , Thanks! I will try to create a generic item for it and share it if its done.
HarisSpahijaPon
@HarisSpahijaPon
Tbh it is quite confusing to have components in so many different places
Loan Laux
@loan-laux
You mean not having a component context in reaction-admin?
HarisSpahijaPon
@HarisSpahijaPon
Just in general on example-storefront aswell
Component context would work great if all components are actually in the context
but sometimes there are components that are hidden in the reaction-component-library or double named in both components folder and reaction-component-library
I am planning on refactoring a lot of components
I just don't have enough time in a week :P
Loan Laux
@loan-laux
Working on RC every day for years, you kind of lose sense of this because you’re so used to the overall architecture… I agree with you, some things can be confusing and will contribute to the learning curve, so we should definitely tackle them. A good refactor to eliminate duplicates would be more than welcome. :clap:
HarisSpahijaPon
@HarisSpahijaPon
Oh agreed, I don't have any trouble with the architecture. Just when I try to explain it to others I notice that some things don't make sense
So I can imagine the learning curve can be harder because of this
Loan Laux
@loan-laux
Yup, 100% with you on this. During consulting sessions I often notice the same. Some things just confuse newcomers when they shouldn’t. We need to do something for this!
HarisSpahijaPon
@HarisSpahijaPon
I noticed this with nextjs and mendix, they added documentation bounties for pull requests
One new page for documentation would be awarded like 5 euro's.
The documentation for mendix got written in less than a week. Almost 200+ md files added by the community
1000 euro's for a complete documentation, seems fair to me
Loan Laux
@loan-laux
Interesting concept. I like it. I would definitely prioritize writing documentation if that was the case. A free latte for a page of docs. :grinning: Sounds like a good deal for something that will greatly benefit the community.
Spencer Norman
@spencern
We’ve done bug bounties in the past before, but I hadn’t seen doc bounties. It’s a good idea. I’ll see if that’s something we could add as an incentive to help improve our documentation.
Robear Selwans
@mo7sener
What would be the most reasonable way to integrate fuzzy search? Like should I use elasticsearch or would it be too much of a hassle?
Daniel Rosiak
@daniel-rosiak
You can write it yourself by using some algorithm or just use elasticsearch or something like him: swiftype etc. Implementation is quite easy - just push product to ES on product publish
You can create a plugin where you will be listening to event "afterPublishProductToCatalog" and pushing product to ES
Then you just need to expose ES in your application - to get data in your storefront
HarisSpahijaPon
@HarisSpahijaPon
@spencern Where can we start :D
Spencer Norman
@spencern
@HarisSpahijaPon do you know if there’s a tool that these other groups used to do doc bounties?
Erik Kieckhafer
@kieckhafer
Hi all, we have just released new beta versions of all of our reaction-development-platform projects: https://github.com/reactioncommerce/reaction-development-platform/releases/tag/v3.0.0-beta.4
Please make sure to follow the instructions in any one of the 5 related PR's listed here to update your env files to get all the docker networks synced up: reactioncommerce/reaction-development-platform#101
Robear Selwans
@mo7sener
Oh cool, that actually fixed the problem with the admin ui's "create product"
@daniel-rosiak Oh thanks. I somehow didn't think about using reaction's events. This will actually make it a bit of a trivial task.
HarisSpahijaPon
@HarisSpahijaPon
@spencern https://gitpay.me/
If you want to create a fully automated bug bounty system with TDD you can set it up with k8s
You would have to apply for the alpha though
adel1ne
@adel1ne

Hi!
@loan-laux belated thanks for answer :)

I've got one more question. Is there any way to catch worker event?
For example:
in src/core-services/files/jobs/saveTempImages.jsthere is context.backgroundJobs.addWorker,
which is triggered function async worker(job), then find jobs with suitable status in DB.
I need to catch successful completion of this process in my own plugin,
preferably without editing the code in project plugin files.

Loan Laux
@loan-laux
@adel1ne As far as I’m aware, there are no events yet for catching the completion of job workers. It’s definitely something that’s missing. I ran into the same issue when developing reaction-dummy-data. But as a workaround, you could use a MongoDB change stream on the Jobs collection. Not ideal, but I’d say it’s an acceptable alternative while there’s no official API to monitor jobs. Would that work for you?
adel1ne
@adel1ne
@loan-laux thanks again!
Judging by the description, this should fit.
But i am not very well oriented in the project, is there any example of using this stream?
Or can you tell where exactly to look this stuff?
Loan Laux
@loan-laux
@adel1ne The MongoDB docs would be a good place to start. It’s a simple concept. First, declare your change stream like const stream = collection.watch(). Then, observe the change event on it with your own callback: stream.on(“change”, (event) => console.log(“Something changed in the collection:”, event));.