Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Lionel
    @elrumordelaluz
    no, probably not
    I 99% sure that is a position/size issue
    but didn't enter in code details yesterday
    I'm sorry, a lil busy
    Jov Stern
    @jovstern
    could be great, it's what we discuss in the beginning.
    Lionel
    @elrumordelaluz
    yes,
    Jov Stern
    @jovstern
    thats fine, we still not sure why the scroller can't scroll to the right position
    Lionel
    @elrumordelaluz
    in this direction I want to cerate a codesandbox with redux or another external store
    Jov Stern
    @jovstern
    why not Mobx?
    simpler library..
    Lionel
    @elrumordelaluz
    sure
    in case you have a peace of time creating the repro of your App (without all the content) I'll take as test case if you use Mobx
    Jov Stern
    @jovstern
    it will be easy to get to Italy instead :)
    you from Italy right?
    it's a huge app and we need all the content to get it right.
    Lionel
    @elrumordelaluz
    I am an argentinean living in Italy, but don't understant what you mean
    I said it would be awesome to have a codesandbox (as a test case) with mobx or redux or similar
    Jov Stern
    @jovstern
    Yeh, we should to that but right now i need to figure this out, i'm starting from the beginning to understand what causing this behavior, i let you know soon if i find something, i really back to square one i don't know if it's CSS problem or functionality issue..
    Jov Stern
    @jovstern
    5.gif
    Ok, so i written the Tour from scratch without stores or EventsLister, the simples way of the tour and you can see the problem, it's to small Divs but way far from each other. now i want to check my app cause i have a lot of fixed elements and components that have there own scrolling events..
    Jov Stern
    @jovstern
    Yo @elrumordelaluz i just realize in Safari it's works PERFECT!
    i can't believe i didn't check it until now, i only test the app in Chrome and Firefox.
    maybe in the Tour scroller event something is not quite fit to Chrome or Firefox
    Jov Stern
    @jovstern
    I think i got the solution, it's seems like my overflow-x: hidden causing this problem. i don't understand way but, if remove it it's helping.
    Lionel
    @elrumordelaluz
    lol
    was the first question I wanted to ask you, if you are resetting this https://github.com/elrumordelaluz/reactour/blob/master/src/TourPortal.js#L64-L69
    haha
    ok, so in Safari works as expected and not Chrome, right?
    nice catch @jovstern I'll have to check some dependencies that handle the scroll behaviour
    Lionel
    @elrumordelaluz
    also look at elrumordelaluz/reactour#10
    where describe that in fact Safari doesn't handle the overflow-y as expected, like the default in reactour
    si, I think in Safari you could scroll also when the Tour is open
    are one of the stepswe are studying, positioned other than relative?
    or in its own scrollable parent node?
    Jov Stern
    @jovstern
    Its own scrollable node, the position of the components doesn't effect on the Tour. let me know if you change something in the widget and off course i let you know when it's on prod. thank you for now..
    Lionel
    @elrumordelaluz
    sure!
    praveenkutty
    @praveenkutty
    hello there,
    could you please tell me how can i store the current step in state(reactour)
    thanks in advance
    Dovy Paukstys
    @dovy
    Yay, Glitter.
    Dovy Paukstys
    @dovy
    Thanks for the awesome work @elrumordelaluz
    Peter Kottas
    @PeterKottas
    Hi there, happy to discuss the state of dev for the @next phase of reactour. Feel free to hit me with some details about the actions. I can clone it and take a look then. Generally speaking, I am mostly looking for understanding why the actions are even required. What is the main reason for it be implemented as I think it could be done by controlling the state directly.
    But like I've said before, I might be missing something.
    Dovy Paukstys
    @dovy
    @PeterKottas I think the main issue is the same issue I experienced. In the current implementation I set an action, but the action occurs too late and the component I render in that action isn't displayed. I believe there's the desire (and rightfully so) to do a before animation as well as cleanup function so that steps can clean themselves up without affecting other steps. Right now, the "cleanup" for a step must occur in the action of another step. Not the easiest to manage.
    MidasCKR
    @ckrukp
    hey @elrumordelaluz
    Thanks so much your awesome library and your work.
    I use your reactour in my project. Btw i have some problems to use that.
    Should i be able to receive the status of the checkbox on the step content when tour is closed?
    Peter Kottas
    @PeterKottas
    Notifications were not working ... I can see your messages now. Would it maybe make sense to look at what mui is doing with their modals? If this is all about transitions, I think they have it covered over there at https://material-ui.com/api/modal/. Coming back to the message, I am not sure if the cleanup is the wat to go in react. Generally speaking, since react is declarative, the cleanup should be based on this declarative nature. You can also easily achieve cleanup by using something like this.
    React.useEffect(()=>{if(step===stepThatNeedsCleanup){return ()=>performCleanUp()}});Basically just reacting to the step being changed. What you could do on the other side of things (with initialization). You can add prop transitionDuration. Use internal state to keep the step that is provided externally. Now every time the internal step is not equal to the external step, you would run a timer (keep the instance to be able to clear it if it changes again). When this timer fires, the internal step is set to the external step. This way you can easily fire a callback (beforeStep, afterStep, stepShown) and you can also add special className used for the transition when the timer is running. Hope ti makes sense :)
    Lionel
    @elrumordelaluz

    Notifications were not working…

    Same for me, I'm reading all the new messages right now.