@csalvato do you like to chat about your PR (in the near future?) or any other topics? Otherwise, I would prefer to just use the issue/pr on GitHub to talk about it. But if you have questions, just contact me here or somewhere else.
Hello! We're using this library a lot at ConvertKit to build reliable specs around Stripe. As we're building the next feature for our platform, we've hit a few roadblocks with this library missing features. We're slowly going to create PRs in the coming days/weeks and at the same time, I saw that you were looking for contributors. I'd be more than happy to become one, if it can help both ConvertKit and the community! cc @Gilbert
@csalvato that's a good question, just fork (you did it already I know) the repository, create features branches on your own and then create PRs on this project.
@csalvato can you explain what you mean 'I am unable to push a branch to the repo' (you are using your fork?) and 'open a PR' (I didn't see a reason why it shouldn't work)
@mnin_twitter I've never contributed to an OSS project before. I thought I could make a branch then just push it to the repo, as I've done in other repos. Looks like I need to make a fork, and a branch, then create a PR on this project. I'll look into doing that (will be a first for me!)
It may take me a few days to open though
@csalvato oh, congratulations! Just fork the original repository to your own user account, modify it and click 'New Pull Request' (see https://docs.github.com/en/enterprise/2.15/user/articles/creating-a-pull-request-from-a-fork)
i just added the toggle in my single rspec test. Should i put it somewhere else?
@mnin_twitter ^
stripe-ruby-mock/stripe-ruby-mock#763
I think we have three options from here cc @gilbert @alexmamonchik @mnin_twitter @pothibo
No offense intended by any of this - just looking to make progress on my own projects, and build on the great work which is already in this repo.
on this call "Stripe::Customer.list({ email: email.to_s })"
Hi all, @gilbert just added me as a contributor. I've committed a few changes already, including one that fixes your issue @mjimenez-pernix stripe-ruby-mock/stripe-ruby-mock#784
I've created a pull request to make
Stripe::Checkout::Session.create behave more like the real API, but it is a fairly big change (technically a breaking change, but only because it's closer to the real API), so I've just created a pull request for now. If anyone has opinions on it feel free to leave some comments, otherwise I'll push to to master in a couple of days stripe-ruby-mock/stripe-ruby-mock#786
Hey all, so I've been using this gem and it's really useful, thanks to the creator! I've been running into a small issue where I noticed the webhooks seem to be somewhat out of date and some are missing. I wrote a tool to log all of the stripe webhook responses and generalize them. If I create a PR updating all of the fixtures at once using this tool would it be considered? https://github.com/rbclark/stripe-webhook-logger
BTW: I would be quite helpful telling users how to install. properly:
gem 'stripe-ruby-mock', :require => 'stripe_mock', git: 'https://github.com/stripe-ruby-mock/stripe-ruby-mock.git', branch: 'master' is this correct? because with the described one in the README did not work for me
copy the line where it says gem, the line in the box, place it into your Gemfile.
rub bundle install
gem "stripe-ruby-mock", require: "stripe_mock"
stripe_api_key: <%= ENV["STRIPE_API_KEY"] %>
stripe_publishable_key: <%= ENV["STRIPE_PUBLISHABLE_KEY"] %>
stripe_signing_secret: <%= ENV["STRIPE_SIGNING_SECRET"] %>
stripe_test_secret_key: <%= ENV["STRIPE_TEST_SECRET_KEY"] %>
stripe_version: <%= ENV["STRIPE_VERSION"] %>
stripe_webhook_secret: <%= ENV["STRIPE_WEBHOOK_SECRET"] %>
stripe_webhook_signing_secret: <%= ENV["STRIPE_WEBHOOK_SIGNING_SECRET"] %>
stripe_publishable_key: <%= ENV["STRIPE_PUBLISHABLE_KEY"] %>
stripe_signing_secret: <%= ENV["STRIPE_SIGNING_SECRET"] %>
stripe_test_secret_key: <%= ENV["STRIPE_TEST_SECRET_KEY"] %>
stripe_version: <%= ENV["STRIPE_VERSION"] %>
stripe_webhook_secret: <%= ENV["STRIPE_WEBHOOK_SECRET"] %>
stripe_webhook_signing_secret: <%= ENV["STRIPE_WEBHOOK_SIGNING_SECRET"] %>
and those variables are in your environment variables, which are never shared.
Hope that helps
Also, I always read the Documentation link. If there isn't one, I read the Home Page.
Hello, would it be possible to back port commit: stripe-ruby-mock/stripe-ruby-mock@5cdbf6f to version 2.5 to fix Ruby 2.7 kwargs warnings?
created an issue: stripe-ruby-mock/stripe-ruby-mock#839