yes, tests in all branches still not green but we have to make it less sensitive
Oh, looks like I can just use
Stripe::Subscription.new or Stripe::Subscription.construct_from from the stripe-ruby gem itself
and saving them isn't possible without creating other objects it depends on
which in turn depends on even more objects
So far I've got the following code, but I can't yet create a stripe_customer because it needs a Source and more params. I'm probably going about this the wrong way.
How can I get a working Stripe::Subscription object? Something that seems persisted as if I got it from the Stripe API.
let(:stripe_product) { Stripe::Product.create StripeMock::Data.mock_product }
let(:stripe_plan) { Stripe::Plan.create StripeMock::Data.mock_plan.merge(product: stripe_product.id) }
let(:stripe_customer) { Stripe::Customer.create StripeMock::Data.mock_customer }
let(:stripe_subscription) { Stripe::Subscription.create StripeMock::Data.mock_subscription.merge(plan: stripe_plan.id, customer: stripe_customer.id) }
Just try this:
context 'with stripe mock' do
before { StripeMock.start }
after { StripeMock.stop }
context 'with stripe subscription' do
helper = StripeMock.create_test_helper
let(:plan) { helper.create_plan(amount: 1099, product: helper.create_product.id, currency: 'eur') }
let(:customer) { Stripe::Customer.create(currency: 'eur', source: helper.generate_card_token) }
let(:subscription) { Stripe::Subscription.create(customer: customer.id, items: [{ plan: plan.id }]) }
end
end
@marckohlbrugge_twitter https://github.com/stripe-ruby-mock/stripe-ruby-mock/blob/master/lib/stripe_mock/api/webhooks.rb#L38 no subscription events listed here...
@gilbert I'd like to open a PR for this: stripe-ruby-mock/stripe-ruby-mock#737
I created a fork that addresses things, but can add tests and open it as a PR: https://github.com/leevo/stripe-ruby-mock
I probably won't be on Gitter again, but my contact info is on my GitHub account: http://github.com/csalvato
@csalvato do you like to chat about your PR (in the near future?) or any other topics? Otherwise, I would prefer to just use the issue/pr on GitHub to talk about it. But if you have questions, just contact me here or somewhere else.
Hello! We're using this library a lot at ConvertKit to build reliable specs around Stripe. As we're building the next feature for our platform, we've hit a few roadblocks with this library missing features. We're slowly going to create PRs in the coming days/weeks and at the same time, I saw that you were looking for contributors. I'd be more than happy to become one, if it can help both ConvertKit and the community! cc @Gilbert
@csalvato that's a good question, just fork (you did it already I know) the repository, create features branches on your own and then create PRs on this project.
@csalvato can you explain what you mean 'I am unable to push a branch to the repo' (you are using your fork?) and 'open a PR' (I didn't see a reason why it shouldn't work)
@mnin_twitter I've never contributed to an OSS project before. I thought I could make a branch then just push it to the repo, as I've done in other repos. Looks like I need to make a fork, and a branch, then create a PR on this project. I'll look into doing that (will be a first for me!)
It may take me a few days to open though
@csalvato oh, congratulations! Just fork the original repository to your own user account, modify it and click 'New Pull Request' (see https://docs.github.com/en/enterprise/2.15/user/articles/creating-a-pull-request-from-a-fork)
i just added the toggle in my single rspec test. Should i put it somewhere else?
@mnin_twitter ^
stripe-ruby-mock/stripe-ruby-mock#763
I think we have three options from here cc @gilbert @alexmamonchik @mnin_twitter @pothibo
No offense intended by any of this - just looking to make progress on my own projects, and build on the great work which is already in this repo.
on this call "Stripe::Customer.list({ email: email.to_s })"
