Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Martin Wilhelmi
@mnin_twitter
@csalvato hey, thanks for finding this issue!
@csalvato do you like to chat about your PR (in the near future?) or any other topics? Otherwise, I would prefer to just use the issue/pr on GitHub to talk about it. But if you have questions, just contact me here or somewhere else.
Pier-Olivier Thibault
@pothibo
Hello! We're using this library a lot at ConvertKit to build reliable specs around Stripe. As we're building the next feature for our platform, we've hit a few roadblocks with this library missing features. We're slowly going to create PRs in the coming days/weeks and at the same time, I saw that you were looking for contributors. I'd be more than happy to become one, if it can help both ConvertKit and the community! cc @Gilbert
Chris Salvato
@csalvato
@mnin_twitter I am happy to keep the conversation on the issue and subsequent PR; but I am unable to push a branch to the repo and open a PR. What is the process you'd like me to follow?
Martin Wilhelmi
@mnin_twitter
@pothibo nice! Hope @klaustopher will help you to merge the stuff!
@csalvato that's a good question, just fork (you did it already I know) the repository, create features branches on your own and then create PRs on this project.
@csalvato can you explain what you mean 'I am unable to push a branch to the repo' (you are using your fork?) and 'open a PR' (I didn't see a reason why it shouldn't work)
Chris Salvato
@csalvato
@mnin_twitter I've never contributed to an OSS project before. I thought I could make a branch then just push it to the repo, as I've done in other repos. Looks like I need to make a fork, and a branch, then create a PR on this project. I'll look into doing that (will be a first for me!)
It may take me a few days to open though
Martin Wilhelmi
@mnin_twitter
@csalvato oh, congratulations! Just fork the original repository to your own user account, modify it and click 'New Pull Request' (see https://docs.github.com/en/enterprise/2.15/user/articles/creating-a-pull-request-from-a-fork)
joshm1204
@joshm1204
Where does StripeMock.toggle_debug(true) output to? Can i set where it outputs? I checked my test.log file and found no output. I need to check the correct name to add an error to :update_subscription, as i get an error when i prepare an error using this name.
Martin Wilhelmi
@mnin_twitter
@joshm1204 see if there is a separate file called "stripe-mock-server.log"
joshm1204
@joshm1204
No seperate file, where would it be located?
i just added the toggle in my single rspec test. Should i put it somewhere else?
@mnin_twitter ^
Martin Wilhelmi
@mnin_twitter
@joshm1204 hey, should be in the log directory
Espen from @MakePlans
@Espen_Antonsen_twitter
Is there any way to add fixtures? I have an account that is used in many tests. Do I just 'Stripe::Account.create' or can I add a json fixture somewhere like with the webhooks?
Chris Salvato
@csalvato
@gilbert I've opened two PRs in the repo. What do I need to do to get it merged in?
Chris Salvato
@csalvato
@mnin_twitter ^

stripe-ruby-mock/stripe-ruby-mock#763

I think we have three options from here cc @gilbert @alexmamonchik @mnin_twitter @pothibo

No offense intended by any of this - just looking to make progress on my own projects, and build on the great work which is already in this repo.
Chris Salvato
@csalvato
@pothibo Are you still interested in becoming a contributor?
Alex Takitani
@alextakitani
Hello!
Pavel Isakov
@isakovp
Hello, looks like stripe-ruby-mock doesn't support SubscriptionSchedule or not?
mjimenez-pernix
@mjimenez-pernix
Hi, I am using stripe 5.30.0 and stripe-ruby-mock 3.0.1, when a run my test I get this "wrong number of arguments (given 3, expected 2)"
on this call "Stripe::Customer.list({ email: email.to_s })"
Andrew Leung
@a-leung
Hi
Konstantin Uroskin
@kuroskin
Why is receipt_url not supported in the data for charges?
Graham Rogers
@TastyPi
Hi all, @gilbert just added me as a contributor. I've committed a few changes already, including one that fixes your issue @mjimenez-pernix stripe-ruby-mock/stripe-ruby-mock#784
Graham Rogers
@TastyPi
I created a new release with my changes, but I don't have permission to push it to rubygems, could someone do that for me or grant me the permissions?
Graham Rogers
@TastyPi
I've created a pull request to make Stripe::Checkout::Session.create behave more like the real API, but it is a fairly big change (technically a breaking change, but only because it's closer to the real API), so I've just created a pull request for now. If anyone has opinions on it feel free to leave some comments, otherwise I'll push to to master in a couple of days stripe-ruby-mock/stripe-ruby-mock#786
kathyonu
@kathyonu
@mnin_twitter Thank you for your July 20th mention of create_product helper. I have been unable to find it in the documentation. Your three let lines made my day.
Zeeshan Khan
@emailsystem2011_gitlab
hi, i need help regarding paymentintent?
Robert Clark
@rbclark
Hey all, so I've been using this gem and it's really useful, thanks to the creator! I've been running into a small issue where I noticed the webhooks seem to be somewhat out of date and some are missing. I wrote a tool to log all of the stripe webhook responses and generalize them. If I create a PR updating all of the fixtures at once using this tool would it be considered? https://github.com/rbclark/stripe-webhook-logger
Robert Clark
@rbclark
@TastyPi @gilbert @alexmamonchik @mnin_twitter @pothibo Do any of you mind reviewing my PR regarding webhooks? This gem is really useful but the out of date fixtures is making it not very realistic for current webhook response testing.
Jan
@exocode
Hi there how can I handle the signature headers ? HTTP_STRIPE_SIGNATURE
BTW: I would be quite helpful telling users how to install. properly: gem 'stripe-ruby-mock', :require => 'stripe_mock', git: 'https://github.com/stripe-ruby-mock/stripe-ruby-mock.git', branch: 'master' is this correct? because with the described one in the README did not work for me
kathyonu
@kathyonu
Hi @exocode .. arrive here: https://rubygems.org/ search stripe-ruby-mock then click on it.
copy the line where it says gem, the line in the box, place it into your Gemfile.
rub bundle install
gem "stripe-ruby-mock", require: "stripe_mock"
kathyonu
@kathyonu
regarding how to handle question, is this what you mean ..
stripe_api_key: <%= ENV["STRIPE_API_KEY"] %>
stripe_publishable_key: <%= ENV["STRIPE_PUBLISHABLE_KEY"] %>
stripe_signing_secret: <%= ENV["STRIPE_SIGNING_SECRET"] %>
stripe_test_secret_key: <%= ENV["STRIPE_TEST_SECRET_KEY"] %>
stripe_version: <%= ENV["STRIPE_VERSION"] %>
stripe_webhook_secret: <%= ENV["STRIPE_WEBHOOK_SECRET"] %>
stripe_webhook_signing_secret: <%= ENV["STRIPE_WEBHOOK_SIGNING_SECRET"] %>
and those variables are in your environment variables, which are never shared.
Hope that helps
kathyonu
@kathyonu
gem 'stripe-ruby-mock', '~> 3.0', '>= 3.0.1' , :require => 'stripe_mock'
Also, I always read the Documentation link. If there isn't one, I read the Home Page.
Nachiket
@nachiketp87_twitter
Hello, would it be possible to back port commit: stripe-ruby-mock/stripe-ruby-mock@5cdbf6f to version 2.5 to fix Ruby 2.7 kwargs warnings?