Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    alansaid
    @alansaid
    Hi all!
    Alessandro Suglia
    @aleSuglia
    Hello :)
    alansaid
    @alansaid
    Hi @aleSuglia, I’m not sue I understand your comment on issue 122. Even though travis might not fail due to javadoc errors, mvn install should. This is a decision made in order to guarantee that JavaDocs stay up to date
    Alessandro Suglia
    @aleSuglia
    I would do the same check in order to prevent to have missing or invalid documentation.
    alansaid
    @alansaid
    alright
    Alessandro Suglia
    @aleSuglia
    As I said before, the last time I tried to contribute I have found invalid references in JavaDoc.
    You are right. I have not explained it very well in my issue. Sorry about that!
    Alejandro
    @abellogin
    Hi all
    There is a plugin (checkstyle) that shows these errors and others related to the code style
    So far, we only run it before a release
    So, although it is not an ideal situation, it is possible to have incomplete or incorrect JavaDoc comments before a release
    Alessandro Suglia
    @aleSuglia
    Thank you @abellogin! What do you usually do when you test your code before a commit? I usually do mvn install on my local version in order to check if the code is ok. Is it wrong? Sorry for the dumb question :/
    alansaid
    @alansaid
    [Alan said, recommenders] @aleSuglia: mvn install is what I do before I commit anything
    Alessandro Suglia
    @aleSuglia

    @alansaid: Thank you for you answer.

    Even though travis might not fail due to javadoc errors, mvn install should. This is a decision made in order to guarantee that JavaDocs stay up to date

    I have this doubt simply because I think that if someone which contributes to the RiVal project doesn't use mvn install, he may introduce some JavaDoc errors . In my opinion can be useful to execute the same command on Travis too in order to prevent this kind of errors. What do you think about that? Am I saying something wrong?

    alansaid
    @alansaid
    [Alan said, recommenders] Given that rival is a Maven project, I can't see how anyone see if their changes/additions compile without executing the default build command, i.e. mvn install . But sure, I get the point. I'll look into the Travis build. Nevertheless, I would not recommend checking anything in before having built the project locally
    Alessandro Suglia
    @aleSuglia
    @alansaid Sure you're absolutely right. Last time I've done a mistake and I've only tested the module that I've modified. I'll surely consider your tips. Thank you @alansaid for your availability :)
    alansaid
    @alansaid
    No problem, thanks for contributing :smile:
    Alessandro Suglia
    @aleSuglia
    I'm happy to be part of the contributors and I hope to continue to introduce useful features to the RiVal project
    alansaid
    @alansaid
    :+1: