Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Douglas Wade
@doug-wade
hey @aickin you around? we’re hacking on react-server today and I’m having some troubles with react-server-cli and less compilation
Perry Shuman
@Noirbot
Are we particularly attached to running ESLint via Gulp?
Douglas Wade
@doug-wade
personally? no. @aickin and @gigabo might have different opinions, however
Perry Shuman
@Noirbot
It seems like it obfuscates the results some
Judging by the fact that no one noticed that last set of failures
Douglas Wade
@doug-wade
The best way I know to make errors easier with gulp is to add gulp-plumber to every stream
gulp 4 has much better error handling, iiuc gulpjs/gulp#359
we could probably switch to the beta now — we’re using the lerna beta
Perry Shuman
@Noirbot
I mean, if it's not effecting other Gulp tasks, it may just be easier to pull linting out
but I'm biased
Douglas Wade
@doug-wade
I think we want to chain linting with other tasks
i.e. to run linting when you run gulp
as much as I prefer npm scripts, I definitely don’t want a half gulp/half npm script solution
Perry Shuman
@Noirbot
Though, in order to have a lerna lint, we need to have an npm run lint on each package, right?
Douglas Wade
@doug-wade
yes
definitely yes
Perry Shuman
@Noirbot
So, we're either wrapping Gulp in NPM or NPM in Gulp :P
Douglas Wade
@doug-wade
yeah — a solution that’s 100% npm scripts and 100% gulp
the difference is slight, I recognize
but if you’re expecting to use gulp, it just does the right thing
and if you’re expecting to use npm scripts, it just does the right thing
Perry Shuman
@Noirbot
I mean, I'm fine setting up both
I just didn't want to step on any toes
Douglas Wade
@doug-wade
Its well appreciated :smile:
Perry Shuman
@Noirbot
The only worry I see there is that we'll now have some of the eslint setup in 2 places
Bo Borgerson
@gigabo
Huh what?
eslint without gulp?
Great!
gigabo @gigabo wanders away.
Douglas Wade
@doug-wade
@doug-wade The .eslintrc doesn't specify which files to lint though
That's hardcoded in the Gulp config
gulp.task("eslint", [], function() {
    var srcMinusTest = src.concat([
        "!core/**/__tests__/**/*",
        "!**/*.json",
    ]);
    return gulp.src(srcMinusTest)
        // eslint() attaches the lint output to the eslint property
        // of the file object so it can be used by other modules.
        .pipe(eslint())
        // eslint.format() outputs the lint results to the console.
        // Alternatively use eslint.formatEach() (see Docs).
        .pipe(eslint.format())
        // To have the process exit with an error code (1) on
        // lint error, return the stream and pipe to failOnError last.
        .pipe(eslint.failAfterError());
});
So if we want to maintain eslint as a Gulp task, we may have to factor that out?
Perry Shuman
@Noirbot
The test failures on the Yeoman Generator may be the least helpful test failures I can imagine
# generator-react-server:app passes the test target
not ok 3 -
  t.true((await runsSuccessfully('npm test', testDir)))
                                             |
                                             "/var/folders/x9/xyvq223n2_j5v13tky4p64kc0000gn/T/2706ceb6676a8a3c0c9a4a1e5c88afd3f09a359e"
:|
So this test failed because it failed to run the tests on a set of scripts it generated in a temp folder?
Why is our testing recursive?
Hmm
ERR: Failed to load page at "../pages/hello-world" ReferenceError: __LOGGER__ is not defined
Carl Welch
@carlwelchdesign

I'm using the Bike-share example as a starting point. This package is using routr. my urls/routes look like this http://mysite.com/articles/this-is-the-article - I have my route set up like so:
Article: {
path: ['/article/:slug'],
method: 'get',
page: './pages/article'
}...

How do I get access to ":slug"?
this.slug, this.params.slug are undefined... can someone point me in the right direction? Thanks!

This message was deleted
For the url http://localhost:3010/source/docs-api.html and the given route, this.getRequest().getRouteParams().path returns "docs-api.html"
Carl Welch
@carlwelchdesign
Thanks!!
Douglas Wade
@doug-wade
@Noirbot this just came across my desk https://github.com/sindresorhus/pokemon thought it might make your poke site a little easier than checking in your data
Bo Borgerson
@gigabo
Hi everyone. We're moving React Server chat to Slack. Please join us there! https://slack.react-server.io/