These are chat archives for redfin/react-server

18th
Jul 2016
Douglas Wade
@doug-wade
Jul 18 2016 16:19

Also, turns out Hot Reloading doesn't really work too nicely with inline styling

What Bad Things :tm: happen?

Perry Shuman
@Noirbot
Jul 18 2016 16:20
It just doesn't actually hot-reload
I have to hard restart
I haven't worked out exactly which changes reload cleanly
Douglas Wade
@doug-wade
Jul 18 2016 16:25
that’s… strange
I :sheep: haven’t really much styling in my apps
I’ll poke at it later this evening
Glad you got everything up and running tho
Perry Shuman
@Noirbot
Jul 18 2016 16:27
Thanks!
Actually, somewhat unrelated to React-Server
I'm having issues now that I have a Search implemented
Where, it's fast to filter from ~900 entries down to 10-50
Douglas Wade
@doug-wade
Jul 18 2016 16:28
That npm ui thing is weird — I wonder if its caused by the readme bug
Perry Shuman
@Noirbot
Jul 18 2016 16:28
But when you remove the search it lags for a second when it has to re-render all the rest
Any idea how to deal with that?
Douglas Wade
@doug-wade
Jul 18 2016 16:28
lerna/lerna#64
k, so the problem is: you have all the pokes in memory, and you’ve filtered them, but now you unfilter them, and the render time is high?
Because there are so many elements to render?
Perry Shuman
@Noirbot
Jul 18 2016 16:29
Yea
It's rendering most of them off-screen
but that still takes time
Is there any way to tell react "Stop showing this, but I may need it back here in a bit"
I guess I could try filtering by just rending them with display: none
Not sure if that' faster
Douglas Wade
@doug-wade
Jul 18 2016 16:43
Maybe? I think you could find that out by looking at the performance graph of your app in the chrome dev tools
if you’re spending all your time in paint, then that won’t help
Perry Shuman
@Noirbot
Jul 18 2016 16:43
ah, I'm not very familiar with that
I'll give it a look
Douglas Wade
@doug-wade
Jul 18 2016 16:43
if its time spent calculating the elements, then it would
Perry Shuman
@Noirbot
Jul 18 2016 20:36
How does that work with Server-Render?
If I delete a server-rendered element, does it have to re-pull it from Server?
Douglas Wade
@doug-wade
Jul 18 2016 23:10
no it gets rendered in the client
Perry Shuman
@Noirbot
Jul 18 2016 23:13
Ah, ok
Douglas Wade
@doug-wade
Jul 18 2016 23:18
oh also i just had a thought about your rendering thing
You should use <TheFold />
Perry Shuman
@Noirbot
Jul 18 2016 23:18
Ooo, interesting
Btw, I'll be up in Seattle around Labor Day for PAX
I'd love to grab lunch or something
Douglas Wade
@doug-wade
Jul 18 2016 23:19
I’ll be in town
let’s schedule something: doug.wade@redfin.com
Perry Shuman
@Noirbot
Jul 18 2016 23:20
awesome, I'll work out when I'm free and let you know