Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Navneet Gupta
    @navneet-g
    not published a new version yet
    do you want me to?
    I was thinking about publishing it with any other significant changes
    Alex Bettadapur
    @abettadapur
    i don't care right now, just cleaning up our issues and saw that one
    let's do it then when we bump to v4 and remove the rr v6 dependency
    Navneet Gupta
    @navneet-g
    Yes
    Alex Bettadapur
    @abettadapur
    we could also publish rdm-legacy for v5 support, but I am okay with just the major version
    Alex Bettadapur
    @abettadapur
    @navneet-g I will fix #76 and we should publish soon
    It might even cause perf issues with RR6, but I havent verified that
    Alex Bettadapur
    @abettadapur
    When you have time, can you review #77 ?
    I fixed #76 and also removed support for react-redux@5, because the DML component was getting pretty complicated
    Navneet Gupta
    @navneet-g
    Thanks alex ... did you verify the scenario where the children rendered via DML do not get latest state from the store?
    Alex Bettadapur
    @abettadapur
    I did, everything seems to continue to work
    sorry for the delay, i'll try to complete this this weekend
    Navneet Gupta
    @navneet-g
    no worries ... thanks
    Alex Bettadapur
    @abettadapur
    Addressed your comments, I tested all the examples and they work as expected
    Navneet Gupta
    @navneet-g
    Great ... let me take a look at the PR again
    Navneet Gupta
    @navneet-g

    I have a PR out to support "retained" modules, e.g. the modules that are retained in the store after the componets are unmounted ... can someone take a look?

    microsoft/redux-dynamic-modules#89

    Navneet Gupta
    @navneet-g
    @abettadapur please give me permissions on the react package so I can publish new version
    Alex Bettadapur
    @abettadapur
    sorry, added you
    Alex Bettadapur
    @abettadapur
    @navneet-g Could you review this? It fixes a long standing request
    #90
    Navneet Gupta
    @navneet-g
    Sure ... I am OOF today, I will check in sometime
    Alex Bettadapur
    @abettadapur
    ok
    thanks
    Navneet Gupta
    @navneet-g
    We should call it customCombineReducer
    that way it is absolutely clear
    or advanceCombineReducer also works
    Alex Bettadapur
    @abettadapur
    sure
    Navneet Gupta
    @navneet-g
    We are at 360 stars now :)
    slowly growing
    Alex Bettadapur
    @abettadapur
    :)
    i can have my coworkers star it if you want lol
    Navneet Gupta
    @navneet-g
    no cheating :D
    but if they like it they should star it to show the support
    Alexander Droste
    @progmem64

    Is there a reason that you use functions to create the module "descriptors"?

    // module.js
    export function createModule() {
        return {
            id: "x"
            // ...
        }
    }
    
    // component.js
    render() {
        return (
            <DynamicModuleLoader reduxModules={createModule()} />
        );
    }

    Is it ok to use it like this?

    // module.js
    export const moduleX = {
        id: "x"        // ...
    }
    
    // component.js
    render() {
        return (
            <DynamicModuleLoader reduxModules={moduleX} />
        );
    }
    Navneet Gupta
    @navneet-g
    That was old convention we followed ... it is required if a module needs parameter for initialization, specially for initial or final actions
    defining a const is good for most of the scenarios
    Alexander Droste
    @progmem64
    Thank you!
    Alexander Droste
    @progmem64

    I've got another question.
    I create a store like this

        createStore({
            initialState: {},
            enhancers: [applyMiddleware(createLogger(/* ... */))],
            extensions: [getSagaExtension()]
        },

    How do I apply the logger middleware AFTER the saga middleware? At the moment I am missing every action dispatched inside a saga.

    Konstantin Bochinin
    @Konstantin6487
    same question :point_up_2: @abettadapur
    Edward Mulraney
    @edmulraney
    hey guys am I right in saying that if you want to use thunks in your app with this library, you need a special extension redux-dynamic-modules-thunk ?
    which means - if you want any extension you need to write a customer extension for redux-dynamic-modules ??
    Jeevananandan J
    @jeevasusej
    Hey guys, I need a help
    I am using
    connected-react-router.
    when I am creating a root store, I am trying to do like the follow.
    But I am getting syntax issue.
    const store: IModuleStore<any> = createStore({
    enhancers: [routerMiddleware(history)],
    extensions: [getSagaExtension()],
    });

    and I need to add connectRouter(history) as a reducer based on their documentation. But I don't know where to add those
    https://github.com/supasate/connected-react-router
    could anyone please help on this?
    jyoti857
    @jyoti857

    Hi Guys,
    While passing an action I get this below error,

    ```Error: Actions may not have an undefined "type" property. Have you misspelled a constant?

    Object.performAction
    index.bundle?platform=ios&dev=true&minify=false:1:38756
    h
    index.bundle?platform=ios&dev=true&minify=false:1:40489
    dispatch
    index.bundle?platform=ios&dev=true&minify=false:1:44190

    <anonymous>
    index.js:18:60```

    I created a createStore from 'redux-dynamic-modules', I think my action does not reach to the Saga

    Alexandr Sivtsov
    @aolSvt_twitter
    Hello, i have a problem with DynamicModuleLoader when my component is rerendered...i loose all props, also i can't reregister module
    Seongjun Kim
    @intelcoder
    Is there any workaround for hot reload with redux-dynamic-modules ?