These are chat archives for relekang/django-nopassword

26th
May 2015
Jon Smajda
@smajda
May 26 2015 16:57
Oh hey, let's try this thing out. :) What about a refactor of the various NOPASSWORD_ settings to a single NOPASSWORD dictionary? (Guess who's updating his TEMPLATE_ settings for 1.8 now... )
Rolf Erik Lekang
@relekang
May 26 2015 18:01
Interesting idea :)
What is the benefit? Just curious :)
Jon Smajda
@smajda
May 26 2015 20:01

Well, it's arguably cleaner than having a bunch of random NOPASSWORD_ settings. It's also slightly cleaner in your code to do "settings.NOPASSWORD.get('foo')" vs having to defensively use getattr on settings all the time in case a setting is not set.

I'm certainly not passionate enough about this to really argue intensely for it. :)

Rolf Erik Lekang
@relekang
May 26 2015 20:26
Sounds good to me
I don't have much time these days as my master thesis is due in about two weeks
I'm sorry that I haven't reviewed your PR
Jon Smajda
@smajda
May 26 2015 20:30
No need to apologize! Focus on the thesis!
Rolf Erik Lekang
@relekang
May 26 2015 20:33
I have time to review in the evenings :D I just clicked the notification and forgot to go back later
I looked at it now :+1:
Jon Smajda
@smajda
May 26 2015 20:34
Haha, I do the same thing with notifications. Then I accidentally click on it and Uh-oh, you can't get the notification back. Mark as unread! Mark as unread!
Awww, missed the PEP8 error b/c I closed the little Frigg window once I saw all the py27 tests passed :)
Rolf Erik Lekang
@relekang
May 26 2015 20:40
Ah, maybe it would be good to move flake8 first
Jon Smajda
@smajda
May 26 2015 20:42
Well, all Python devs should really just have a pep8 linter plugin installed in their editor. I do, of course...but I turn off the silly long line warnings so I miss them sometimes. :)
Rolf Erik Lekang
@relekang
May 26 2015 20:43
Yeah, they are easy to miss in pycharm with the check on anyways :p
Rolf Erik Lekang
@relekang
May 26 2015 20:53
I think it's ready for 2.0.0
Jon Smajda
@smajda
May 26 2015 20:54
hurray!