(Disclaimer, I wrote the thing.... lol)
It's got solid test coverage, we just haven't had the need for regex-based routes. /cc @rkstedman
@moszeed I ended up writing my own little helper function - https://gist.github.com/rkstedman/1a66fb733cd9c48fb43b
@mcavage I am using restify for a couple of APIs, each of which will expose an endpoint then pipe the request through a series of middlewares, some decorate the request for later stages in the pipeline, others decorate the response. I'm not particularly happy about the way I'm arbitrarily adding to the response, but I can't think of a better way to do this. I am also using the on('after') callback to actually return the response, because I always have the ready-built response by the end of the pipeline.
@barisbalic Have you looked at "formatters" to decorate the response? http://mcavage.me/node-restify/#content-negotiation
(unless I am missing something obvious)
the returned request stream should be used with
pipe
hey guys, I use the audit plugin in my app. I noticed recently that there are several log entries without a
remoteAddress set. Why would that be? From the little snooping of the code that I did, I saw that the audit plugin uses req.connection.remoteAddress - should I manually patch it and use the request-ip module instead?
Is there some setting in the rectify client to reuse the same connection or to close the connection?
@avimar i’m using supertest and tape for functional testing. I’m new to both. I’m running into an issue where the test script will not complete. The actual test runs, but the test script does not conclude. Could restify be holding a connection open?
The Test:
var supertest = require('supertest');
var test = require('tape');
var app = require('../app');
var request = supertest.agent('http://localhost:8080');
test('that fantasy player predictions are returned', function(t){
'use strict';
request
.get(‘/users')
.expect(200)
.expect('Content-type',/json/)
.expect('Content-Encoding', 'gzip')
.end(function(err, res){
t.equal(2 + 3, 5);
t.error(err, 'No error');
t.end(err);
});
});You can see the tests are evaluating, but then the test stoip and i have to control+c out of the script. Any thoughts?
The output:
ubuntu@ip-123-34-56-567:~/apps/sapiv0$ npm test
> sapi@1.0.0 test /home/ubuntu/apps/sapiv0
> node test | tap-spec
SAPI listening at http://0.0.0.0:8080
that fantasy player predictions are returned
✔ should be equal
✔ No error
I'd like to take a URL pathname and match it to an existing restify route handler and get the params from it. basically URL path matching.
Inputs:
/some/random/value
server.get('/some/random/:path', function() { / / });
Output:
{path: 'value'}
Maybe via some method I don't know that works like:
server.router.match('/some/random/value')
hmm. now scrolling up there could be an answer(?) :)