Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 20 05:17
    mikyk10 opened #1519
  • Nov 03 10:54
    r32rf closed #1517
  • Nov 03 10:54
    r32rf commented #1517
  • Oct 23 12:53
    ptman opened #1518
  • Oct 22 23:26
    notzippy commented #1517
  • Oct 22 14:22
    r32rf commented #1517
  • Oct 22 14:17
    r32rf opened #1517
  • Oct 20 13:31

    notzippy on develop

    Fix misspellings and some lint … Merge pull request #1514 from p… (compare)

  • Oct 20 13:31
    notzippy closed #1514
  • Oct 17 18:44

    notzippy on develop

    Removed go 1.12 added go 1.15 (compare)

  • Oct 17 18:34
    notzippy review_requested #1514
  • Oct 15 06:28
    teitei-tk commented #1516
  • Oct 14 12:27
    Laur1nMartins commented #1516
  • Oct 14 11:53
    teitei-tk opened #1516
  • Oct 13 00:31
    brendensoares commented #1514
  • Oct 10 13:10
    Laur1nMartins opened #1515
  • Oct 07 09:48
    teitei-tk commented #1513
  • Oct 03 06:47
    alexyalinc closed #1493
  • Oct 02 18:30
    pushrax closed #554
  • Oct 02 07:46
    ptman edited #1514
matrixbot
@matrixbot
Paul certainly better than gometalinter
matrixbot
@matrixbot
Paul I have more ideas for cleanups, but didn't want to do huge PRs
Paul there are big enough
Paul *these
Brenden Soares
@brendensoares
ya a couple of them are pretty big :)
Pierre Gourlaouen
@gourlaa
Hello !
I didn't find a way to do a revel build with flags. Like : "go build -ldflags '-linkmode=external' GoMinimal.go"
Do you have a solution ?
matrixbot
@matrixbot
Paul pierre, I've resorted to hacking revel sources
Paul notzippy, what do you think about the PRs?
Laur1nMartins
@Laur1nMartins
According to this you can use -X to append build flags
Pierre Gourlaouen
@gourlaa
Yes ! We tried every options and didnt success
Steve
@notzippy
@gourlaa if you run the Revel cli with a -v it should show you the compiler command
matrixbot
@matrixbot
Paul @notzippy, any comment on the PRs? they are long, but mostly mechanical lint fixes
Steve
@notzippy
They look good, I was trying to fix the travis issues
matrixbot
@matrixbot
Paul oh, great
Paul any clue what they are about?
Steve
@notzippy
One was go 1.12 doesnt support samesite. We already said we only support go 1.13 and newer so that was easy
the other issue has been ongoing with the gocache library and how it misses keys
cache_test.go:241: Error getting str: revel/cache: key not found /
The cache is eventually consistent, so thinking of just pulling this test due to reasons
Steve
@notzippy
What about a lint against revel/cmd ?
matrixbot
@matrixbot
Paul sure, I'll take a look at revel/cmd and revel/modules
matrixbot
@matrixbot
Paul notzippy, revel/cmd#199
1 reply
matrixbot
@matrixbot
Paul notzippy, thanks!
Steve
@notzippy
If you have time to do the revel/modules as well that would be great
matrixbot
@matrixbot
Paul I will
matrixbot
@matrixbot
Paul notzippy, revel/modules#105
matrixbot
@matrixbot
Paul notzippy, was there something you wanted with the last PR?
Steve
@notzippy
I just merged in a PR that was on the examples already which caused a conflict, I had resolved it.
GeorgeXc
@GeorgeXc

tried to add code below into the file app/init.go: func init()

revel.AddHTTPMux("/this/is", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
        fmt.Fprintln(w, "Hi there, shorter prefix", r.URL.Path)
        w.WriteHeader(200)
    }))

but when run revel run -a appName meet an error

the error list below
revel run -m prod -a r1app
Revel executing: run a Revel application
Parsing packages, (may require download if not cached)... Completed
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x14a52fd]

goroutine 1 [running]:
github.com/revel/revel.AddHTTPMux(...)
        /Users/byc/go/pkg/mod/github.com/revel/revel@v1.0.0/server-engine.go:162
r1app/app.init.0()
        /Users/byc/code/revelprojs/r1app/app/init.go:54 +0x15d
CRIT  11:52:31 revel_logger.go:59: Error running:                            error="exit status 2"
GeorgeXc
@GeorgeXc
Thanks
matrixbot
@matrixbot
Paul notzippy, thanks, I made a new PR =)
Steven Hughes
@alas-plus
Heya all, so I asked this question on stack overflow about running a revel app on GCP. I'm new to both, So I wasn't sure where I was going wrong. Looking into it I think my problem is the engine listening on port X. My Cloud Run App had one port open specifically so it was unable to start the engine. So i guess my questions are 2:
1) Is it not a good idea to run using the revel cmd in "prod"
2) Is there a way to configure which port the engine runs on
Steven Hughes
@alas-plus

Well I managed to get it to work by building the app instead and running it that way. I think the only advantage of run is hot swap, which I don't need when deployed.

I also wonder, has an official docker image been considered? I see some that are years old, but having one that was in CI/CD and such would be nice. Would save me from go getting revel every build :laughing:

matrixbot
@matrixbot
Paul everyone needs a slightly different docker image
Paul why not make your own?
matrixbot
@matrixbot
Paul Steven Hughes (Gitter): if you found a solution, you should submit an answer
Steve
@notzippy
Docker has been considered, for a production built image it would likely be best to have a two stage image, but for development that is unnecessary. Right now we are doing some housecleaning. But that item is on the radar
matrixbot
@matrixbot
Paul notzippy, I made another PR
Garrett Flanders
@flanyanero
I would like to use revel to implement subdomain level routing. Does anyone know of an example or how to do that?
matrixbot
@matrixbot
Paul You'll probably have to do it yourself based on the host header
Steve
@notzippy
@flanyanero I had been looking at that as well for some time, you could implement this by creating or extending the server engine https://revel.github.io/manual/server-engine.html
matrixbot
@matrixbot
Paul notzippy, brendensoares, thanks for helping me with the hacktoberfest PRs, got the required amount to claim a planted tree (random "free" t-shirts are probably a climate negative)
Steve
@notzippy
Nice