Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Mar 07 14:32
    Zykatious closed #1530
  • Mar 07 14:32
    Zykatious commented #1530
  • Mar 07 01:26
    Zykatious edited #1530
  • Mar 07 01:26
    Zykatious opened #1530
  • Mar 06 18:16
    notzippy commented #1528
  • Mar 06 00:29
    meagar commented #1528
  • Mar 04 10:36
    notzippy reopened #1528
  • Mar 04 10:36
    notzippy commented #1528
  • Feb 27 01:39
    extems closed #1528
  • Feb 27 01:39
    extems commented #1528
  • Feb 26 05:25
    ptman commented #1524
  • Feb 26 05:24
    ptman synchronize #1524
  • Feb 26 02:22
    notzippy synchronize #1529
  • Feb 26 02:14
    notzippy opened #1529
  • Feb 26 01:46
    notzippy commented #1524
  • Feb 26 01:43
    notzippy commented #1528
  • Feb 26 01:37
    notzippy commented #1528
  • Feb 25 15:08
    extems edited #1528
  • Feb 25 15:05
    extems edited #1528
  • Feb 25 15:04
    extems opened #1528
RCdawson21
@RCdawson21
Its part of the initializing of firebase. I think it might be because if you are using google app engine, its supposed to be able to figure out what that means, but sure how to set up it or integrate that into the revel framework
matrixbot
@matrixbot
Paul that seems to include lintes 3-6
RCdawson21
@RCdawson21
sorry.
matrixbot
@matrixbot
Paul where the error refers to init.go line 22
RCdawson21
@RCdawson21
Yea I changed the file, its the same problem though.
matrixbot
@matrixbot
Paul there's no projectID
Paul does the compiler give the same error after the change?
RCdawson21
@RCdawson21
it is now " error="Go Compilation Error (in /Users/r.c.dawson/Desktop/Webdevelopment/BEAwebsite/beauser/app/init.go:3): expected declaration, found app"
matrixbot
@matrixbot
Paul these are go errors, not revel
Paul have you programmed go before?
Paul I suggest going through some tutorial
RCdawson21
@RCdawson21
a little, and yea I think so too.
Laur1nMartins
@Laur1nMartins
Following the https://revel.github.io/tutorial/gettingstarted.html leads to a stackoverflow on routes.go:573 because one needs to download github.com/revel/modules because testrunner is included in the default routes file. That should either be fixed or added in the getting started page!
It was tested on a fresh Ubuntu VM and a fresh mint 19.3 VM as well. Both completly new boots and with the newest version of go (1.15.2)
matrixbot
@matrixbot
Paul laur1nmartins, a issue on github, please
Paul unless there already is one
Laur1nMartins
@Laur1nMartins
Didnt think of that. Will do.
opened an issue
Steve
@notzippy
Woot, thanks Nick
matrixbot
@matrixbot
Paul revel/cron#5
Paul revel/examples#62
Paul revel/revel#1514
Brenden Soares
@brendensoares
Paul, I replied to those issues
what linter are you using?
matrixbot
@matrixbot
Paul golangci-lint
Paul it seems to be the gold standard currently
Paul certainly better than gometalinter
matrixbot
@matrixbot
Paul I have more ideas for cleanups, but didn't want to do huge PRs
Paul there are big enough
Paul *these
Brenden Soares
@brendensoares
ya a couple of them are pretty big :)
Pierre Gourlaouen
@gourlaa
Hello !
I didn't find a way to do a revel build with flags. Like : "go build -ldflags '-linkmode=external' GoMinimal.go"
Do you have a solution ?
matrixbot
@matrixbot
Paul pierre, I've resorted to hacking revel sources
Paul notzippy, what do you think about the PRs?
Laur1nMartins
@Laur1nMartins
https://revel.github.io/manual/tool.html
According to this you can use -X to append build flags
Pierre Gourlaouen
@gourlaa
Yes ! We tried every options and didnt success
Steve
@notzippy
@gourlaa if you run the Revel cli with a -v it should show you the compiler command
matrixbot
@matrixbot
Paul @notzippy, any comment on the PRs? they are long, but mostly mechanical lint fixes
Steve
@notzippy
They look good, I was trying to fix the travis issues
matrixbot
@matrixbot
Paul oh, great
Paul any clue what they are about?
Steve
@notzippy
One was go 1.12 doesnt support samesite. We already said we only support go 1.13 and newer so that was easy
the other issue has been ongoing with the gocache library and how it misses keys
cache_test.go:241: Error getting str: revel/cache: key not found /
The cache is eventually consistent, so thinking of just pulling this test due to reasons
Steve
@notzippy
What about a lint against revel/cmd ?
matrixbot
@matrixbot
Paul sure, I'll take a look at revel/cmd and revel/modules
matrixbot
@matrixbot
Paul notzippy, revel/cmd#199
1 reply