revel/community

Revel v1.0.0 is out

matrixbot

@matrixbot

Paul have you programmed go before?

Paul I suggest going through some tutorial

RCdawson21

@RCdawson21

a little, and yea I think so too.

Laur1nMartins

@Laur1nMartins

Following the https://revel.github.io/tutorial/gettingstarted.html leads to a stackoverflow on routes.go:573 because one needs to download github.com/revel/modules because testrunner is included in the default routes file. That should either be fixed or added in the getting started page!

It was tested on a fresh Ubuntu VM and a fresh mint 19.3 VM as well. Both completly new boots and with the newest version of go (1.15.2)

matrixbot

@matrixbot

Paul laur1nmartins, a issue on github, please

Paul unless there already is one

Laur1nMartins

@Laur1nMartins

Didnt think of that. Will do.

opened an issue

Steve

@notzippy

Woot, thanks Nick

matrixbot

@matrixbot

Paul revel/cron#5

Paul revel/examples#62

Paul revel/revel#1514

Brenden Soares

@brendensoares

Paul, I replied to those issues

what linter are you using?

matrixbot

@matrixbot

Paul golangci-lint

Paul it seems to be the gold standard currently

Paul certainly better than gometalinter

matrixbot

@matrixbot

Paul I have more ideas for cleanups, but didn't want to do huge PRs

Paul there are big enough

Paul *these

Brenden Soares

@brendensoares

ya a couple of them are pretty big :)

Pierre Gourlaouen

@gourlaa

Hello !
I didn't find a way to do a revel build with flags. Like : "go build -ldflags '-linkmode=external' GoMinimal.go"

Do you have a solution ?

matrixbot

@matrixbot

Paul pierre, I've resorted to hacking revel sources

Paul notzippy, what do you think about the PRs?

Laur1nMartins

@Laur1nMartins

https://revel.github.io/manual/tool.html

According to this you can use -X to append build flags

Pierre Gourlaouen

@gourlaa

Yes ! We tried every options and didnt success

Steve

@notzippy

@gourlaa if you run the Revel cli with a -v it should show you the compiler command

matrixbot

@matrixbot

Paul @notzippy, any comment on the PRs? they are long, but mostly mechanical lint fixes

Steve

@notzippy

They look good, I was trying to fix the travis issues

matrixbot

@matrixbot

Paul oh, great

Paul any clue what they are about?

Steve

@notzippy

One was go 1.12 doesnt support samesite. We already said we only support go 1.13 and newer so that was easy

the other issue has been ongoing with the gocache library and how it misses keys

cache_test.go:241: Error getting str: revel/cache: key not found /

The cache is eventually consistent, so thinking of just pulling this test due to reasons

Steve

@notzippy

What about a lint against revel/cmd ?

matrixbot

@matrixbot

Paul sure, I'll take a look at revel/cmd and revel/modules

matrixbot

@matrixbot

Paul notzippy, revel/cmd#199

1 reply

matrixbot

@matrixbot

Paul notzippy, thanks!

Steve

@notzippy

If you have time to do the revel/modules as well that would be great

matrixbot

@matrixbot

Paul I will

matrixbot

@matrixbot

Paul notzippy, revel/modules#105

Paul and revel/examples#62

matrixbot

@matrixbot

Paul notzippy, was there something you wanted with the last PR?

Steve

@notzippy

I just merged in a PR that was on the examples already which caused a conflict, I had resolved it.

GeorgeXc

@GeorgeXc

tried to add code below into the file app/init.go: func init()

revel.AddHTTPMux("/this/is", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
        fmt.Fprintln(w, "Hi there, shorter prefix", r.URL.Path)
        w.WriteHeader(200)
    }))

but when run revel run -a appName meet an error

the error list below

revel run -m prod -a r1app
Revel executing: run a Revel application
Parsing packages, (may require download if not cached)... Completed
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x14a52fd]

goroutine 1 [running]:
github.com/revel/revel.AddHTTPMux(...)
        /Users/byc/go/pkg/mod/github.com/revel/revel@v1.0.0/server-engine.go:162
r1app/app.init.0()
        /Users/byc/code/revelprojs/r1app/app/init.go:54 +0x15d
CRIT  11:52:31 revel_logger.go:59: Error running:                            error="exit status 2"

Where communities thrive

People

Repo info

Activity