brendensoares on develop
More lint fixes and dead code r… Merge pull request #1518 from p… (compare)
Paulit seems to be the gold standard currently
Paulcertainly better than gometalinter
Paulthere are big enough
Paulnotzippy, what do you think about the PRs?
Paulany clue what they are about?
cache_test.go:241: Error getting str: revel/cache: key not found /
revel run -m prod -a r1app Revel executing: run a Revel application Parsing packages, (may require download if not cached)... Completed panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x14a52fd] goroutine 1 [running]: github.com/revel/revel.AddHTTPMux(...) /Usersfirstname.lastname@example.org/server-engine.go:162 r1app/app.init.0() /Users/byc/code/revelprojs/r1app/app/init.go:54 +0x15d CRIT 11:52:31 revel_logger.go:59: Error running: error="exit status 2"
Well I managed to get it to work by building the app instead and running it that way. I think the only advantage of run is hot swap, which I don't need when deployed.
I also wonder, has an official docker image been considered? I see some that are years old, but having one that was in CI/CD and such would be nice. Would save me from go getting revel every build :laughing:
Paulwhy not make your own?