These are chat archives for rgladwell/m2e-android

25th
Jun 2015
Fred Bricon
@fbricon
Jun 25 2015 16:32
@WonderCsabo do you have a simple project to test m2e support?
Csaba Kozák
@WonderCsabo
Jun 25 2015 16:33
@fbricon not at hand, but i think we created a skeleton project with @rgladwell when testing the CI
Ricardo Gladwell
@rgladwell
Jun 25 2015 16:33
@fbricon do you mean a test android project to verify m2e-android or a test m2e extension?
Csaba Kozák
@WonderCsabo
Jun 25 2015 16:34
@rgladwell good question, i interpreted as a skeleton m2e connector
Fred Bricon
@fbricon
Jun 25 2015 16:34
test android project to verify m2e-android
Csaba Kozák
@WonderCsabo
Jun 25 2015 16:34
then i interpreted incorrectly
@fbricon check out the test projects in the projects folder under the test module
Fred Bricon
@fbricon
Jun 25 2015 16:35
i got the target platform resolving, android sdk installing a shitload of crap
Csaba Kozák
@WonderCsabo
Jun 25 2015 16:35
BTW, you could just call mvn verify, if our processor is not called, you will get 70+ failures
@fbricon you do not have to install everything of Android SDK, just the components you can find in the travis.sh script
Fred Bricon
@fbricon
Jun 25 2015 16:36
Downloading SDK Platform Android 1.1, API 2, revision 1 (Obsolete)
Csaba Kozák
@WonderCsabo
Jun 25 2015 16:36
@fbricon that is not needed
Fred Bricon
@fbricon
Jun 25 2015 16:36
I'll let it finish
Csaba Kozák
@WonderCsabo
Jun 25 2015 16:37
okay, but you could filter it to reduce the shitload :) https://github.com/rgladwell/m2e-android/blob/master/travis.sh#L17
Ricardo Gladwell
@rgladwell
Jun 25 2015 16:37
we should probably update the README so you don’t have to install everything
Fred Bricon
@fbricon
Jun 25 2015 16:37
shit android filled my disk
damn it
Csaba Kozák
@WonderCsabo
Jun 25 2015 16:38
small Mac SSD?
Fred Bricon
@fbricon
Jun 25 2015 16:38
256GB
Csaba Kozák
@WonderCsabo
Jun 25 2015 16:38
... or much data :)
Fred Bricon
@fbricon
Jun 25 2015 16:39
I think I had like 40GB left before today
now 1.1
Csaba Kozák
@WonderCsabo
Jun 25 2015 16:39
well, i do not know what did you do, but the environment for m2e-android does not need 40 gigs
Fred Bricon
@fbricon
Jun 25 2015 16:39
I let android sdk install everything
[INFO] --- properties-maven-plugin:1.0-alpha-2:read-project-properties (default) @ google-play-services ---
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Maven Android SDK Deployer ......................... SUCCESS [ 0.609 s]
[INFO] Repositories ....................................... SUCCESS [ 0.011 s]
[INFO] Google M2Repository ................................ SUCCESS [ 0.306 s]
[INFO] Android M2Repository ............................... SUCCESS [ 0.013 s]
[INFO] Android Extras ..................................... SUCCESS [ 0.086 s]
[INFO] Android Compatibility Extra V4 ..................... SUCCESS [ 0.404 s]
[INFO] Android Compatibility Extra V7 Gridlayout Library .. SUCCESS [ 4.322 s]
[INFO] Android Compatibility Extra V7 AppCompat Library ... SUCCESS [ 2.093 s]
[INFO] Android Compatibility Extra V13 .................... SUCCESS [ 0.778 s]
[INFO] Android Google Play Services Extra ................. FAILURE [ 0.112 s]
[INFO] Android Google Play Licensing Extra ................ SKIPPED
[INFO] Android Extras - Apk Expansion ..................... SKIPPED
[INFO] Android Google Play APK Expansion Extra - ZIP ...... SKIPPED
[INFO] Android Google Play APK Expansion Extra - Downloader SKIPPED
[INFO] Android MultiDex ................................... SKIPPED
[INFO] Android Platforms .................................. SKIPPED
[INFO] Android Platform 2.2 API 8 ......................... SKIPPED
[INFO] Android Platform 2.3.3 API 10 ...................... SKIPPED
[INFO] Android Platform 4.0.3 API 15 ...................... SKIPPED
[INFO] Android Platform 4.1 API 16 ........................ SKIPPED
[INFO] Android Platform 4.2 API 17 ........................ SKIPPED
[INFO] Android Platform 4.3 API 18 ........................ SKIPPED
[INFO] Android Platform 4.4 API 19 ........................ SKIPPED
[INFO] Android Platform 4.4W API 20 ....................... SKIPPED
[INFO] Android Platform 5.0 API 21 ........................ SKIPPED
[INFO] Android Platform 5.1 API 22 ........................ SKIPPED
[INFO] Android Platform MNC API 23 ........................ SKIPPED
[INFO] Android Add-Ons .................................... SKIPPED
[INFO] Android Add-On Google Platform 2.2 API 8 (Maps) .... SKIPPED
[INFO] Android Add-On Google Platform 2.3.3 API 10 (Maps and USB) SKIPPED
[INFO] Android Add-On Google Platform 4.0.3 API 15 (Maps and USB) SKIPPED
[INFO] Android Add-On Google Platform 4.1 API 16 (Maps and USB) SKIPPED
[INFO] Android Add-On Google Platform 4.2 API 17 (Maps and USB) SKIPPED
[INFO] Android Add-On Google Platform 4.3 API 18 (Maps and USB) SKIPPED
[INFO] Android Add-On Google Platform 4.4 API 19 (Maps and USB) SKIPPED
[INFO] Android Add-On Google Platform 5.0 API 21 (Maps and USB) SKIPPED
[INFO] Android Add-On Google Platform 5.1 API 22 (Maps and USB) SKIPPED
[INFO] Google Glass Development Kit (GDK) API 19 .......... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16.188 s
[INFO] Finished at: 2015-06-25T12:41:15-04:00
[INFO] Final Memory: 46M/589M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties (default) on project google-play-services: Properties file not found: /Users/fbricon/Dev/android-sdk-macosx/extras/google/google_play_services/source.properties -> [Help 1]
[ERROR]
running the deployer
Csaba Kozák
@WonderCsabo
Jun 25 2015 16:42
@fbricon you are missing always the filters! ;)
-P 4.3,2.2
Fred Bricon
@fbricon
Jun 25 2015 16:42
right
Ricardo Gladwell
@rgladwell
Jun 25 2015 16:43
you probably couldn’t install all the android dependencies on your laptop
Just run:
echo yes | android update sdk --filter platform-tools,build-tools-21.1.1,android-18,addon-google_apis-google-18,android-10,android-8,addon-google_apis-google-8,extra-android-support,sysimg-16 --no-ui —force
and then:
mvn install -P 4.3,2.2
from the deployer directory
maybe ignore the echo yes | bit in the first command
Fred Bricon
@fbricon
Jun 25 2015 16:45
Error: Argument '—force' is not recognized.
Ricardo Gladwell
@rgladwell
Jun 25 2015 16:46
just ignore the force argument and run: android update sdk --filter platform-tools,build-tools-21.1.1,android-18,addon-google_apis-google-18,android-10,android-8,addon-google_apis-google-8,extra-android-support,sysimg-16 --no-ui
Fred Bricon
@fbricon
Jun 25 2015 16:46
➜ maven-android-sdk-deployer git:(master) /Users/fbricon/Dev/android-sdk-macosx/tools/android update sdk --filter platform-tools,build-tools-21.1.1,android-18,addon-google_apis-google-18,android-10,android-8,addon-google_apis-google-8,extra-android-support,sysimg-16 --no-ui
Refresh Sources:
Fetching https://dl.google.com/android/repository/addons_list-2.xml
Validate XML
Parse XML
Fetched Add-ons List successfully
Refresh Sources
Fetching URL: https://dl.google.com/android/repository/repository-11.xml
Validate XML: https://dl.google.com/android/repository/repository-11.xml
Parse XML: https://dl.google.com/android/repository/repository-11.xml
Fetching URL: https://dl.google.com/android/repository/addon.xml
Validate XML: https://dl.google.com/android/repository/addon.xml
Parse XML: https://dl.google.com/android/repository/addon.xml
Fetching URL: https://dl.google.com/android/repository/addon-6.xml
Validate XML: https://dl.google.com/android/repository/addon-6.xml
Parse XML: https://dl.google.com/android/repository/addon-6.xml
Fetching URL: https://dl-ssl.google.com/glass/gdk/addon.xml
Validate XML: https://dl-ssl.google.com/glass/gdk/addon.xml
Parse XML: https://dl-ssl.google.com/glass/gdk/addon.xml
Fetching URL: https://dl.google.com/android/repository/extras/intel/addon.xml
Validate XML: https://dl.google.com/android/repository/extras/intel/addon.xml
Parse XML: https://dl.google.com/android/repository/extras/intel/addon.xml
Fetching URL: https://dl.google.com/android/repository/sys-img/android/sys-img.xml
Validate XML: https://dl.google.com/android/repository/sys-img/android/sys-img.xml
Parse XML: https://dl.google.com/android/repository/sys-img/android/sys-img.xml
Fetching URL: https://dl.google.com/android/repository/sys-img/android-wear/sys-img.xml
Validate XML: https://dl.google.com/android/repository/sys-img/android-wear/sys-img.xml
Parse XML: https://dl.google.com/android/repository/sys-img/android-wear/sys-img.xml
Fetching URL: https://dl.google.com/android/repository/sys-img/android-tv/sys-img.xml
Validate XML: https://dl.google.com/android/repository/sys-img/android-tv/sys-img.xml
Parse XML: https://dl.google.com/android/repository/sys-img/android-tv/sys-img.xml
Fetching URL: https://dl.google.com/android/repository/sys-img/google_apis/sys-img.xml
Validate XML: https://dl.google.com/android/repository/sys-img/google_apis/sys-img.xml
Parse XML: https://dl.google.com/android/repository/sys-img/google_apis/sys-img.xml
Fetching URL: https://dl.google.com/android/repository/sys-img/x86/addon-x86.xml
Validate XML: https://dl.google.com/android/repository/sys-img/x86/addon-x86.xml
Parse XML: https://dl.google.com/android/repository/sys-img/x86/addon-x86.xml
Error: Ignoring unknown package filter 'platform-tools'
Error: Ignoring unknown package filter 'build-tools-21.1.1'
Error: Ignoring unknown package filter 'android-18'
Error: Ignoring unknown package filter 'addon-google_apis-google-18'
Error: Ignoring unknown package filter 'android-10'
Error: Ignoring unknown package filter 'android-8'
Error: Ignoring unknown package filter 'addon-google_apis-google-8'
Error: Ignoring unknown package filter 'extra-android-support'
Error: Ignoring unknown package filter 'sysimg-16'
Warning: The package filter removed all packages. There is nothing to install.
Please consider trying to update again without a package filter.
but I still get the deployer failing with
[ERROR] Failed to execute goal org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties (default) on project google-apis-8: Properties file not found: /Users/fbricon/Dev/android-sdk-macosx/add-ons/addon-google_apis-google-8/source.properties -> [Help 1]
Ricardo Gladwell
@rgladwell
Jun 25 2015 16:47
Did you already have the Android SDK installed?
Fred Bricon
@fbricon
Jun 25 2015 16:48
depends what you mean by installed
it's unzipped, I ran android and installed a bunch of SDKs
Csaba Kozák
@WonderCsabo
Jun 25 2015 16:48
@fbricon i think you already downloaded the Android components, that is why the android command cannot update them
in that case, just call the deployer
Fred Bricon
@fbricon
Jun 25 2015 16:49
which fails
Properties file not found: /Users/fbricon/Dev/android-sdk-macosx/add-ons/addon-google_apis-google-8/source.properties
Ricardo Gladwell
@rgladwell
Jun 25 2015 16:49
run android and install the updates it tells you to and see if that improves things
Fred Bricon
@fbricon
Jun 25 2015 16:50
the ui?
Ricardo Gladwell
@rgladwell
Jun 25 2015 16:50
yes please
it could be your SDK is not completely up-to-date
Fred Bricon
@fbricon
Jun 25 2015 16:52
no idea which to install http://screencast.com/t/QpP6QYocL
Ricardo Gladwell
@rgladwell
Jun 25 2015 16:53
hmmm it looks like you are up-to-date
Csaba Kozák
@WonderCsabo
Jun 25 2015 16:53
install Android 2.2 -> Google API
that is indeed missing
well, it is not true acually
the deployer fails, but it installed the normal API 2.2 dep
@fbricon i suggest to try to build m2e-android
i mean the test project
if it builds correctly, you have everything what is needed in the Android side
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:02
try to build this and this
Fred Bricon
@fbricon
Jun 25 2015 17:03
eclipse didn't seem to like my android sdk, started to install new stuff
Ricardo Gladwell
@rgladwell
Jun 25 2015 17:03
new stuff?
Fred Bricon
@fbricon
Jun 25 2015 17:03
new sdks
in another dir
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:03
you can set the location of the android SDK in Preferences ->Android -> SDK location
you should
Fred Bricon
@fbricon
Jun 25 2015 17:04
yeah but something went wrong
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:04
@fbricon why do you bother wit h all the Android stuff BTW?
first we should just make sure our configurator is called even with runsAfter, shouldn't we?
Fred Bricon
@fbricon
Jun 25 2015 17:05
because I got some window poping up when running the hosted eclipse instance
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:06
i suggest to delete the workspace medatada
then run
echo adtUsed=true$'\n'lastSdkPath=$ANDROID_HOME$'\n'pingId=844 > ~/.android/ddms.cfg
Fred Bricon
@fbricon
Jun 25 2015 17:07
something wrong : http://screencast.com/t/vBGAIkcbAU it should already use the configurators provided by m2e-android
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:07
this should make sure ADT uses the correct SDK
Ricardo Gladwell
@rgladwell
Jun 25 2015 17:08
ah yeah, unfortunately, the maven-android-plugin uses a bunch of goals we can’t support yet
you need to ignore those goals
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:08
@rgladwell no
we support these goals
actually this is why the discovery found us
Fred Bricon
@fbricon
Jun 25 2015 17:08
but discovery should kick in
Ricardo Gladwell
@rgladwell
Jun 25 2015 17:08
oh no wait, you’re right @WonderCsabo just install those
i thought that was the normal m2e dialogue for discovery
Fred Bricon
@fbricon
Jun 25 2015 17:09
because I'm running from the workspace containing the configurators
Ricardo Gladwell
@rgladwell
Jun 25 2015 17:09
unless we’re misconfigured something for m2e0android
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:09
@fbricon are you running m2e-android on the second instance?
Fred Bricon
@fbricon
Jun 25 2015 17:09
from the m2e-android workspace, I ran a new eclipse application
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:09
i see
Fred Bricon
@fbricon
Jun 25 2015 17:09
using all plugins from workspace
and the TP
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:09
you should check out the eclipse log
for the workspace of the new eclipse app
i guess our configurator crashed at startup, that is why it is not avaialble
Fred Bricon
@fbricon
Jun 25 2015 17:11
mmm both adt and andmore are running
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:11
it is exepcted
that is not a problem, at least should not be
Fred Bricon
@fbricon
Jun 25 2015 17:11

generates binding conflicts

p.p1 {margin: 0.0px 0.0px 0.0px 0.0px; font: 11.0px Monaco}
span.Apple-tab-span {white-space:pre}

!MESSAGE A conflict occurred for ALT+SHIFT+A D:

Binding(ALT+SHIFT+A D,

ParameterizedCommand(Command(com.android.ide.eclipse.adt.launch.LaunchShortcut.debug,Debug Android Application,


    Debug Android Application,


    Category(org.eclipse.debug.ui.category.run,Run/Debug,Run/Debug command category,true),


    org.eclipse.ui.internal.WorkbenchHandlerServiceHandler@702b656a,


    ,,true),null),


org.eclipse.ui.defaultAcceleratorConfiguration,


org.eclipse.ui.contexts.window,,,system)

Binding(ALT+SHIFT+A D,

ParameterizedCommand(Command(org.eclipse.andmore.launch.LaunchShortcut.debug,Debug Android Application,


    Debug Android Application,


    Category(org.eclipse.debug.ui.category.run,Run/Debug,Run/Debug command category,true),


    org.eclipse.ui.internal.WorkbenchHandlerServiceHandler@528f5b7f,


    ,,true),null),


org.eclipse.ui.defaultAcceleratorConfiguration,


org.eclipse.ui.contexts.window,,,system)
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:12
ok, these messages are expected
should not effect m2e-android
of course nobody should use both, we just use both to compile the project
we could remove andmore from the new application BTW
Fred Bricon
@fbricon
Jun 25 2015 17:39
@WonderCsabo there's definitely a bug in the m2e configurators sort, not sure exactly what but it's wrong
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:40
@fbricon yeah, i narrowed the problem to the calculateEffectiveLifecycleMappingMetadata method
only
Fred Bricon
@fbricon
Jun 25 2015 17:41
yeah, configurator is sorted but not recognized as a primary configurator
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:51
i guess the problem is in line 173: if(children == null || children.isEmpty())
Fred Bricon
@fbricon
Jun 25 2015 17:52
no the problem is the android configurator is a secondary configurator to the java one
but for the say, proguard mojoexecution, the javaconfigurator is not applicable
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:53
you mean it is secondary to the java one, but primary also?
Fred Bricon
@fbricon
Jun 25 2015 17:53
yes
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:53
and your algorithm cannot handle that currently?
Fred Bricon
@fbricon
Jun 25 2015 17:53
the whole concept of primary configurator is pretty much fucked up
well there's a loophole
but I don't really grok why I didn't see it earlier
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:55
do you have a fix, or it should be refactored completely?
Fred Bricon
@fbricon
Jun 25 2015 17:56
I have no fix for the moment. you can try to remove the runsAfter directive though
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:56
well, we tied to add that to fix another problem in the first place ;)
we need java configurator to be called before us
Fred Bricon
@fbricon
Jun 25 2015 17:58
yeah. I need to come up with a fix, then I'll push a 1.6.1 release
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:58
okay, will you open a BZ ticket?
Fred Bricon
@fbricon
Jun 25 2015 17:59
if you can do it while I continue investigating, that'd be fine, else I'll create it later
Csaba Kozák
@WonderCsabo
Jun 25 2015 17:59
i open it for you to save time
Fred Bricon
@fbricon
Jun 25 2015 18:02
thx
Csaba Kozák
@WonderCsabo
Jun 25 2015 18:05
feel free to edit the description if yo find it incorrect etc https://bugs.eclipse.org/bugs/show_bug.cgi?id=471038
Ricardo Gladwell
@rgladwell
Jun 25 2015 18:48
Fantastic, thanks guys
Fred Bricon
@fbricon
Jun 25 2015 19:32
@rgladwell @WonderCsabo looks better http://screencast.com/t/q5MDg83N
I think
Csaba Kozák
@WonderCsabo
Jun 25 2015 19:33
OK, it seems our configurator is called
Fred Bricon
@fbricon
Jun 25 2015 19:33
no more plugin execution not covered
Csaba Kozák
@WonderCsabo
Jun 25 2015 19:33
@fbricon can you check the exported libraries window as well?
Fred Bricon
@fbricon
Jun 25 2015 19:34
in build classpath?
Csaba Kozák
@WonderCsabo
Jun 25 2015 19:34
yeah
@WonderCsabo no idea what I'm supposed to expect :-)
Csaba Kozák
@WonderCsabo
Jun 25 2015 19:36
wonderful! runsAfter fixes #353
Fred Bricon
@fbricon
Jun 25 2015 19:37
need to run non-regression tests on m2e, add new integration test as well
Csaba Kozák
@WonderCsabo
Jun 25 2015 19:37
thanks for working on this. I look forward for m2e 1.6.1. :)
Fred Bricon
@fbricon
Jun 25 2015 19:39
I'll try to get it out tomorrow or during the week end
Csaba Kozák
@WonderCsabo
Jun 25 2015 19:40
@fbricon if we add runsAfter, the plugin still can be used for m2e < 1.6, right?
Fred Bricon
@fbricon
Jun 25 2015 19:40
yeah, m2e 1.5 will ignore it
but you'll still have to mess with the classpath manually
unless you test m2e 1.6 is available
and skip that part
Csaba Kozák
@WonderCsabo
Jun 25 2015 19:41
the m2e 1.5 behavior was totally fine for us
i mean we called java project configurator manually
Fred Bricon
@fbricon
Jun 25 2015 19:41
but in m2e 1.6 you shouldn't
Csaba Kozák
@WonderCsabo
Jun 25 2015 19:42
OK, that is addressed in #356
Fred Bricon
@fbricon
Jun 25 2015 19:43
yeah you need that kind of hack if you want to support different m2e versions
although you should test osgi version ranges instead
Csaba Kozák
@WonderCsabo
Jun 25 2015 19:43
OK, thanks for confirming
Fred Bricon
@fbricon
Jun 25 2015 19:43
not just 1.6
e.g if version in [1.0, 1.6)
Csaba Kozák
@WonderCsabo
Jun 25 2015 19:44
yeah, you are right
i will change it to use compareTo, that will be enough i think
Fred Bricon
@fbricon
Jun 25 2015 20:00
@WonderCsabo can you locally build https://github.com/fbricon/m2e-core/tree/471038 ?
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:01
does the build need more steps apart from mvn install?
Fred Bricon
@fbricon
Jun 25 2015 20:02
for this change, mvn install should just work
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:02
do you want me to run the tests as well?
BTW, i am on Windows
is it buildable on Windows?
Fred Bricon
@fbricon
Jun 25 2015 20:03
sure you should run your m2e-android tests
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:03
i mean the tests in m2e-core
Fred Bricon
@fbricon
Jun 25 2015 20:03
a couple m2e core tests are expected to fail on windows
but you should be able to build core without any issue
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:05
i got missing artifact exception when running mvn install in the root folder:
org.eclipse.m2e:org.eclipse.m2e.archetype.common:jar:1.6.0-SNAPSHOT
org.eclipse.m2e:org.eclipse.m2e.maven.indexer:jar:1.6.0-SNAPSHOT
org.eclipse.m2e:org.eclipse.m2e.maven.runtime:jar:1.6.0-SNAPSHOT
org.eclipse.m2e:org.eclipse.m2e.maven.runtime.slf4j.simple:jar:1.6.0-SNAPSHOT
Fred Bricon
@fbricon
Jun 25 2015 20:06
ok then first run mvn clean install -f m2e-maven-runtime/pom.xml`
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:07
OK, i just found the buildall.sh script
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:13
build was successful, i try to add this build to my local m2e-android
Fred Bricon
@fbricon
Jun 25 2015 20:14
ok
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:20
i am stupid
i built the master branch ....
Fred Bricon
@fbricon
Jun 25 2015 20:20
no comment :-)
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:22
it is 22:00 in Europe, i should not build anything late night
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:29
OK, our configurator is called
i am waiting for the test suite to check all passed or not
Fred Bricon
@fbricon
Jun 25 2015 20:31
all m2e-core tests pass
but I need to come up with a new test case
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:31
m2e-android tests which i am talking about
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:38
i am a getting exceptions like this
org.eclipse.core.runtime.CoreException: Could not update project test-project-workspace-deps configuration
at org.eclipse.m2e.core.project.configurator.AbstractLifecycleMapping.configure(AbstractLifecycleMapping.java:126)
at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$3.call(ProjectConfigurationManager.java:501)
at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$3.call(ProjectConfigurationManager.java:1)
at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:176)
at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:151)
at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:494)
at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.configureNewMavenProjects(ProjectConfigurationManager.java:281)
at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$1.call(ProjectConfigurationManager.java:168)
at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$1.call(ProjectConfigurationManager.java:1)
at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:176)
at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:151)
at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:99)
at org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1355)
at org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.importProjects(ProjectConfigurationManager.java:136)
at org.eclipse.m2e.tests.common.AbstractMavenProjectTestCase$4.run(AbstractMavenProjectTestCase.java:371)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2241)
at org.eclipse.m2e.tests.common.AbstractMavenProjectTestCase.importProjects(AbstractMavenProjectTestCase.java:369)
at org.eclipse.m2e.tests.common.AbstractMavenProjectTestCase.importProjects(AbstractMavenProjectTestCase.java:344)
at org.eclipse.m2e.tests.common.AbstractMavenProjectTestCase.importProject(AbstractMavenProjectTestCase.java:331)
at org.eclipse.m2e.tests.common.AbstractMavenProjectTestCase.importProject(AbstractMavenProjectTestCase.java:318)
at me.gladwell.eclipse.m2e.android.test.AndroidMavenPluginTestCase.importAndroidProject(AndroidMavenPluginTestCase.java:72)
at me.gladwell.eclipse.m2e.android.test.AndroidMavenPluginTest.testConfigureAddsWorkspaceProjectDepsToClasspath(AndroidMavenPluginTest.java:54)
at sun.reflect.GeneratedMethodAccessor833.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Method.java:497)
at junit.framework.TestCase.runTest(TestCase.java:176)
at org.eclipse.m2e.tests.common.AbstractMavenProjectTestCase.runTest(AbstractMavenProjectTestCase.java:576)
at junit.framework.TestCase.runBare(TestCase.java:141)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:252)
at junit.framework.TestSuite.run(TestSuite.java:247)
at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:131)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
at org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:62)
at org.eclipse.pde.internal.junit.runtime.PlatformUITestHarness$1.run(PlatformUITestHarness.java:47)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.j
Fred Bricon
@fbricon
Jun 25 2015 20:41
no other significant stacktrace?
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:41
sorry, this may be my problem
i really should not build anything now :)
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:49
the test suite passed
your changes seems to be okay @fbricon
however, testConfigureMarksAndroidLibrariesContainerNotExported is failing again, so it seems ADT still creates its container after our configator is ran... :crying_cat_face:
well, ADT does that concurrently, so we cannot rely on when it adds that container, we have to wait for it somehow
Fred Bricon
@fbricon
Jun 25 2015 20:51
so normally, with the runAfter change, what will happen is :
  • jdt configurator is executed
  • jdt configurator will collect all other java configurators and invoke classpath change method
  • android configurator will change the classpath
  • then android configurator.configure() will be called
so if the classpath change requires android configuration beforehand, you might have an issue
Csaba Kozák
@WonderCsabo
Jun 25 2015 20:54
yeah, we have this issue
ADT adds that container after the second point
it seems
i guess there is no way to schedule the javaconfigurator.configure() to be executed after ADT adds that container to the classpath
BTW, this change shows m2e-android was not correct, just lucky that m2e was slower then ADT setup...
Fred Bricon
@fbricon
Jun 25 2015 21:02
do you know what/when trigger adt changes the classpath?
Csaba Kozák
@WonderCsabo
Jun 25 2015 21:04
ADT does lots of things
what is interesting for us is two classpath container initializers
which are adding two container entries to the classpath, if needed
Fred Bricon
@fbricon
Jun 25 2015 21:13
maybe you can use a java model change listener to detect modifications by ADT, then you can reorder the changes if necessary http://help.eclipse.org/luna/index.jsp?topic=%2Forg.eclipse.jdt.doc.isv%2Fguide%2Fjdt_api_manip.htm
fbricon @fbricon gotta run
Fred Bricon
@fbricon
Jun 25 2015 21:14
ttyl
Csaba Kozák
@WonderCsabo
Jun 25 2015 21:15
OK, thanks, this is what i found
OK, bye @fbricon