Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Oliver Kaufmann
    @okaufmann
    Thank you. Its so funny. I like to write short little posts just to not forget what i found or thought about somesthing. So that post was don't 5 minutes before I left the train two days ago. But suddenly this one got lot of feedback
    My first success while blogging:)
    Hei congrats to the first comment ruben :)
    Oliver Kaufmann
    @okaufmann
    I used this package for a movie community we're building since a while
    Rubens Mariuzzo
    @rmariuzzo
    Cool! I will follow your notes on your blogs. That way I can found useful packages or tips.
    Oliver Kaufmann
    @okaufmann
    Cool, if you need a feedback or help on a project: let me know ;)
    Rubens Mariuzzo
    @rmariuzzo
    I'm giving hug to Laravel-JS-Localization and Lang.js
    Oliver Kaufmann
    @okaufmann
    Cool
    Anton Komarev
    @antonkomarev
    @rmariuzzo I've posted a PR to support nested directories rmariuzzo/Lang.js#29
    Have chosen more safe case to implement it.
    Rubens Mariuzzo
    @rmariuzzo
    I'm checking it.
    Merged. Thanks for your effort!
    Anton Komarev
    @antonkomarev
    I'm working on backend part right now.
    Writing unit tests to check of nested directories key format.
    and i forgot config file for my previous PR. Will add in this PR too.
    Rubens Mariuzzo
    @rmariuzzo
    Awesome!
    I will also take a look at the config file.
    Anton Komarev
    @antonkomarev
    I just realized that there should be an ability to allow nested directories in config too.
    return [
    
        /*
         * Set the names of files you want to add to generated javascript.
         * Otherwise all the files will be included.
         *
         * 'messages' => [
         *     'validation',
         * ],
         */
    
        'messages' => [
    
        ],
    
    ];
    How to name it then: 'forum.thread' or forum/thread?
    I'm thinking about this way:
    'messages' => [
        'validation',
        'forum/thread',
        'forum/post',
    ]
    and later implement wildcards forum/*
    Anton Komarev
    @antonkomarev
    I've pusher PR, but I haven't tested a use case like: forum/thread.viewAllThreads :(
    Rubens Mariuzzo
    @rmariuzzo
    Good idea @a-komarev! I will take a look later today.
    Rubens Mariuzzo
    @rmariuzzo
    Just found out that running the tests with just phpunit doesn't work, but it works with vendor/bin/phpunit... does it ring a bell to any of you?
    Anton Komarev
    @antonkomarev
    It doesnt work if you have phpunit 5.x installed globally
    that happens with all laravel packages :D
    it's ok
    Rubens Mariuzzo
    @rmariuzzo
    I have 4.7.3 globally and it fails.
    Anyway, that's not a big deal right now. I'm thinking on updating the README concerning testing.
    Anton Komarev
    @antonkomarev
    Add it in composer scripts section and automate it this way
    Anton Komarev
    @antonkomarev
    @rmariuzzo Rubens, what do you think about team creation in current project? then we'll be able to mention team like @teamname?
    Just for easy pinging collaborators if required an attention.
    Zubair Mohsin
    @Zubairmohsin33_twitter
    hi there, I am working on a project which uses Laravel-JS-Localization, I don't know how it works. It works fine for Norwegian and English language, i have to translate it into Indonesian language, how do i do that? i have changed the data-lang attribute to 'id' but messages show 'javascript code'
    Zubair Mohsin
    @Zubairmohsin33_twitter
    do i have to add Indonesian language 'messages' myself?
    Oliver Kaufmann
    @okaufmann
    Can you please provide us some samples ?
    Zubair Mohsin
    @Zubairmohsin33_twitter
    can i post code here?
    Oliver Kaufmann
    @okaufmann
    or you open an issue =
    ?
    Rubens Mariuzzo
    @rmariuzzo
    Whatever is best for you @Zubairmohsin33_twitter
    Anton Komarev
    @antonkomarev
    @rmariuzzo I think you will be interested in new L5.4 addition: laravel/framework#16424
    Laravel officially start to working with JSON translation files!
    Rubens Mariuzzo
    @rmariuzzo
    I'm planning to release 1.3.6 including non breaking changes.
    I will go through everything pending and see what can be included.
    Any recommendation will be appreciated.
    Rubens Mariuzzo
    @rmariuzzo
    BTW @a-komarev interesting the JSON support for lang files.
    We should start experimenting.
    Rubens Mariuzzo
    @rmariuzzo
    I’m back to life, feeling much better than befor.e
    I’m working on releasing support for Laravel 5.4, currently writing some tests agains that version to make sure everything works as expected.
    Rubens Mariuzzo
    @rmariuzzo