Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Anton Komarev
    @antonkomarev
    How to name it then: 'forum.thread' or forum/thread?
    I'm thinking about this way:
    'messages' => [
        'validation',
        'forum/thread',
        'forum/post',
    ]
    and later implement wildcards forum/*
    Anton Komarev
    @antonkomarev
    I've pusher PR, but I haven't tested a use case like: forum/thread.viewAllThreads :(
    Rubens Mariuzzo
    @rmariuzzo
    Good idea @a-komarev! I will take a look later today.
    Rubens Mariuzzo
    @rmariuzzo
    Just found out that running the tests with just phpunit doesn't work, but it works with vendor/bin/phpunit... does it ring a bell to any of you?
    Anton Komarev
    @antonkomarev
    It doesnt work if you have phpunit 5.x installed globally
    that happens with all laravel packages :D
    it's ok
    Rubens Mariuzzo
    @rmariuzzo
    I have 4.7.3 globally and it fails.
    Anyway, that's not a big deal right now. I'm thinking on updating the README concerning testing.
    Anton Komarev
    @antonkomarev
    Add it in composer scripts section and automate it this way
    Anton Komarev
    @antonkomarev
    @rmariuzzo Rubens, what do you think about team creation in current project? then we'll be able to mention team like @teamname?
    Just for easy pinging collaborators if required an attention.
    Zubair Mohsin
    @Zubairmohsin33_twitter
    hi there, I am working on a project which uses Laravel-JS-Localization, I don't know how it works. It works fine for Norwegian and English language, i have to translate it into Indonesian language, how do i do that? i have changed the data-lang attribute to 'id' but messages show 'javascript code'
    Zubair Mohsin
    @Zubairmohsin33_twitter
    do i have to add Indonesian language 'messages' myself?
    Oliver Kaufmann
    @okaufmann
    Can you please provide us some samples ?
    Zubair Mohsin
    @Zubairmohsin33_twitter
    can i post code here?
    Oliver Kaufmann
    @okaufmann
    or you open an issue =
    ?
    Rubens Mariuzzo
    @rmariuzzo
    Whatever is best for you @Zubairmohsin33_twitter
    Anton Komarev
    @antonkomarev
    @rmariuzzo I think you will be interested in new L5.4 addition: laravel/framework#16424
    Laravel officially start to working with JSON translation files!
    Rubens Mariuzzo
    @rmariuzzo
    I'm planning to release 1.3.6 including non breaking changes.
    I will go through everything pending and see what can be included.
    Any recommendation will be appreciated.
    Rubens Mariuzzo
    @rmariuzzo
    BTW @a-komarev interesting the JSON support for lang files.
    We should start experimenting.
    Rubens Mariuzzo
    @rmariuzzo
    I’m back to life, feeling much better than befor.e
    I’m working on releasing support for Laravel 5.4, currently writing some tests agains that version to make sure everything works as expected.
    Rubens Mariuzzo
    @rmariuzzo
    Anton Komarev
    @antonkomarev
    Nice! :}
    Well done
    Rubens Mariuzzo
    @rmariuzzo
    I think it could be done better, but for now, it works. :)
    I have also released v1.4.0 with all pending feature that were merged into develop.
    I will do my best to stay in touch with our community. I also want to thank you all for your awesome support! You all rock!
    Rubens Mariuzzo
    @rmariuzzo
    Hey there! I’m working on long lived issue about AMD + CommonJS support.
    I’m having trouble on looking for an easy solution to make it work using our current JS templates.
    So, I’m thinking if it is worth to include the fix into a v2.0.0 and removed lang.js as bundled dependency but requiring for each users to include install lang.js separately.
    What do you think?
    Anton Komarev
    @antonkomarev
    If this will be covered in documentation it will be done in 1-2 additional console commands without any manual routine - it's not critical
    Rubens Mariuzzo
    @rmariuzzo
    I agree @a-komarev
    I’m still doing some research to see if I can include it the fix/feature on 1.x instead
    Anton Komarev
    @antonkomarev
    @rmariuzzo Are you joined to Larachat?
    Rubens Mariuzzo
    @rmariuzzo
    Yes, I am, but I’m not following recently. Why?
    Anton Komarev
    @antonkomarev
    @rmariuzzo I'm rarely using gitter since Larachat was launched :} Don't know but Gitter is keeps freezing my browser.
    Rubens Mariuzzo
    @rmariuzzo
    I see, I will use Larachat to contact you.
    Anton Komarev
    @antonkomarev
    I wrote PM to you there earlier. My name there the same as here :}