Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Nikos Gereoudakis
    @stream7
    I run yarn upgrade-interactive and no fela package appears though
    ├─ fela-bindings@1.3.4
    │  ├─ fela-dom@^7.0.4
    │  ├─ fela-tools@^5.1.2
    │  ├─ fela-tools@5.2.2
    │  │  ├─ fela-utils@^8.1.2
    │  │  └─ fela@^6.2.2
    ├─ fela-dom@7.0.9
    │  ├─ fela-utils@^8.0.8
    │  └─ fela-utils@8.1.2
    ├─ fela-monolithic@5.0.28
    │  ├─ fela-utils@^8.1.3
    ├─ fela-plugin-embedded@5.2.13
    ├─ fela-plugin-extend@5.0.12
    │  ├─ fela-utils@^7.0.4
    │  └─ fela-utils@7.0.5
    ├─ fela-plugin-fallback-value@5.0.20
    ├─ fela-plugin-prefixer@5.0.21
    │  ├─ fela-plugin-fallback-value@^5.0.20
    ├─ fela-plugin-unit@5.1.2
    ├─ fela-preset-web@8.0.13
    │  ├─ fela-plugin-embedded@^5.2.13
    │  ├─ fela-plugin-extend@^5.0.11
    │  ├─ fela-plugin-fallback-value@^5.0.20
    │  ├─ fela-plugin-prefixer@^5.0.21
    │  └─ fela-plugin-unit@^5.1.2
    ├─ fela-tools@5.2.3
    │  ├─ fela-utils@^8.1.3
    │  └─ fela@^6.2.3
    ├─ fela-utils@8.1.3
    ├─ fela@6.2.3
    │  ├─ fela-utils@^8.1.3
    ├─ react-fela@6.2.4
    │  ├─ fela-bindings@^1.3.4
    │  ├─ fela-dom@^7.0.4
    Robin Frischmann
    @rofrischmann
    hmm but the current fela-bindings v is 3.0.4 not 1.3.4
    (no idea how the upgrade-interactive stuff works though)
    Nikos Gereoudakis
    @stream7
    Well it seems I’m two major versions behind in react-fela :D
    Robin Frischmann
    @rofrischmann
    yeah..
    independent versioning was the biggest mistake ever
    Nikos Gereoudakis
    @stream7
    Ok nvm, I need to plan the upgrade I guess
    Did you remove the HOC completely? createComponent?
    Robin Frischmann
    @rofrischmann
    na
    not yet
    Nikos Gereoudakis
    @stream7
    ok, cool :D
    Robin Frischmann
    @rofrischmann
    its not even deprecated atm
    Nikos Gereoudakis
    @stream7
    Do you have to?
    Robin Frischmann
    @rofrischmann
    but itll be as soon as we have enough codemods to make upgrading smooth
    Nikos Gereoudakis
    @stream7
    Can’t you just keep both options?
    it kind of looks a bit better for some people I guess
    Robin Frischmann
    @rofrischmann
    check the last blog post I wrote, itll explain why those go
    Nikos Gereoudakis
    @stream7
    do you have a link for that?
    Robin Frischmann
    @rofrischmann
    im fine with so. maintaining those, but I dont want to do that my own
    and I don't want it to be part of react-fela, id be fine with a different package, but its super hard to improve stuff with always having to make cC and connect work as is
    Nikos Gereoudakis
    @stream7
    Robin Frischmann
    @rofrischmann
    yeah
    Nikos Gereoudakis
    @stream7
    Ok, cool, thanks for looking into it
    Nikos Gereoudakis
    @stream7
    @rofrischmann is there an easy way to see the breaking changes of react-fela 6 -> 8 ?
    Robin Frischmann
    @rofrischmann
    Thats probably the best resource
    Nikos Gereoudakis
    @stream7
    I think there was no breaking change tbh
    so it could have still been 6 :D
    also that previous problem I had is gone too
    or maybe it is cause I’m not using SSR in this project (regarding major version bump)
    Robin Frischmann
    @rofrischmann
    There was no major change in the react-fela package itself
    But within fela-bindings or fela-dom and as it requires those we bump a major because else your fucked with ^versions
    Nikos Gereoudakis
    @stream7
    I don’t want to know more :D
    hehe
    Marek Janča
    @jancama2
    Hey guys, is there any chance how to find out Fela rendered all the styles for my component? I'm having a kind of a race condition: React renders all the markup => I’m performing scrollToHashLink on componentDidMount, but somehow the scroll is faster then styles so I end up scrolled to the bottom after the styles are applied.
    Marek Janča
    @jancama2
    Btw this thing is happening on the first render, after the first render everything is ok, thanks for any help :))
    Robin Frischmann
    @rofrischmann
    hmm whats your setup? using Provider from react-fela? that should ensure style rendering, but yeah its async due to the insertRule calls
    Marek Janča
    @jancama2

    Yes, usig Provider from react-fela, ended up with:

    <Fragment>
        <FelaProvider renderer={renderer}>
           <ThemeProvider theme={theme}>
              <Application>{children}</Application>
           </ThemeProvider>
        </FelaProvider>
        <ScrollOnUpdate />
    </Fragment>

    and extracting static styles (vendors) to scss, looks like waiting for the Provider to render and extracting statics helped.
    The issues is basically similar to this one rofrischmann/fela#532. I havent found renderToDOM property in docs or codebase so I guess it wasnt included, Am I right?

    Robin Frischmann
    @rofrischmann
    Yeah, we used didMount in the past, but now it renders in the constructor which means your styles should be ready as soon as a component hits the DOM.
    Marek Janča
    @jancama2
    Well, checking ProviderFactory now and since the Provider renders the renderer in the constructor there shouldnt be a problem. Dont know why moving vendors out of fela helped.
    Haha, was just thinking about the same
    Marek Janča
    @jancama2
    hmmm, looks, like splitting statics into more chunks helped
    Marek Janča
    @jancama2
    could be the problem that i’m loading fonts using static css and not fela renderFont?
    Robin Frischmann
    @rofrischmann
    is it just the font that fails?
    Marek Janča
    @jancama2
    yes, i had fonts in my static css imported from an external url (google api), when i moved the fonts to renderFont, everything is ok, dont ask me why :|
    lesson learned: use renderFont and renderStatic, dont try to load fonts using renderStatic… what bothers me the most is I dont really understand the problem
    Marija Najdova
    @mnajdova
    Hey guys, I've got one question. According to the documentation about the createRenderer (http://fela.js.org/docs/advanced/RendererConfiguration.html), adding the selectorPrefix option should add prefixes to the generated rules and keyframes. I tried the same example in the link, but although the rules' classNames are generated with the prefix, the keyframes are not. Is this a bug, or there was some change in the API that is not documented? I saw in the implementation of the createRenderer that the selectorPrefix is used only when the classNames for the rules are generated, but not in the generation of the animationName... Let me know if I should create an issue about this! Thanks!
    Robin Frischmann
    @rofrischmann
    @mnajdova You're right, the docs are out-dated on that one! I will update it as soon as possible. We do not include the selectorPrefix for keyframe names anymore. Is this an issue for you? I don't see how we could benefit from prefixed animation names.
    Marija Najdova
    @mnajdova
    @rofrischmann thanks for your answer. I think that feature would have been very beneficial. In our case, we have two different renderers on the page (the dafualt one and rtl). In order for these two to work on the same page, we are adding the selectorPrefix ‘rtl_’ on the rtl renderer, and everything works as expected. Now, with the animations introduced, the rtl renderer is overriding the keyframes for the previous renderer and we are ending up with two different keyframes with the same name on the page. The worse thing is, after we are switching back to the default one, the last keyframes added in the head are the rtl ones and we don’t even have a way to override those back to the original ones. Do you have any suggestion then how can this be fixed, now that we cannot use the selectorPrefix for the keyframes?