Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 01 2019 23:26
    stewSquared commented #20
  • Aug 01 2019 23:26
    stewSquared commented #20
  • Aug 01 2019 23:25
    stewSquared commented #20
  • Aug 01 2019 22:20
    stewSquared commented #20
  • Aug 01 2019 17:27
    rossabaker commented #20
  • Aug 01 2019 16:57
    stewSquared commented #20
  • Aug 01 2019 16:57
    stewSquared commented #20
  • Aug 01 2019 16:57
    stewSquared commented #20
  • Aug 01 2019 00:28
    stewSquared commented #20
  • Aug 01 2019 00:01
    gigawhitlocks commented #20
  • Aug 01 2019 00:01
    gigawhitlocks commented #20
  • Jul 31 2019 23:57
    stewSquared commented #20
  • Jun 06 2019 13:39
    rossabaker commented #28
  • Jun 06 2019 13:38

    rossabaker on master

    Deprecate lsp-scala Merge pull request #29 from Jes… (compare)

  • Jun 06 2019 13:38
    rossabaker closed #29
  • Jun 06 2019 13:38
    rossabaker commented #28
  • Jun 06 2019 05:21
    JesusMtnez edited #28
  • Jun 06 2019 05:21
    JesusMtnez edited #28
  • Jun 06 2019 05:20
    JesusMtnez review_requested #29
  • Jun 06 2019 05:20
    JesusMtnez assigned #29
Ross A. Baker
@rossabaker
I reached out to Heikki about what he wants to do, if anything, about sbt-mode.
Heikki Vesalainen
@hvesalai
hello
I'll continue hosting emacs-scala-mode and emacs-sbt-mode under my github account
the authorative version will be at https://github.com/hvesalai/emacs-scala-mode
and respectively for emacs-sbt-mode
Ólafur Páll Geirsson
@olafurpg
@hvesalai that's great! I'll delete the scalameta fork then :)
@kurnevsky I just deleted the scalameta/emacs-scala-mode fork to help keep a single authoritative repo. Please sync with @hvesalai if you want to contribute
Evgeny Kurnevsky
@kurnevsky
ok, thank you for the care of emacs users :)
Ólafur Páll Geirsson
@olafurpg
I'm seeing several emacs/metals users reporting issues with "goto definition" not working when they try to run lsp-goto-type-definition and lsp-goto-implementation. Would someone be interested in contributing docs to http://scalameta.org/metals/docs/editors/emacs.html clarifying how to "goto definition"?
Evgeny Kurnevsky
@kurnevsky
@olafurpg there are lsp-find-definition and lsp-find-references that work.
Ivan Yonchovski
@yyoncho
lsp-goto-type-definition corresponds to textDocument/typeDefinition
Evgeny Kurnevsky
@kurnevsky
Metals doesn't support implementationProvider and typeDefinitionProvider capabilities for commands you tried.
Ólafur Páll Geirsson
@olafurpg
Yup, i have pointed several people to use lsp-find-definition. It seems like a documentation issue where people try to run lsp-goto-type-definition and see it not working (because metals doesn't support it yet) and assume something is wrong with the installation
Ivan Yonchovski
@yyoncho
I think that @JesusMtnez did the documentation on the metals side, would you add a few lines describing that the users should use lsp-find-definition method?
Adam Bobrow
@bobrowadam
Hey, I've noticed that in scala-metals it sais that there is support text folding but couldn't find that in "lsp-mode". So is it possible?
Ivan Yonchovski
@yyoncho
Adam Bobrow
@bobrowadam
Thanks @yyoncho !
hanm2019
@hanm2019
hi, I have some questions while using scala
when i open sbt in spacemacs, it always open set the project root to ~, not the current project.
Ivan Yonchovski
@yyoncho
@hanm2019 use lsp-workspace-folders-remove and then when asked to import the project make sure that you have picked the right one.
hanm2019
@hanm2019
I select the right project path, but it seem doesn't work
Screenshot from 2020-06-22 00-00-32.png
in the left window, the scala file is in ~/Documents/CHISEL/AND/src/main/add.scala, so I select the lsp-workspace-floders to ~/Documents/CHISEL/AND
hanm2019
@hanm2019
in ~/Documents/CHISEL/AND there are build.sbt file.
but when i use sbt-command , it Start sbt in buffer sbt<~>
Ivan Yonchovski
@yyoncho
I think that this sbt thing is not related to lsp-mode
IMO this is another package that does that.
hanm2019
@hanm2019
in the init.el, I add scala-lsp in the dotspacemacs-configuration-layers
but do nothing about the lsp
Ivan Yonchovski
@yyoncho
you should check where sbt integration is getting the root from.
Probably it is projectile.
Check projectile root
hanm2019
@hanm2019
Screenshot from 2020-06-22 00-13-12.png
Ivan Yonchovski
@yyoncho
you may try projectile-add-to-known-project
I don't think that there is scala lsp layer
the layer is scala
and lsp layer is called lsp
hanm2019
@hanm2019
I try projectile-add-to-known-project, it recognize the project root since I run git init in ~/Documents/CHISEL/AND
Ivan Yonchovski
@yyoncho
Sorry, I don't know anything about sbt.
hanm2019
@hanm2019
should I use the scala layer or scala-lsp layer? I think they have similar function, but when I add both. there is a warning for some function rerun twice
Ivan Yonchovski
@yyoncho
I think that scala layer is the correct one
BUT imo you should ask in spacemacs gitter about sbt
Ross A. Baker
@rossabaker
I'm not a Spacemacs user anymore, but the sbt-* commands come from sbt-mode.
Here is the logic for where sbt-mode finds the root directory.
hanm2019
@hanm2019
thanks a lot, I solve this problem by remove a project dir in ~, since the sbt-mode finding the project root by matching the project/*.sbt file, and I run sbt in the ~ many day before.
hanm2019
@hanm2019
I also want to know, whether the lsp-scala support chisel3 ? I think chisel3 is a library that written by scala. when I write chisel code, It seem that the lsp backend doesn't know this library
Ross A. Baker
@rossabaker
The lsp-scala is a small library I wrote to integrate lsp-mode with Metals. The Scala support later moved into lsp-mode, making my library obsolete. Recently, Scala support spun back off as lsp-metals.
If you have lsp-scala in your config, you instead want lsp-metals.
I would expect it to support chisel3 just fine. I don't know chisel except for a meetup presentation, but as I remember it, it's just a DSL embedded in regular Scala code.
hanm2019
@hanm2019
thank you, I will try