These are chat archives for rosshinkley/nightmare

28th
Apr 2016
Mingsterism
@mingsterism
Apr 28 2016 00:24
Ok. Where should I put the catch statement? Thanks.
I'm still new to JS appreciate the help.
Mingsterism
@mingsterism
Apr 28 2016 01:20
@rosshinkley I just saw the github issues. Thanks Ross. Will try it out.
Rob Brackett
@Mr0grog
Apr 28 2016 20:19
@rosshinkley I wonder if the selectors in that example would be better changed to:
'form[action*="/search"] [name=p]’ (text field) and
'form[action*="/search"] [type=submit]’ (button)
Not as obvious when you’re reading, but likely far more stable over time.
rosshinkley @rosshinkley nods
Ross Hinkley
@rosshinkley
Apr 28 2016 20:21
@Mr0grog i agree
... just noticed the timestamps, impeccable timing
Rob Brackett
@Mr0grog
Apr 28 2016 20:22
ha
Ok, stepping out. Will maybe PR that later if I have time.
Ross Hinkley
@rosshinkley
Apr 28 2016 20:24
but yeah, even with more stable selectors, that example ought to have a .catch()
looking forward to it