These are chat archives for rosshinkley/nightmare

20th
May 2016
Ross Hinkley
@rosshinkley
May 20 2016 15:39
@Mr0grog would it make sense to add .clear() (with no explicit arguments) to remove all cookies to core?
Rob Brackett
@Mr0grog
May 20 2016 15:40
wait, doesn’t that already exist?
Ross Hinkley
@rosshinkley
May 20 2016 15:40
... now you're making me doubt myself
i don't think so
Rob Brackett
@Mr0grog
May 20 2016 15:42
oh, no, I guess not
Ross Hinkley
@rosshinkley
May 20 2016 15:42
looks like no
you can clear multiple cookies
Rob Brackett
@Mr0grog
May 20 2016 15:42
it stupidly forwards an empty list of cookies to clear
Ross Hinkley
@rosshinkley
May 20 2016 15:42
i did not know that
Rob Brackett
@Mr0grog
May 20 2016 15:42
and wastes time going over IPC when it's not necessary
wheeeeee
Ross Hinkley
@rosshinkley
May 20 2016 15:42
i should modify the example i posted
i think you could just pump the array of names down
instead of doing a whole round trip for each name
... still seems kind of unnecessary :P
Rob Brackett
@Mr0grog
May 20 2016 15:43
yeah, if the first arg is an array of names, it works
but I concur, no args should clear all, not clear none
Ross Hinkley
@rosshinkley
May 20 2016 15:43
but i don't know how much utility there is in a "scorch all of hte cookies without looking"
okay
Rob Brackett
@Mr0grog
May 20 2016 15:44
well
rosshinkley @rosshinkley nods
Rob Brackett
@Mr0grog
May 20 2016 15:44
I think, if you're doing that
you probably really want: clear everything local: storage, cookies, cache, etc
Ross Hinkley
@rosshinkley
May 20 2016 15:44
yeah
Rob Brackett
@Mr0grog
May 20 2016 15:44
99% of the time, that's probably the only use case for "clear all cookies"
Ross Hinkley
@rosshinkley
May 20 2016 15:45
i agree that .clear() doing effectively nothing but wasting time is surprising :P
Rob Brackett
@Mr0grog
May 20 2016 15:45
although, I guess, clear, like set and get, would scope to the current domain
so it's a little different
(maybe also debatable whether the cookie methods should scope by domain)
(but they do)
(so)
Ross Hinkley
@rosshinkley
May 20 2016 15:46
... is there a case where you'd want to inject a cookie for all domains?
Rob Brackett
@Mr0grog
May 20 2016 15:54
no, but:
  • maybe before you load a page
  • maybe for a different domain than the one the main frame is at
Do I think those use cases are a big deal? Probably not.
Ross Hinkley
@rosshinkley
May 20 2016 15:55
ooooh yeah
i just read that line where the url comes form the webcontents
hhhuh
i did not know that either
:stars:
well then
Ross Hinkley
@rosshinkley
May 20 2016 18:35
@Mr0grog by the by, in 646, that "violent agreement" was about 97% me kicking myself for poor word choice, not frustration at you :)
Rob Brackett
@Mr0grog
May 20 2016 18:45
oh, I didn't take it as anything really directed at me one way or the other :P
Ross Hinkley
@rosshinkley
May 20 2016 18:46
ah, good
it's another bi-weekly reminder that i need to be choosy with how i phrase things :P
Rob Brackett
@Mr0grog
May 20 2016 18:47
enh
no worries
Ross Hinkley
@rosshinkley
May 20 2016 18:47
it keeps me honest
ooookay
next thing
Ross Hinkley
@rosshinkley
May 20 2016 21:35
wwwell
i tried to update to 14.04 to get node6 for free
and virtually everything broke
which seems incorrect somehow
the v6 case will install it from nvm first now
but i'm going to double-back, point my personal build at 14.04 and try to take a crack at what's failing
Ross Hinkley
@rosshinkley
May 20 2016 22:04
for the interested, the 14.04 image on circle is missing libnotify