These are chat archives for rowanmiller/RocketProfiler

18th
Mar 2016
Arthur Vickers
@ajcvickers
Mar 18 2016 00:10
Merged methods for this.
Rowan Miller
@rowanmiller
Mar 18 2016 00:13
Thanks, I have everything else working, so I'll wire up with your changes and then I'm done for the day too
Rowan Miller
@rowanmiller
Mar 18 2016 00:28
Pushed my stuff... I'm done for the day... see you guys tomorrow
mikary
@mikary
Mar 18 2016 16:28
Pushed more UI changes for saved sessions, I added start and end times to the display and opted to use the Run.Id when the Run.Name is empty
Arthur Vickers
@ajcvickers
Mar 18 2016 16:32
I'm going to try to make a change so that if you have a run selected, then you can just hit an upload current run button and have it upload the selected run.
I think the start time and end time in the U.I. should use local time.
mikary
@mikary
Mar 18 2016 16:34
Normally I would agree about local time, but as an aerospace application I think the default expectation would be zulu ;)
Arthur Vickers
@ajcvickers
Mar 18 2016 16:35
We're saving all the data in UTC. But when displaying in the U.I. it should be local.
Rowan Miller
@rowanmiller
Mar 18 2016 17:11
The crashes I was seeing were just from trying to open a database from before we enabled migrations :smile:
mikary
@mikary
Mar 18 2016 17:55
So, we decided that the sensor threshold would be on a new entity type?
Arthur Vickers
@ajcvickers
Mar 18 2016 17:58
It doesn't have to be. Just put it on SensorInfo for now.
Just make sure that when saving to the database any existing sensors with the same name have the threshold set.
Rowan Miller
@rowanmiller
Mar 18 2016 17:59
blob
Arthur Vickers
@ajcvickers
Mar 18 2016 17:59
Awesome!
mikary
@mikary
Mar 18 2016 17:59
So, nullable to simplifly the migration?
And yes, awesome :D
Arthur Vickers
@ajcvickers
Mar 18 2016 18:01
This is what I have so far. Still need to work on the graphs a bit.
blob
Rowan Miller
@rowanmiller
Mar 18 2016 18:02
Should we make the sidebar a different color?
Love the timer styling
@mikary nullable is fine
Arthur Vickers
@ajcvickers
Mar 18 2016 18:02
I'll give it a try.
Rowan Miller
@rowanmiller
Mar 18 2016 18:02
Seems reasonable that some sensors don't have a threshold
@ajcvickers I'm not super fussed, so don't feel like you have to :smile:
Arthur Vickers
@ajcvickers
Mar 18 2016 18:03
One of the main take homes for me from this app is that Migrations on SQLite is really painful.
It's a good idea. :-)
Rowan Miller
@rowanmiller
Mar 18 2016 18:04
Good segway... what do folks want listed under "Takeaways". Here is what I have
  • Feel successful when I make something work
  • Migrations on SQLite is painful
Arthur Vickers
@ajcvickers
Mar 18 2016 18:05
I generally found EF Core intuitive and easy to use. :-)
Rowan Miller
@rowanmiller
Mar 18 2016 18:05
Do you think it's fair to say that even with a small app we quickly got to a stage where one person doesn't fully understand the full stack
Arthur Vickers
@ajcvickers
Mar 18 2016 18:05
Yes, but then we only had a week.
Are the graphs added purely in code?
Rowan Miller
@rowanmiller
Mar 18 2016 18:06
So maybe it's to do with the fast pace, we need to get things done so we didn't dwell on understanding everything
mikary
@mikary
Mar 18 2016 18:07
yeah, the graphs are only added programatically
Arthur Vickers
@ajcvickers
Mar 18 2016 18:07
Yeah, but I think that is normal. I think that given a few hours to go over the code each of could have understood everything.
mikary
@mikary
Mar 18 2016 18:07
Yeah, we didn't really have time to sit down and plan / establish a common view of what we were building
Rowan Miller
@rowanmiller
Mar 18 2016 18:08
I was suprised with how quickly we were able to build something decent... agree/disagree?
mikary
@mikary
Mar 18 2016 18:08
I also think we might have a takeaway about INotifyChanged, since binding to entity types required some hackish workarounds?
Arthur Vickers
@ajcvickers
Mar 18 2016 18:09
I don't think I would say that, at least for me. I meant more that I don't fully understand the U.I. elements, and other probably don't fully understand the run controller elements.
Rowan Miller
@rowanmiller
Mar 18 2016 18:09
:+1:
Arthur Vickers
@ajcvickers
Mar 18 2016 18:09
Agree.
mikary
@mikary
Mar 18 2016 18:09
Right, but I also don't think we had a vision of what we were building to start other than "a UI for sensors"
Arthur Vickers
@ajcvickers
Mar 18 2016 18:10
Possibly. But I think the amount of common vision we had is normal and expected. Get something working and then evolve it. Even if we had more time I probably wouldn't have wanted to spend more time planning.
mikary
@mikary
Mar 18 2016 18:11
Oh, perhaps another take away would be about the initial approach to sensors and the evolution to something more flexible...
Arthur Vickers
@ajcvickers
Mar 18 2016 18:11
Or put another way, I think two days building got us to a common understanding much more effectively than two days talking would have done.
mikary
@mikary
Mar 18 2016 18:13
I don't know if it was as much the case for your part, but I do feel we had a little trouble with coordinating so that we don't have two people working on the same component at the same time / fairly complex merges
Rowan Miller
@rowanmiller
Mar 18 2016 18:13
Yeah I suspect our experience is similar to the very early days of a startup... someone has a vision of what they want, but the path to get there is very undefined and folks just hack away to get something working
mikary
@mikary
Mar 18 2016 18:13
@ajcvickers Speaking of, have you made many changes to the Run/Sensor/Plot view models?
Arthur Vickers
@ajcvickers
Mar 18 2016 18:14
None.
Rowan Miller
@rowanmiller
Mar 18 2016 18:14
Interestingly what we ended up with is pretty much exactly what I had in mind a week ago
Arthur Vickers
@ajcvickers
Mar 18 2016 18:14
Just the XAML so far.
Rowan Miller
@rowanmiller
Mar 18 2016 18:14
but I do feel we had a little trouble with coordinating so that we don't have two people working on the same component at the same time / fairly complex merges
Agreed
Mostly in the UI code to start with
mikary
@mikary
Mar 18 2016 18:15
I'd like to push the changes I have so far, it's ViewModel only and fairly small
Arthur Vickers
@ajcvickers
Mar 18 2016 18:15
Go for it.
mikary
@mikary
Mar 18 2016 18:16
@rowanmiller I had a point yesterday where I had some refactoring changes I made while you were doing UI work and it was easier to just throw them away and start over ;)
Rowan Miller
@rowanmiller
Mar 18 2016 18:17
This sound ok for the presentation:
  • Intro to problem
  • Architecture
  • Demo of app
  • Video of test run
  • Takeaways
Arthur Vickers
@ajcvickers
Mar 18 2016 18:17
Sounds good.
mikary
@mikary
Mar 18 2016 18:17
Looks good to me too
Oh, another takeaway - lack of PRs for iteration time
Rowan Miller
@rowanmiller
Mar 18 2016 18:19
I was thinking I might do the intro about what we were trying to achieve and then you guys can do the rest and I will drive the machine. Just a proposal though... I'm totally open to whatever :smile:
mikary
@mikary
Mar 18 2016 18:19
We will show the second video from Wednesday, right? :D
Rowan Miller
@rowanmiller
Mar 18 2016 18:19
Oh yes :fire:
Arthur Vickers
@ajcvickers
Mar 18 2016 18:19
I really didn't think we needed PRs at all. But then maybe it was different for the U.I.
mikary
@mikary
Mar 18 2016 18:20
I think the lack of PRs was fine, it was just a different way of working is all
Rowan Miller
@rowanmiller
Mar 18 2016 18:21
Maybe another takeaway is that writing a framework is HARD compared to an app
mikary
@mikary
Mar 18 2016 18:21
I think that's fair
also, a big :+1: for gitter chat
Arthur Vickers
@ajcvickers
Mar 18 2016 18:22
Yeah. The best way of creating a small app with a few developers is very different from the best way of creating a framework with more developers.
A takeaway for our org, I think... ;-)
Rowan Miller
@rowanmiller
Mar 18 2016 18:32
Yep, great point
Azure is SLOOOOOOW
mikary
@mikary
Mar 18 2016 18:33
Unrelated but perhaps related, I don't seem to have any of the commands packages loading
Rowan Miller
@rowanmiller
Mar 18 2016 18:35
Yeah I think that is a higher level point that our dependency graph is super complex and error prone
Arthur Vickers
@ajcvickers
Mar 18 2016 18:35
I can't figure out how to put padding around the graphs. Any ideas?
mikary
@mikary
Mar 18 2016 18:36
Possibly adjusting the minimum padding on the axes?
Rowan Miller
@rowanmiller
Mar 18 2016 18:37
Or in SessionView.xam.cs.CurrentRun_Changed you could prgramatically add them in a grid that has a margin
Arthur Vickers
@ajcvickers
Mar 18 2016 18:37
What I really want to do is nest the controls inside another control, but I can't figure out how to do that given they are added to the grid programatically.
I'll try the margin on the grid.
mikary
@mikary
Mar 18 2016 18:38
I'd think you could programatically create another container and set margins on that, though the graphs are quirky about collapsing if they don't have a fixed height
Rowan Miller
@rowanmiller
Mar 18 2016 18:39
I'm going to get the RocketProfiler database on Azure ready for the demo, so avoid writing to that one :smile:
Arthur Vickers
@ajcvickers
Mar 18 2016 18:39
Okay
Got it. :-)
I was doing something dumb.
Arthur Vickers
@ajcvickers
Mar 18 2016 18:51
Pushed initial U.I. tweaks for run view
mikary
@mikary
Mar 18 2016 18:55
we just discovered that migrations packages are pretty well not going to work anymore
Arthur Vickers
@ajcvickers
Mar 18 2016 18:56
Can we make the new property NotMapped and just hard-code values for now?
Rowan Miller
@rowanmiller
Mar 18 2016 18:56
We were going to do a calculated prop that is 80% of max value
Arthur Vickers
@ajcvickers
Mar 18 2016 18:57
Sounds good.
Rowan Miller
@rowanmiller
Mar 18 2016 18:57
That way the only change is to swap it to a persisted get/set in the future
Arthur Vickers
@ajcvickers
Mar 18 2016 19:17
@rowanmiller Do you think start/end time displayed should be local or UTC?
Rowan Miller
@rowanmiller
Mar 18 2016 19:17
Not too concerned, maybe local...
mikary
@mikary
Mar 18 2016 19:19
I still favor UTC, but it might also make sense to indicate if it's UTC or local in the header
Arthur Vickers
@ajcvickers
Mar 18 2016 19:20
Pushed some look/feel changes to the session view
mikary
@mikary
Mar 18 2016 19:24
pushed threshold (hardcoded version)
Arthur Vickers
@ajcvickers
Mar 18 2016 19:30
Pushed color change
Rowan Miller
@rowanmiller
Mar 18 2016 19:30
Think we are good for the demo then :smile:
Arthur Vickers
@ajcvickers
Mar 18 2016 19:31
Did you do the splash screen?
mikary
@mikary
Mar 18 2016 19:32
So, locking down master for now? Time to add a dev branch? :D
Arthur Vickers
@ajcvickers
Mar 18 2016 19:32
I'm making a quick change to use local time.
Pushed it.