rrweb-io/rrweb#14 there is also some discussion about checkpoints in the recording side
The current timer interface makes all the things combining together, and an abstract clock you mentioned is good for solve some of the problem, especially for live streaming.
But the refactoring of the timer and the replay renderer worth a separate issue/pr, and the checkpoint part will focus on the event store:)
After the coding last night, I’m trying to figure out the impact of checkpoints in the recording side. It is useful to build some features like ‘store the last 10min records before an error exception’. But it will reset the mirror map. Firstly I need to test this will not cause racing problems since we have many async events. Secondly also need to check it will not break the future plan of searching/filtering events.
@Yuyz0112 the #223 is currently broken, am working on a fix... however I believe the 'should record dynamic CSS changes' test has been broken since at least rrweb-io/rrweb@197526f (going back further than that is giving me more general testing errors)
ok believe #223 now doesn't introduce any new broken tests.
feel free to ignore the note about master failing on 'should record dynamic CSS changes' ... looks like that's particular to my statcounter repository
this would enable either a green tick, or a red 'x' to appear beside the commit id in the pull request
@Yuyz0112 Hello. I got trouble implement two (or more) replays on one page. If there is only one replay it works fine. But as soon as we add a new replay to the page, the current one stop working. Any advice? Thank you.