Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 25 20:42
    vincenzocasu opened #472
  • Jan 24 10:23
    eoghanmurray opened #471
  • Jan 22 16:10
    eoghanmurray edited #464
  • Jan 22 16:06
    eoghanmurray edited #464
  • Jan 22 04:52
    Yuyz0112 closed #469
  • Jan 20 17:22
    eoghanmurray opened #470
  • Jan 20 16:36
    eoghanmurray synchronize #468
  • Jan 20 16:34
    eoghanmurray synchronize #464
  • Jan 20 16:20
    eoghanmurray synchronize #464
  • Jan 20 15:34
    Yuyz0112 closed #466
  • Jan 20 14:34
    MitsuhideA opened #469
  • Jan 20 13:56
    eoghanmurray opened #468
  • Jan 20 13:19
    joris closed #467
  • Jan 20 13:19
    joris opened #467
  • Jan 20 11:56
    eoghanmurray synchronize #466
  • Jan 20 11:45
    eoghanmurray opened #466
  • Jan 19 18:32
    eoghanmurray closed #465
  • Jan 19 18:27
    eoghanmurray opened #465
  • Jan 19 16:28
    eoghanmurray synchronize #464
  • Jan 19 11:58
    eoghanmurray synchronize #464
Daniël van de Giessen
@DvdGiessen
Just commented https://github.com/rrweb-io/rrweb/issues/6#issuecomment-452118538, turned out to be a longer comment than I expected. It's a rough idea I had, curious to hear whether others think that would be valuable to have.
yz-yu
@Yuyz0112
👍
rrweb-io/rrweb#14 there is also some discussion about checkpoints in the recording side
The current timer interface makes all the things combining together, and an abstract clock you mentioned is good for solve some of the problem, especially for live streaming.
yz-yu
@Yuyz0112
But the refactoring of the timer and the replay renderer worth a separate issue/pr, and the checkpoint part will focus on the event store:)
yz-yu
@Yuyz0112
After the coding last night, I’m trying to figure out the impact of checkpoints in the recording side. It is useful to build some features like ‘store the last 10min records before an error exception’.
But it will reset the mirror map. Firstly I need to test this will not cause racing problems since we have many async events. Secondly also need to check it will not break the future plan of searching/filtering events.
yz-yu
@Yuyz0112

Found a bug about shadow-DOM
rrweb-io/rrweb#38

Is there any other web component standard like this?

Eoghan Murray
@eoghanmurray
Hi @Yuyz0112 working on rrweb-io/rrweb#221 today
just wondering are there any tslint type tools that you use for code formatting?
yz-yu
@Yuyz0112
@eoghanmurray I use prettier for code formatting
Eoghan Murray
@eoghanmurray
ok cool, I'll try to get that running on my code before I submit! I'm pretty new to typescript so let me know if there's anything you want me to fix up in e.g. rrweb-io/rrweb#223
Eoghan Murray
@eoghanmurray
i.e. I wrote it to satisfy npm run typings after having started it from the definition at https://dom.spec.whatwg.org/#interface-mutationrecord
Eoghan Murray
@eoghanmurray
@Yuyz0112 the #223 is currently broken, am working on a fix...
however I believe the 'should record dynamic CSS changes' test has been broken since at least
rrweb-io/rrweb@197526f
(going back further than that is giving me more general testing errors)
Eoghan Murray
@eoghanmurray
ok believe #223 now doesn't introduce any new broken tests.
Eoghan Murray
@eoghanmurray
feel free to ignore the note about master failing on 'should record dynamic CSS changes' ... looks like that's particular to my statcounter repository

@Yuyz0112 would it be possible to turn on Service Hooks for Travis so that the test status of pull requests is visible?
e.g. see explanation here https://stackoverflow.com/a/19810474/6691
this would enable either a green tick, or a red 'x' to appear beside the commit id in the pull request
AngelaMossX
@AngelaMossX
@Yuyz0112 Hello. I got trouble implement two (or more) replays on one page. If there is only one replay it works fine. But as soon as we add a new replay to the page, the current one stop working. Any advice? Thank you.