Just commented https://github.com/rrweb-io/rrweb/issues/6#issuecomment-452118538, turned out to be a longer comment than I expected. It's a rough idea I had, curious to hear whether others think that would be valuable to have.
rrweb-io/rrweb#14 there is also some discussion about checkpoints in the recording side
The current timer interface makes all the things combining together, and an abstract clock you mentioned is good for solve some of the problem, especially for live streaming.
After the coding last night, I’m trying to figure out the impact of checkpoints in the recording side. It is useful to build some features like ‘store the last 10min records before an error exception’.
But it will reset the mirror map. Firstly I need to test this will not cause racing problems since we have many async events. Secondly also need to check it will not break the future plan of searching/filtering events.
But it will reset the mirror map. Firstly I need to test this will not cause racing problems since we have many async events. Secondly also need to check it will not break the future plan of searching/filtering events.
Hi @Yuyz0112 working on rrweb-io/rrweb#221 today
just wondering are there any tslint type tools that you use for code formatting?
just wondering are there any tslint type tools that you use for code formatting?
ok cool, I'll try to get that running on my code before I submit! I'm pretty new to typescript so let me know if there's anything you want me to fix up in e.g. rrweb-io/rrweb#223
in #223 I particularly struggled with the addition of the mutationRecord: https://github.com/rrweb-io/rrweb/commit/ee5038a5c8b4494b01f7d1a0b12ae65d0ef95e0c#diff-7824cb687fd8c900f6b5edd530c9080e
i.e. I wrote it to satisfy
npm run typings after having started it from the definition at https://dom.spec.whatwg.org/#interface-mutationrecord
@Yuyz0112 the #223 is currently broken, am working on a fix...
however I believe the 'should record dynamic CSS changes' test has been broken since at least
rrweb-io/rrweb@197526f
(going back further than that is giving me more general testing errors)
however I believe the 'should record dynamic CSS changes' test has been broken since at least
rrweb-io/rrweb@197526f
(going back further than that is giving me more general testing errors)
@Yuyz0112 would it be possible to turn on Service Hooks for Travis so that the test status of pull requests is visible?
e.g. see explanation here https://stackoverflow.com/a/19810474/6691
this would enable either a green tick, or a red 'x' to appear beside the commit id in the pull request
