Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Benoit Tigeot
    @benoittgt
    I am trying to test @mame proposal https://bugs.ruby-lang.org/issues/15897 against rspec-core test suite. At the moment I have issues applying patch https://gist.github.com/benoittgt/25789fee23cb16f5906f3f507241a0ec but this probably something simple.
    Yusuke Endoh
    @mame
    I'd be happy if you would attach an updated patch into the ticket :-)
    Benoit Tigeot
    @benoittgt
    Will do 😄
    Koichi Sasada
    @ko1
    If you find a hacking topic, I recommend you to check https://bugs.ruby-lang.org/issues/ issue tracker.
    there are many
    • discussing new features
    • unresolved bugs
    Yusuke Endoh
    @mame
    Unfortunately the first ticket at the present time seems a spam :cry:
    Koichi Sasada
    @ko1
    for unresolved bugs, reproducible script is very helpful for us.
    as @benoittgt say, trial new features and adding your opinion is also helpful.
    Yusuke Endoh
    @mame
    Currently there are whopping 1852 open tickets remained...
    Lewis Buckley
    @lewispb
    Could I help with issue triage @mame ?
    Edd
    @eddm_twitter
    is there any significance to the _P suffix in some function names?
    Yusuke Endoh
    @mame
    it represents "predicate" which returns a boolean
    Ah, _P not _p?
    I don't know _P
    Aaron Patterson
    @tenderlove
    @mame I deleted the spam
    Yusuke Endoh
    @mame
    Oh thank you :+1:
    Edd
    @eddm_twitter
    from what I can tell, that also applies to the capital _P versions, they're predicates (?). thanks!
    Yusuke Endoh
    @mame
    Ah, some macros uses _P
    Frederick Cheung
    @fcheung
    I'm playing with array1.overlaps?(array2) (equivalent to (array1 & array2).any? but without the intermediate object & returns as soon as a common element is found)
    Yusuke Endoh
    @mame
    :+1: :+1: :+1:
    Yasuhiro Yoshida
    @yoppuyoppu_twitter

    @ko1

    for unresolved bugs, reproducible script is very helpful for us.
    How do we find if a reported bug needs a reproducible script?
    Do we need to open bug reports one by one and see if a reproducible script has been added? Any way we can tell from the list?

    Ghost
    @ghost~5377c1e9048862e761fa1c25
    How can I install a gem in my locally built copy of MRI? gem install gives me cannot load such file -- openssl
    Koichi Sasada
    @ko1
    @yoppuyoppu_twitter Yes. you can specify search options.
    @chrisseaton make exts shows building extensions status. does openssl builds succeed?
    Ghost
    @ghost~5377c1e9048862e761fa1c25
    Ah need to configure it...
    Alan Wu
    @XrXr
    @ko1 I finished my patch for Bug #15620. Could you review it? ruby/ruby#2262
    Frederick Cheung
    @fcheung
    I made a PR with Array#overlaps - ruby/ruby#2260
    Koichi Sasada
    @ko1
    @XrXr thank you. it is difficult issue...
    @fcheung could you add a usecase?
    Frederick Cheung
    @fcheung
    @ko1 thanks, I have added some details
    Lewis Buckley
    @lewispb
    I made a PR with Array#pluck - ruby/ruby#2263
    Ghost
    @ghost~5377c1e9048862e761fa1c25
    Do we need to create RubyMine issues for new features before we create the GH PR?
    Made my PR! ruby/ruby#2264
    Yusuke Endoh
    @mame
    One of the most difficult tasks to make your feature request accepted is to get approval from matz. Today we have matz here, so this event is the best chance for you; you can appeal your request directly to matz :smirk:
    Ghost
    @ghost~5d1b5e86d73408ce4fc5116d
    Implemented Array#minmax here ruby/ruby#2265
    Anton Davydov
    @davydovanton
    Just adding missing tests for logger lib
    ruby/ruby#2266
    Koichi Sasada
    @ko1
    @chrisseaton Redmine ticket is helpful because only a few committers check PRs.
    usually we discuss an issue on redmine so if you can, please make redmine ticket and refer to github PRs
    Yusuke Endoh
    @mame
    @davydovanton I've merged your PR #2266 :+1:
    Ghost
    @ghost~5377c1e9048862e761fa1c25
    Anton Davydov
    @davydovanton
    @mame thanks! <3
    Yusuke Endoh
    @mame
    image.png
    Benoit Tigeot
    @benoittgt

    I am trying to test @mame proposal https://bugs.ruby-lang.org/issues/15897 against rspec-core test suite. At the moment I have issues applying patch https://gist.github.com/benoittgt/25789fee23cb16f5906f3f507241a0ec but this probably something simple.

    Ok. No issues with your patch @mame :)

    Yusuke Endoh
    @mame
    There are still untested code fragments in Logger::Period, but it looks dead code?
    @benoittgt Great to know, thank you!
    Yusuke Endoh
    @mame
    @davydovanton https://gist.github.com/ko1/35844fb7d5d637f5ca6213f760f1d71c
    The change caused our CI failed :cry:
    I, [2019-07-02T14:03:25.047487 #25130]  INFO -- :   1) Failure:
    I, [2019-07-02T14:03:25.047528 #25130]  INFO -- : TestLogPeriod#test_next_rotate_time [/tmp/ruby/v2/src/trunk-vm-asserts/test/logger/test_logperiod.rb:13]:
    I, [2019-07-02T14:03:25.047563 #25130]  INFO -- : <2019-07-19 00:00:00 +0100> expected but was
    I, [2019-07-02T14:03:25.047597 #25130]  INFO -- : <2019-07-19 00:00:00 +0000>.
    I, [2019-07-02T14:03:25.047629 #25130]  INFO -- : 
    I, [2019-07-02T14:03:25.047665 #25130]  INFO -- :   2) Failure:
    I, [2019-07-02T14:03:25.047698 #25130]  INFO -- : TestLogPeriod#test_next_rotate_time_extreme_cases [/tmp/ruby/v2/src/trunk-vm-asserts/test/logger/test_logperiod.rb:33]:
    I, [2019-07-02T14:03:25.047732 #25130]  INFO -- : <2018-07-02 00:00:00 +0100> expected but was
    I, [2019-07-02T14:03:25.047764 #25130]  INFO -- : <2018-07-02 00:00:00 +0000>.
    I, [2019-07-02T14:03:25.047795 #25130]  INFO -- : 
    I, [2019-07-02T14:03:25.047828 #25130]  INFO -- :   3) Failure:
    I, [2019-07-02T14:03:25.047860 #25130]  INFO -- : TestLogPeriod#test_previous_period_end [/tmp/ruby/v2/src/trunk-vm-asserts/test/logger/test_logperiod.rb:52]:
    I, [2019-07-02T14:03:25.047894 #25130]  INFO -- : <2019-07-17 23:59:59 +0100> expected but was
    I, [2019-07-02T14:03:25.047926 #25130]  INFO -- : <2019-07-17 23:59:59 +0000>.
    I, [2019-07-02T14:03:25.047957 #25130]  INFO -- : 
    I, [2019-07-02T14:03:25.047990 #25130]  INFO -- :   4) Failure:
    I, [2019-07-02T14:03:25.048023 #25130]  INFO -- : TestLogPeriod#test_previous_period_end_extreme_cases [/tmp/ruby/v2/src/trunk-vm-asserts/test/logger/test_logperiod.rb:72]:
    I, [2019-07-02T14:03:25.048055 #25130]  INFO -- : <2018-06-30 23:59:59 +0100> expected but was
    I, [2019-07-02T14:03:25.048107 #25130]  INFO -- : <2018-06-30 23:59:59 +0000>.
    Anton Davydov
    @davydovanton
    @mame I checked it , it's not dead code (TestLogDevice#test_shifting_dst_change failed without it). Will check what happened with CI now
    oh, I think it's timezone issue. Will fix it now, sorry
    Yusuke Endoh
    @mame
    Umm, the test passes on my laptop