rubyhackchallenge/LobbyEn

Ruby Hack Challenge (RHC) support room in English

Aaron Patterson

@tenderlove

@mame I deleted the spam

Yusuke Endoh

@mame

Oh thank you :+1:

Edd

@eddm_twitter

from what I can tell, that also applies to the capital _P versions, they're predicates (?). thanks!

Yusuke Endoh

@mame

Ah, some macros uses _P

Frederick Cheung

@fcheung

I'm playing with array1.overlaps?(array2) (equivalent to (array1 & array2).any? but without the intermediate object & returns as soon as a common element is found)

Yusuke Endoh

@mame

:+1: :+1: :+1:

Yasuhiro Yoshida

@yoppuyoppu_twitter

@ko1

for unresolved bugs, reproducible script is very helpful for us.
How do we find if a reported bug needs a reproducible script?
Do we need to open bug reports one by one and see if a reproducible script has been added? Any way we can tell from the list?

Ghost

@ghost~5377c1e9048862e761fa1c25

How can I install a gem in my locally built copy of MRI? gem install gives me cannot load such file -- openssl

Koichi Sasada

@ko1

@yoppuyoppu_twitter Yes. you can specify search options.

@chrisseaton make exts shows building extensions status. does openssl builds succeed?

Ghost

@ghost~5377c1e9048862e761fa1c25

Ah need to configure it...

Alan Wu

@XrXr

@ko1 I finished my patch for Bug #15620. Could you review it? ruby/ruby#2262

Frederick Cheung

@fcheung

I made a PR with Array#overlaps - ruby/ruby#2260

Koichi Sasada

@ko1

@XrXr thank you. it is difficult issue...

@fcheung could you add a usecase?

Frederick Cheung

@fcheung

@ko1 thanks, I have added some details

Lewis Buckley

@lewispb

I made a PR with Array#pluck - ruby/ruby#2263

Ghost

@ghost~5377c1e9048862e761fa1c25

Do we need to create RubyMine issues for new features before we create the GH PR?

Made my PR! ruby/ruby#2264

Yusuke Endoh

@mame

One of the most difficult tasks to make your feature request accepted is to get approval from matz. Today we have matz here, so this event is the best chance for you; you can appeal your request directly to matz :smirk:

Ghost

@ghost~5d1b5e86d73408ce4fc5116d

Implemented Array#minmax here ruby/ruby#2265

Anton Davydov

@davydovanton

Just adding missing tests for logger lib
ruby/ruby#2266

Koichi Sasada

@ko1

@chrisseaton Redmine ticket is helpful because only a few committers check PRs.

usually we discuss an issue on redmine so if you can, please make redmine ticket and refer to github PRs

Yusuke Endoh

@mame

@davydovanton I've merged your PR #2266 :+1:

Ghost

@ghost~5377c1e9048862e761fa1c25

https://bugs.ruby-lang.org/issues/15974

Anton Davydov

@davydovanton

@mame thanks! <3

Yusuke Endoh

@mame

Benoit Tigeot

@benoittgt

I am trying to test @mame proposal https://bugs.ruby-lang.org/issues/15897 against rspec-core test suite. At the moment I have issues applying patch https://gist.github.com/benoittgt/25789fee23cb16f5906f3f507241a0ec but this probably something simple.

Ok. No issues with your patch @mame :)

Yusuke Endoh

@mame

There are still untested code fragments in Logger::Period, but it looks dead code?

@benoittgt Great to know, thank you!

Yusuke Endoh

@mame

@davydovanton https://gist.github.com/ko1/35844fb7d5d637f5ca6213f760f1d71c
The change caused our CI failed :cry:

I, [2019-07-02T14:03:25.047487 #25130]  INFO -- :   1) Failure:
I, [2019-07-02T14:03:25.047528 #25130]  INFO -- : TestLogPeriod#test_next_rotate_time [/tmp/ruby/v2/src/trunk-vm-asserts/test/logger/test_logperiod.rb:13]:
I, [2019-07-02T14:03:25.047563 #25130]  INFO -- : <2019-07-19 00:00:00 +0100> expected but was
I, [2019-07-02T14:03:25.047597 #25130]  INFO -- : <2019-07-19 00:00:00 +0000>.
I, [2019-07-02T14:03:25.047629 #25130]  INFO -- : 
I, [2019-07-02T14:03:25.047665 #25130]  INFO -- :   2) Failure:
I, [2019-07-02T14:03:25.047698 #25130]  INFO -- : TestLogPeriod#test_next_rotate_time_extreme_cases [/tmp/ruby/v2/src/trunk-vm-asserts/test/logger/test_logperiod.rb:33]:
I, [2019-07-02T14:03:25.047732 #25130]  INFO -- : <2018-07-02 00:00:00 +0100> expected but was
I, [2019-07-02T14:03:25.047764 #25130]  INFO -- : <2018-07-02 00:00:00 +0000>.
I, [2019-07-02T14:03:25.047795 #25130]  INFO -- : 
I, [2019-07-02T14:03:25.047828 #25130]  INFO -- :   3) Failure:
I, [2019-07-02T14:03:25.047860 #25130]  INFO -- : TestLogPeriod#test_previous_period_end [/tmp/ruby/v2/src/trunk-vm-asserts/test/logger/test_logperiod.rb:52]:
I, [2019-07-02T14:03:25.047894 #25130]  INFO -- : <2019-07-17 23:59:59 +0100> expected but was
I, [2019-07-02T14:03:25.047926 #25130]  INFO -- : <2019-07-17 23:59:59 +0000>.
I, [2019-07-02T14:03:25.047957 #25130]  INFO -- : 
I, [2019-07-02T14:03:25.047990 #25130]  INFO -- :   4) Failure:
I, [2019-07-02T14:03:25.048023 #25130]  INFO -- : TestLogPeriod#test_previous_period_end_extreme_cases [/tmp/ruby/v2/src/trunk-vm-asserts/test/logger/test_logperiod.rb:72]:
I, [2019-07-02T14:03:25.048055 #25130]  INFO -- : <2018-06-30 23:59:59 +0100> expected but was
I, [2019-07-02T14:03:25.048107 #25130]  INFO -- : <2018-06-30 23:59:59 +0000>.

Anton Davydov

@davydovanton

@mame I checked it , it's not dead code (TestLogDevice#test_shifting_dst_change failed without it). Will check what happened with CI now

oh, I think it's timezone issue. Will fix it now, sorry

Yusuke Endoh

@mame

Umm, the test passes on my laptop

Ollie Haydon-Mulligan

@ollieh-m

Hi. We're trying to convert an unsigned integer into a string with a specified base, within rb_str_enumerate_codepoints, like this:

c = rb_enc_codepoint_len(ptr, end, &n, enc);
hex = rb_int2str(c, base);

where the types are:

unsigned int c;
VALUE hex;

But the strings we get back are not right... Any idea what we're getting wrong? How can we use rb_int2str (or is there another function we should use)?...

Thank you :smile:

Yusuke Endoh

@mame

Could you please show your expected result and actual one?

Ah I see

The variable c is C's unsigned int, and the first argument of rb_int2str is VALUE, so you need to convert its type

You may want to use UINT2NUM(c)

Ollie Haydon-Mulligan

@ollieh-m

Thank you. We are using UINT2NUM(c) :thumbsup: . We just realised the error was with the base being passed through. We thought it was 16, but it wasn't. Doh!

Anton Davydov

@davydovanton

@mame I created a issue about timezones in ruby bug tracker
https://bugs.ruby-lang.org/issues/15977

thanks for your help!

Yusuke Endoh

@mame

:+1:

Ollie Haydon-Mulligan

@ollieh-m

@aqeelvn and I made a PR to extend String#codepoints ruby/ruby#2270

Yusuke Endoh

@mame

@chrisseaton @tenderlove I've tested #2264 but it dumped core

[ 8943/20830] TestGCCompact#test_complex_hash_keys/home/mame/work/ruby/test/ruby/test_gc_compact.rb:130: [BUG] rb_gc_mark(): 0x000055f6dc0e5ff0 is T_MOVED
ruby 2.7.0dev (2019-07-02T15:36:31Z master 07a6428aaa) [x86_64-linux]

-- Control frame information -----------------------------------------------
c:0027 p:---- s:0161 e:000160 CFUNC  :verify_compaction_references
c:0026 p:0025 s:0156 e:000155 METHOD /home/mame/work/ruby/test/ruby/test_gc_compact.rb:130
/home/mame/work/ruby/test/ruby/test_gc_compact.rb:130: [BUG] Segmentation fault at 0x0000000000000000
ruby 2.7.0dev (2019-07-02T15:36:31Z master 07a6428aaa) [x86_64-linux]

-- Control frame information -----------------------------------------------
c:0027 p:---- s:0161 e:000160 CFUNC  :verify_compaction_references
c:0026 p:0025 s:0156 e:000155 METHOD /home/mame/work/ruby/test/ruby/test_gc_compact.rb:130
make: *** [uncommon.mk:767: yes-test-all] Segmentation fault (コアダンプしました)

I guess it is not due to the change itself, but it triggered the existing bug of GC compaction :smiling_imp:

Stefan Magnuson

@styrmis_twitter

I've just published the post on pattern matching, will add some more examples in due course: https://stefan.magnuson.co/posts/2019-07-02-initial-thoughts-on-ruby-pattern-matching/

Yusuke Endoh

@mame

:+1: :+1: :+1:

nitpick: , ** is not needed

Where communities thrive

People

Repo info

Activity