Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Rudi
@rudigiesler
Ah, it shows on the right, not in the chat
I thought it wasn't working
zoidbergwill
@zoidbergwill
Oh yeah, I also half expected it to be in chat
Rudi
@rudigiesler
okay, we have issues in the repo! (shotgun not working on documentation)
zoidbergwill
@zoidbergwill
Hahaha, I'll start looking at adding docs.
Are we gonna wait for the docs, or are we gonna tell confluence she can go ahead?
Rudi
@rudigiesler
We've told her she can go ahead
docs and tests and things can be added later, I think the product is good
were you aware of this before we started? http://flask-restful.readthedocs.org/en/latest/
zoidbergwill
@zoidbergwill
Sweet
I've seen that before
I looked at another one
didn't look at that one this time around
Wanna change to using it?
I looked at another one I've wanted to use for awhile but it was too heavy, then I stopped looking
Rudi
@rudigiesler
I think ours is easy enough to not need it
And I think it might be more restricting
I'm already having to craft a custom response to have a redirect with a body
zoidbergwill
@zoidbergwill
Yeah, Flask's responses are super basic.
Rudi
@rudigiesler
ready for review: v
rudigiesler/mathml-to-image-service#11
zoidbergwill
@zoidbergwill
One minor comment
Rudi
@rudigiesler
pushed changes
Rudi
@rudigiesler
#7 is ready for review
zoidbergwill
@zoidbergwill
Sorry, one minor thing.
Rudi
@rudigiesler
Sorry lunch took a while, I've pushed a commit that should fix it
zoidbergwill
@zoidbergwill
:+1:'ed
Rudi
@rudigiesler
thanks
@zoidbergwill are you working on documentation, or should I work on creating something?
zoidbergwill
@zoidbergwill
I've got the basic index page
Rudi
@rudigiesler
I'll write some tests for svg_to_image then
zoidbergwill
@zoidbergwill
Sweet
I've got the basic documentation stuff in a branch
I'll make a PR
I still need to add documentation for the actual use of the API
Rudi
@rudigiesler
Okay sure. Do you want two separate PR's for that?
zoidbergwill
@zoidbergwill
It should be chilled
I'll do it in one
Rudi
@rudigiesler
Okay I'll wait for it to be complete before I review
zoidbergwill
@zoidbergwill
Sweet, thanks
Rudi
@rudigiesler
#13 ready for review
zoidbergwill
@zoidbergwill
Still working on the tests for the svg converting stuff?
Rudi
@rudigiesler
nope, the tests are in the PR
I'm busy working on adding a quality setting
zoidbergwill
@zoidbergwill
Cool, was just wondering if I could review it
That 'ready for review' message for #13 didn't come through until I refreshed the page :/
Should I add the things to #13 that I suggested, while you work on the quality setting stuff?
Well I guess we can merge #13 or I can make a PR into it
zoidbergwill
@zoidbergwill
rudigiesler/mathml-to-image-service#15 ready for review
#14 ready for review