Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
zoidbergwill
@zoidbergwill
I'll make a PR
I still need to add documentation for the actual use of the API
Rudi
@rudigiesler
Okay sure. Do you want two separate PR's for that?
zoidbergwill
@zoidbergwill
It should be chilled
I'll do it in one
Rudi
@rudigiesler
Okay I'll wait for it to be complete before I review
zoidbergwill
@zoidbergwill
Sweet, thanks
Rudi
@rudigiesler
#13 ready for review
zoidbergwill
@zoidbergwill
Still working on the tests for the svg converting stuff?
Rudi
@rudigiesler
nope, the tests are in the PR
I'm busy working on adding a quality setting
zoidbergwill
@zoidbergwill
Cool, was just wondering if I could review it
That 'ready for review' message for #13 didn't come through until I refreshed the page :/
Should I add the things to #13 that I suggested, while you work on the quality setting stuff?
Well I guess we can merge #13 or I can make a PR into it
zoidbergwill
@zoidbergwill
rudigiesler/mathml-to-image-service#15 ready for review
#14 ready for review
Rudi
@rudigiesler
:+1: on both
zoidbergwill
@zoidbergwill
Thanks
Both merged
zoidbergwill
@zoidbergwill
Gonna check if the read the docs builds, then work on improving it
Rudi
@rudigiesler
okay cool, I've implemented most of the image size reduction things, now to see if it works properly
zoidbergwill
@zoidbergwill
Sorry, I'm being mean on the other pull request.
zoidbergwill
@zoidbergwill
Dammit, I lost internet for like 20 minutes
Rudi
@rudigiesler
haha, sorry was working on the quality feature, I'll take a look at the PR now
I've open #12 for the new feature
zoidbergwill
@zoidbergwill
Sweet, will take a look.
Rudi
@rudigiesler
Leaving for the airport now, not sure if I'll have internet there
zoidbergwill
@zoidbergwill
Cool, I'll leave one comment on #12
I :+1:'ed #13
Rudi
@rudigiesler
Okay I've merged all the PRs into master and into the remaining PR
Rudi
@rudigiesler
hmm whoops, shouldn't have merged that travis caching PR, it makes travis not run
Rudi
@rudigiesler
fixed travis
zoidbergwill
@zoidbergwill
Whoops
I didn't know YAML was so indentation sensitive
I :+1:'ed #12
Rudi
@rudigiesler
It wasn't the indentation, I just wanted to fix the indentation
it was more about having the cache: apt and the cache: directories as two separate things
zoidbergwill
@zoidbergwill
Oh
That makes sense
I meant to test that
Rudi
@rudigiesler
I should
've seen that it wasn't building travis
I just looked at the code, saw it was green and went ahead
zoidbergwill
@zoidbergwill
Yeah
There are ways to test it on different branches
I've got a docs branch locally I'll work on later.
And then we can add a post-commit hook to build the docs automatically
If you have a readthedocs account I can add you as an admin.
Rudi
@rudigiesler
I used this to find where the problem was: http://lint.travis-ci.org/ , quite useful