Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Steve Klabnik
    @steveklabnik
    iirc there was some sort of proposal to make them identical
    so then it didn't matter
    Niko Matsakis
    @nikomatsakis
    :+1: wish we would do
    Niko Matsakis
    @nikomatsakis
    @aidanhs did you see my comment here?
    it'd be good to settle on a policy
    in particular I wanted to declare them a "dup" of rust-lang/rust#47366
    which remains open
    aidanhs
    @aidanhs
    aha
    that makes more sense to me
    Niko Matsakis
    @nikomatsakis
    ok -- shall I close as "dups" then?
    aidanhs
    @aidanhs
    that sounds reasonable to me
    Niko Matsakis
    @nikomatsakis
    cool; otherwise they always catch my eye when I'm reviewing bugs ("unsoundness?!")
    aidanhs
    @aidanhs
    well I was about to ask that - what do you think about making the tracking issue p-medium?
    I'm reluctant to lose the fact that there are p-medium unsound bugs affecting stable
    Niko Matsakis
    @nikomatsakis
    well, that doesn't work for me
    oh, ok I had already started closing :)
    perhaps premature
    but P-medium is basically just "bug"
    in general, P-anything isn't very helpful imo, except for P-high, which means "review this weekly"
    aidanhs
    @aidanhs
    I see
    Niko Matsakis
    @nikomatsakis
    now, otoh, removing WG-compiler-nll might work
    i.e., since that is basically the list of bugs I am actively scanning
    it seems a bit weird to me but ... I guess "no more work is needed from NLL perspective"
    I'd be fine with that I suppose
    aidanhs
    @aidanhs
    alternative idea - in the tracking issue, just note if a bug is interesting for some reason (e.g. soundness fix)
    (as part of the bullet point)
    Niko Matsakis
    @nikomatsakis
    I try not to have bullet points in the tracking issue
    except for special cases
    too much maintenance burden
    I think removing the label is good
    the WG labels are kind of "action needed by this working group", after all
    aidanhs
    @aidanhs
    fair enough
    Niko Matsakis
    @nikomatsakis
    that sound, we probably should tag them with a priority
    (if they are going to stay open)

    I try not to have bullet points in the tracking issue

    To be clear, I was overstating the case here, but at least right now I am trying not to :)

    aidanhs
    @aidanhs
    :D
    two already had labels, I've given the other unsound one p-medium...p-low for the last because it requires a feature?
    Niko Matsakis
    @nikomatsakis
    @aidanhs I'd say P-medium probably
    aidanhs
    @aidanhs
    all done
    Niko Matsakis
    @nikomatsakis
    @aidanhs ty
    David Wood
    @davidtwco
    Out of curiosity, what does it mean when the homu queue says "TREE CLOSED"?
    kennytm
    @kennytm
    @davidtwco it means we stopped accepting new PRs
    this is due to Google's server being down https://status.cloud.google.com/incident/cloud-networking/18004
    David Wood
    @davidtwco
    Ah, interesting, thanks.
    kennytm
    @kennytm
    the tree will be reopened once that is fixed
    Matt
    @someguynamedmatt
    Not sure this is the right room, but looking around on the rust-lang/crates.io github issues page it's not immediately obvious which issue is Frontend and which is Backend. Would it be possible to create a label?
    Matt
    @someguynamedmatt
    When trying to get the backend up for crates.io (and following the directions found in the documentation), my db comes up empty. I'm sure I'm overlooking something easy, but I have no idea how to get the db populated. I ran diesel migration run, and nothin'.
    Carol (Nichols || Goulding)
    @carols10cents
    @someguynamedmatt to get crates in your local crates.io, you'll need to publish some crates to it :) There's instructions here: https://github.com/rust-lang/crates.io/blob/master/docs/CONTRIBUTING.md#publishing-a-crate-to-your-local-cratesio
    Matt
    @someguynamedmatt
    Awesome. Thanks, @carols10cents!!
    Diggory Hardy
    @dhardy
    Anyone looking for a 10-30 minute job, take a look at the top rand PRs and review/comment
    https://github.com/rust-lang-nursery/rand/pulls