Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Michael Lamparski
    @ExpHP
    Ah, something made me think it was merged
    probably the bors "auto-merge" commit which shows up in the tracking issue, though looking at it closer now it looks like there was some sort of failure
    Sunjay Varma
    @sunjay
    Thanks to @alexcrichton it's finally in a place where I'll be able to merge it through even though the changes break rustfmt and clippy. Then once it's merged we'll be able to merge the fixes in rustfmt and clippy. With all of that done I'll finally be able to continue with the rest of the work that I've been working on here and there in parallel with everything else. :smile:
    Michael Lamparski
    @ExpHP
    sounds awesome :D
    Sunjay Varma
    @sunjay
    Not what I was expecting when I first started the work, but it's been incredibly fun because of how much stuff I've learned about so many of the compiler tools. :smiley:
    Kevin Mehall
    @kevinmehall
    @sunjay, @ExpHP, have either of you started working on the parser changes for generic associated types? I'm interested in taking that on if not.
    Sunjay Varma
    @sunjay
    @kevinmehall yup! I'm working on it. I'm hoping to be done today or tomorrow. =)
    Kevin Mehall
    @kevinmehall
    @sunjay ah, I just started working on it too, but if you've gotten anywhere I'll let you finish it. :smile: I think I got it to parse, but the run-pass test fails to typecheck because it doesn't actually define the type variable yet.
    Sunjay Varma
    @sunjay
    Sorry about the conflict! I've been dealing with my first PR for this task for a while and then I was busy with other stuff so this is the first weekend I've really gotten to work on it. Thanks for taking a stab at it! :smile:
    Jonas Platte
    @jplatte

    Should probably finally ask this here, since https://gitter.im/rust-impl-period/WG-compiler-const is still silent..:

    Clippy doesn't compile any more after some changes I made. I can't just update it same as rustdoc it seems, bc. clippy is a submodule that x.py build auto-updates, while rustdoc isn't.

    How do I fix clippy / do I just ignore that it doesn't build?

    Sunjay Varma
    @sunjay
    Did you try updating to the latest nightly?
    Actually, it looks like you're running it from the rust repo
    Jonas Platte
    @jplatte
    Uh, sorry, didn't express myself clearly ^^
    I am working on const generics, and made some changes to the compiler
    Sunjay Varma
    @sunjay
    Try updating to the latest master in the rust repo (rebase if necessary)
    Jonas Platte
    @jplatte
    Clippy doesn't build because it depends on parts of the compiler, that I changed
    Sunjay Varma
    @sunjay
    I made some changes that broke clippy, but those have been fixed since then
    Jonas Platte
    @jplatte
    So it needs to be updated too
    Sunjay Varma
    @sunjay
    If you're using the latest clippy but not the latest rustc, it won't work
    Jonas Platte
    @jplatte
    So you had yours merged before a fix was available for clippy?
    and somebody else fixed clippy to work with your changes?
    Sunjay Varma
    @sunjay
    Yes. My changes to rustc that broke clippy were merged, then clippy fixed itself, and now everything should be good
    You need to have the latest version of everything though
    (assuming it is indeed my changes and not someone else's that are breaking your setup)
    Jonas Platte
    @jplatte
    Well mine aren't merged yet but x.py build tries to build clippy
    No it's my own changes
    Sunjay Varma
    @sunjay
    Oh
    Sorry I completely misunderstood then
    One sec
    Sorry for the confusion
    Those instructions should help
    Essentially you just need to tell the build to expect to be broken, and then that should fix it
    If not, @alexcrichton or someone else here can help you
    I'll try to help as much as I can =)
    Jonas Platte
    @jplatte
    Ah, yes that answers my question, thanks! :)
    Hopefully I can get back to progressing const generics tomorrow then! (it's already quite late here, but I thought I could at least get this cleared up today)
    Sunjay Varma
    @sunjay
    Glad I could help :smile:
    David Teller
    @Yoric
    Hi.
    I don't see much activity here, does this mean that the work on compiler traits is complete?
    Niko Matsakis
    @nikomatsakis
    no, not really, it just means that we basically didn't have the bandwidth to push these changes through -- I think not until next year
    @Yoric if you're looking for things, consider https://github.com/rust-lang/rust/milestone/42
    over in WG-compiler-nll :)
    there's a number of small diagnostic issues that need to be tackled
    David Teller
    @Yoric
    @nikomatsakis Yeah, I am looking for a good place to get back into Rust contributions.
    David Teller
    @Yoric
    @nikomatsakis I don't think that any of these bugs is mentored, do you have suggestions on which one to start with?
    Niko Matsakis
    @nikomatsakis
    @Yoric maybe rust-lang/rust#46472, I can try to add some mentoring instructions
    David Teller
    @Yoric
    @nikomatsakis I assume that the idea is not just to change strings in src/librustc_borrowck/borrowck/mod.rs and/or src/librustc_mir/borrow_check.rs, but also to explicitly reference 'a and its scope, right?
    Niko Matsakis
    @nikomatsakis
    @Yoric right -- actually can you hop into WG-compiler-nll? better channel for it
    sorry for delay :)