Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 02 13:56

    killercup on gh-pages

    Deploy rust-lang-nursery/cli-wg… (compare)

  • Nov 02 13:55

    killercup on gh-pages

    Deploy rust-lang-nursery/cli-wg… (compare)

  • Nov 02 13:53
    killercup synchronize #58
  • Nov 02 13:52

    killercup on master

    Fix typo and style Add missing… Fix typo and style (#150) Fix … (compare)

  • Nov 02 13:52
    killercup closed #150
  • Nov 02 13:52
    killercup synchronize #58
  • Nov 02 13:52

    killercup on master

    Drop unnecessary comments in sh… Merge pull request #151 from st… (compare)

  • Nov 02 13:52
    killercup closed #151
  • Nov 02 13:52
    killercup commented #151
  • Nov 01 02:09

    killercup on gh-pages

    Deploy rust-lang-nursery/cli-wg… (compare)

  • Nov 01 02:06
    Dylan-DPC synchronize #58
  • Nov 01 02:05

    Dylan-DPC on master

    Fix grammar (#152) (compare)

  • Nov 01 02:05
    Dylan-DPC closed #152
  • Oct 31 22:46
    stomar opened #152
  • Oct 31 22:04
    stomar opened #151
  • Oct 31 21:29
    stomar opened #150
  • Oct 31 18:32

    killercup on gh-pages

    Deploy rust-lang-nursery/cli-wg… (compare)

  • Oct 31 18:28
    Dylan-DPC synchronize #58
  • Oct 31 18:28

    Dylan-DPC on master

    Use code blocks for output (#14… (compare)

  • Oct 31 18:28
    Dylan-DPC closed #149
Daniel Sockwell
@codesections
I guess we could do it all with cargo-make? That seems like something in your wheelhouse, @epage
maybe it's too much of a heavyweight tool for installing man pages, though?
Daniel Sockwell
@codesections
I concluded you're right and seperate binaries are the way to go
Ed Page
@epage
Another option, depending on weight of the generators and your flag validation rules, is to have visible or hidden flags in the main program to do the generation. At least for some CLIs, that is done for completions though man pages are probably a different case.
Daniel Sockwell
@codesections
Yeah, I actually did that for a past CLI a few weeks ago but it felt a bit hacky to have as a hidden command and it felt like it cluttered things up to have as a visible one :shrug:
Jacob Finkelman
@Eh2406
I could use some help getting japaric/trust set up correctly for cargo-sweep
The most recent try is at holmgr/cargo-sweep#18
My goal at the moment is just to let people use it on travise without having to build from source
Jacob Finkelman
@Eh2406
I thought someone hare may have some advice.
Daniel Sockwell
@codesections
I wish I did, but I haven't faced that particular challenge—or even built pre-compiled binaries yet. But I'm interested to hear what answers you might get.
and cargo-sweep sounds like an interesting tool; glad I learned about it by following your link :)
Ed Page
@epage
@Eh2406 sorry I missed that I was tagged in it
What specific problem are you having with trust atm?
Jacob Finkelman
@Eh2406
It looks like it did not make prebuilt binaries with the release, as such we did not succeed at using the install script
So we messed up one or the other of setting up trust or using the install script
Ed Page
@epage
Yeah, trust is not my favorite but there isn't better yet
I keep pushing off cargo-tarball for other things; I really need to set aside some time to implement it
Would take away some of the trust boilet plate
Jacob Finkelman
@Eh2406
here is a simple test of the install script https://travis-ci.org/Eh2406/cargo/jobs/484542914#L621-L631
Ed Page
@epage
Not seeing any output from your before_deploy. Looking at your deploy, I see on: tags: true but I'm not seeing any tags in your travis history
https://travis-ci.org/holmgr/cargo-sweep/builds
Yeah, install.sh assumes the binary will be available at https://github.com/holmgr/cargo-sweep/releases which is what trust deploys to.
So you can just look at that page to see whether it is install.sh or your CI setup
Jacob Finkelman
@Eh2406
So you're working hypothesis is @holmgr made the release in the wrong way?
Ed Page
@epage
Not wrong, just missing a step (tagging). You can tag after the fact
Jacob Finkelman
@Eh2406
Ed Page
@epage
Oh, you're right
"/^v\\d+\\.\\d+\\.\\d+.*$/".travis.yml is only configured for tags that start with v.
So either changing .travis.yml or adding a new tag v0.4.0 should get it kick started
Jacob Finkelman
@Eh2406
so changing that line to "/^v?\\d+\\.\\d+\\.\\d+.*$/" will make it work?
Ed Page
@epage
For future tags, yes
Jacob Finkelman
@Eh2406
I do not have permissions on the repo, to test myself, but do you have instructions for how to trigger a build on the existing release?
Ed Page
@epage
If the build existed, you'd see a rebuild button
but for a tag that it ignored, I have no idea
Jacob Finkelman
@Eh2406
Ok, thanks for all the help!
Ed Page
@epage
Like I said, you could always re-tag the commit with v0.4.0 and then travis will pick it up
Ed Page
@epage
Ah, it assumes v as well
Jacob Finkelman
@Eh2406
does that mean that the name needs to start with a v for install to work
Ed Page
@epage
Yup
Jacob Finkelman
@Eh2406
ok closing my pr.
Ed Page
@epage
It has to know what tags are relevant
Jacob Finkelman
@Eh2406
I closed my pr to cargo sweep holmgr/cargo-sweep#21
Jacob Finkelman
@Eh2406
I don't have perms, so hopefully @holmgr can retag things this weekend, and we will see if it is fully working.
Jacob Finkelman
@Eh2406
set up travis on my fork, and pushed a tag: https://github.com/Eh2406/cargo-sweep/releases/tag/v0.4.0
Jacob Finkelman
@Eh2406
It picked up the tag and tried to deploy but it has his secrets, so it did not work.
https://travis-ci.org/Eh2406/cargo-sweep/jobs/484559290#L267
https://travis-ci.org/Eh2406/cargo-sweep/jobs/484559285#L647
So it looks like changing the tags will work.
Thanks for the help!
Ed Page
@epage
You're welcome
Ed Page
@epage
RE assert_cmd 1.0
This is in the works.
I've been letting it sit to gather feedback before bumping to 1.0. This led to assert-rs/assert_cmd#69 and am in that same holding pattern; waiting for people to upgrade, try it out, and report back problems

assert_fs is in a similar boat but less controversial in my mind; I'd be willing to bump that any time.

Should they both go in the same announcement post?