Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Manish Goregaokar
    @Manishearth
    yo
    Oliver Schneider
    @oli-obk
    aloha
    Clippy has made me a bad programmer. I keep screwing up things that I outsourced to clippy if clippy is not on (like in the compiler)
    I'm thinking we could inject a clippy that works on stage0 into x.py :D
    Pascal Hertleif
    @killercup
    yes that's definitely the correct solution to your problem
    Manish Goregaokar
    @Manishearth
    Lol
    Sebastian Malton
    @Nokel81
    Hello I am interested in starting to work on clippy. Is there some good starting issues?
    Manish Goregaokar
    @Manishearth
    yeah, they're tagged "easy"
    Sebastian Malton
    @Nokel81
    Thanks
    Philipp Hansch
    @phansch
    hey hey :)
    Nick Cameron
    @nrc
    @oli-obk @Manishearth so tool attributes landed a couple of weeks ago and I just moved rustfmt over to using rustfmt::skip. I'd love to stabilise this quickly so I can 1.0 rustfmt, would Clippy be able to start using the scoped attributes soon?
    Oliver Schneider
    @oli-obk
    @nrc sure, that sounds easy enough to do
    Nick Cameron
    @nrc
    :+1:
    Oliver Schneider
    @oli-obk
    @nrc I moved clippy to scoped attributes in 0.0.203 (today's release)
    General question: do we expect clippy to be a part of the 2018 release?
    Nick Cameron
    @nrc
    that's a good question, and I'm not sure
    we're talked about not having tools being part of the 2018 thing, but given how close the 1.0 of RLS and Rustfmt are in terms of the date, they're kind of being included
    we should think about Clippy too - I think it should be 1.0-ready, right?
    Danny Fritz
    @dannyfritz
    how much is clippy tied to RLS or Rust versions?
    Nick Cameron
    @nrc
    I don't think Clippy is tied to the RLS. Both Clippy and RLS are strongly tied to the Rust version - they use the compiler's internals, so need to have exact versioning
    Oliver Schneider
    @oli-obk
    @nrc my main blocker is that I do not have time to implement the rustup side for not updating nightly to versions without clippy if the clippy component is installed
    Nick Cameron
    @nrc
    @oli-obk I don't think we need to do that
    we would make broken clippy block nightly and that is build system stuff and I think just setting a flag
    Oliver Schneider
    @oli-obk
    oh? so we just switch clippy as a nightly blocker after the rfc?
    Nick Cameron
    @nrc
    unless there is so much breakage that it is untenable, then that is the best solution
    Oliver Schneider
    @oli-obk
    @nrc that is great news, the last info I had was that any further clippy work is blocked on the rustup changes
    well... we can speed up the process if we allow tool submodule update PRs to be self-r+ed
    Nick Cameron
    @nrc
    it is usually quick to get r+ IME, if I don't get one in 5 mins I just ask somebody on rust-internals to rubber stamp it
    Oliver Schneider
    @oli-obk
    ok
    Nick Cameron
    @nrc
    and we can always make them p=1 so they land quickly
    Oliver Schneider
    @oli-obk
    yea that's a given
    Nick Cameron
    @nrc
    cool
    it will be good to have data on breakage over the next few weeks
    if there is a lot then we'll have to go with the rustup route, and I should be able to help with that - I expect to have a bit of time after the all-hands
    but ideally we'd go with the build system
    Oliver Schneider
    @oli-obk
    yea. I still am trying to figure out how to coordinate the clippy in rls integration
    Nick Cameron
    @nrc
    the problem there being breakage in clippy knocking on to the RLS?
    Oliver Schneider
    @oli-obk
    no, it's a versioning problem
    if we release a new clippy version, rls still depends on the old one
    there's no cargo feature to force version bumps, you can only override specific versions
    we might be able to do a clippy 0.1 release and then just bump patch versions
    rls would then just depend on clippy 0.1 and each cargo update automatically moves you to the newest version
    Nick Cameron
    @nrc
    oh I see
    Oliver Schneider
    @oli-obk
    but that's slightly bad if you're trying to build an old rustc
    Nick Cameron
    @nrc
    doesn't patch do that?
    Oliver Schneider
    @oli-obk
    *on an
    nope, with rustfmt patch works because you always bump in tandem